f0fe1b88ca
* Make isDefinition aware of target symbol
Initial code, haven't fixed any tests yet.
* Update baselines
This commit includes a regression for commonjs aliases:
```js
// @filename: a.js
function f() { }
module.exports.f = f
// @filename: b.js
const { f } = require('./a')
f/**/
```
Now says that `f` in b.js has 1 reference --
the alias `module.exports.f = f`. This is not correct (or not exactly
correct), but correctly fixing will involve re-creating the ad-hoc
commonjs alias resolution code from the checker. I don't think it's
worth it for an edge case like this.
* update more unit tests
* Fix symbol lookup for constructors
* More baselines + two fixes
1. Fix `default` support.
2. Add a secondary declaration location for commonjs assignment
declarations.
* Update rest of baselines
* Switch a few more tests over to baselines
384 lines
7.9 KiB
Plaintext
384 lines
7.9 KiB
Plaintext
// === /tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts ===
|
|
// var /*FIND ALL REFS*/[|dx|] = "Foo";
|
|
//
|
|
// module M { export var dx; }
|
|
// module M {
|
|
// var z = 100;
|
|
// export var y = { dx, z };
|
|
// }
|
|
// M.y.dx;
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"kind": "var",
|
|
"name": "var dx: string",
|
|
"textSpan": {
|
|
"start": 4,
|
|
"length": 2
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "var",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "dx",
|
|
"kind": "localName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "string",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 15
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 4,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"contextSpan": {
|
|
"start": 0,
|
|
"length": 15
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts ===
|
|
// var dx = "Foo";
|
|
//
|
|
// module M { export var /*FIND ALL REFS*/[|dx|]; }
|
|
// module M {
|
|
// var z = 100;
|
|
// export var y = { [|dx|], z };
|
|
// }
|
|
// M.y.dx;
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"kind": "var",
|
|
"name": "var M.dx: any",
|
|
"textSpan": {
|
|
"start": 39,
|
|
"length": 2
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "var",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "M",
|
|
"kind": "moduleName"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "dx",
|
|
"kind": "localName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "any",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 28,
|
|
"length": 14
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 39,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"contextSpan": {
|
|
"start": 28,
|
|
"length": 14
|
|
},
|
|
"isWriteAccess": false,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 92,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts ===
|
|
// var dx = "Foo";
|
|
//
|
|
// module M { export var [|dx|]; }
|
|
// module M {
|
|
// var z = 100;
|
|
// export var y = { /*FIND ALL REFS*/[|dx|], z };
|
|
// }
|
|
// M.y.[|dx|];
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"kind": "var",
|
|
"name": "var M.dx: any",
|
|
"textSpan": {
|
|
"start": 39,
|
|
"length": 2
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "var",
|
|
"kind": "keyword"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "M",
|
|
"kind": "moduleName"
|
|
},
|
|
{
|
|
"text": ".",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "dx",
|
|
"kind": "localName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "any",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 28,
|
|
"length": 14
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 39,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"contextSpan": {
|
|
"start": 28,
|
|
"length": 14
|
|
},
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 92,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"kind": "property",
|
|
"name": "(property) dx: any",
|
|
"textSpan": {
|
|
"start": 92,
|
|
"length": 2
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "dx",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "any",
|
|
"kind": "keyword"
|
|
}
|
|
]
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 107,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts ===
|
|
// var dx = "Foo";
|
|
//
|
|
// module M { export var dx; }
|
|
// module M {
|
|
// var z = 100;
|
|
// export var y = { [|dx|], z };
|
|
// }
|
|
// M.y./*FIND ALL REFS*/[|dx|];
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"kind": "property",
|
|
"name": "(property) dx: any",
|
|
"textSpan": {
|
|
"start": 92,
|
|
"length": 2
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "dx",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "any",
|
|
"kind": "keyword"
|
|
}
|
|
]
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 92,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 107,
|
|
"length": 2
|
|
},
|
|
"fileName": "/tests/cases/fourslash/findAllRefsWithShorthandPropertyAssignment2.ts",
|
|
"isWriteAccess": false,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
] |