2f0c8b2bea
* wip: add types * wip * Add cases * Add some case * Add more check * accept baseline * add abstract abd declare method * add override in declaration * accept baseline * add property override * Fix decalre modifier * update baseline * Add more cases * make lint happy * make lint happy * Update description * Add codefix * simplify code * accept baseline * Update desc * Accept baseline * Add override completions * filter out implements field in override context * fix tests * Add parameter property check * Accept baseline * acept baseline * Add parameter property to declaration code action * Add quickfix for override parameter property * fix code style * Add override with interface tests * Add more cases about modifier position * rename flag * rename flags * Added tests. * Accepted baselines. * Always issue errors for unnecessary 'override' modifiers. * Accepted baselines. * Override perf (#4) * try cache check result * pre check for override * Do not issue error if implement abstract * Add abstract-spec check * Avoid override dead lock * Add more case * Add codefix for new error * Fix error message * Add jsdoc override tag (#6) * Override jsdoc tag (#7) * accept baseline * Disallow codefix in js * update baseline * Omit override in d.ts * Add more case in js * Accept baseline * fix override js test * fix crlf * Revert merge conflict changes * Accept baseline * Avoid space * Fix CR issues * Accept baseline * Fix typo and add more check * Fix error name Co-authored-by: Daniel Rosenwasser <Daniel.Rosenwasser@microsoft.com>
35 lines
1.4 KiB
Plaintext
35 lines
1.4 KiB
Plaintext
tests/cases/conformance/override/override2.ts(13,14): error TS4116: This member must have an 'override' modifier because it overrides an abstract method that is declared in the base class 'AB'.
|
|
tests/cases/conformance/override/override2.ts(18,14): error TS4116: This member must have an 'override' modifier because it overrides an abstract method that is declared in the base class 'AB'.
|
|
|
|
|
|
==== tests/cases/conformance/override/override2.ts (2 errors) ====
|
|
abstract class AB {
|
|
abstract foo(v: string): void;
|
|
|
|
abstract bar(v: string): void;
|
|
abstract baz(v: string): void;
|
|
}
|
|
|
|
abstract class AD1 extends AB {
|
|
|
|
}
|
|
|
|
abstract class AD2 extends AB {
|
|
abstract foo(v: ''): void // need override?
|
|
~~~
|
|
!!! error TS4116: This member must have an 'override' modifier because it overrides an abstract method that is declared in the base class 'AB'.
|
|
}
|
|
|
|
abstract class AD3 extends AB {
|
|
override foo(v: ''): void { } // need override?
|
|
abstract bar(): void;
|
|
~~~
|
|
!!! error TS4116: This member must have an 'override' modifier because it overrides an abstract method that is declared in the base class 'AB'.
|
|
baz(): void { }
|
|
}
|
|
|
|
class D4 extends AB {
|
|
override foo(v: ''): void {}
|
|
override bar(v: ''): void {}
|
|
baz(): void { }
|
|
} |