af689cc5d5
* es private fields in in (#52) add support for the 'private-fields-in-in' TC39 proposal Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [fixup] include inToken when walking forEachChild(node, cb) * [squash] re-accept lib definition baseline changes * [squash] reduce if/else to ternary Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] drop 'originalName' and rename parameter instead Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] extend spelling suggestion to all privateIdentifiers Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] revert the added lexical spelling suggestions logic Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] update baseline Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] inline variable as per PR suggestion Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] test targets both esnext and es2020 as per PR comment Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * switch to using a binary expression Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] PrivateIdentifier now extends PrimaryExpression Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] accept public api baseline changes Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] classPrivateFieldInHelper now has documentation Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] type-check now follows existing in-expression path Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] parser now follows existing binaryExpression path Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] correct typo in comment Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] no longer use esNext flag Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] swap 'reciever, state' helper params Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] remove change to parenthesizerRules Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] apply suggested changes to checker Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] remove need for assertion in fixSpelling Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] improve comment hint in test Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] fix comment typos Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] add flow-test for Foo | FooSub | Bar Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] add checkExternalEmitHelpers call and new test case Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] simplify and correct parser Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] move most of the added checker logic to expression level Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] always error when privateId could not be resolved Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] reword comment Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] fix codeFixSpelling test Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] do less work Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * store symbol by priateId not binaryExpression Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * moved parsePrivateIdentifier into parsePrimaryExpression Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] checkInExpressionn bails out early on silentNeverType Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] more detailed error messages Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] resolves conflict in diagnosticMessages.json Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] update baseline for importHelpersES6 Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] remove redundent if and comment from parser Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] split up grammar/check/symbolLookup Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com> * [squash] reword message for existing left side of in-expression error Signed-off-by: Ashley Claymore <acutmore@users.noreply.github.com>
113 lines
5.1 KiB
Plaintext
113 lines
5.1 KiB
Plaintext
=== tests/cases/conformance/classes/members/privateNames/privateNameInInExpressionTransform.ts ===
|
|
class Foo {
|
|
>Foo : Symbol(Foo, Decl(privateNameInInExpressionTransform.ts, 0, 0))
|
|
|
|
#field = 1;
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
|
|
#method() {}
|
|
>#method : Symbol(Foo.#method, Decl(privateNameInInExpressionTransform.ts, 1, 15))
|
|
|
|
static #staticField= 2;
|
|
>#staticField : Symbol(Foo.#staticField, Decl(privateNameInInExpressionTransform.ts, 2, 16))
|
|
|
|
static #staticMethod() {}
|
|
>#staticMethod : Symbol(Foo.#staticMethod, Decl(privateNameInInExpressionTransform.ts, 3, 27))
|
|
|
|
check(v: any) {
|
|
>check : Symbol(Foo.check, Decl(privateNameInInExpressionTransform.ts, 4, 29))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 6, 10))
|
|
|
|
#field in v; // expect Foo's 'field' WeakMap
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 6, 10))
|
|
|
|
#method in v; // expect Foo's 'instances' WeakSet
|
|
>#method : Symbol(Foo.#method, Decl(privateNameInInExpressionTransform.ts, 1, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 6, 10))
|
|
|
|
#staticField in v; // expect Foo's constructor
|
|
>#staticField : Symbol(Foo.#staticField, Decl(privateNameInInExpressionTransform.ts, 2, 16))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 6, 10))
|
|
|
|
#staticMethod in v; // expect Foo's constructor
|
|
>#staticMethod : Symbol(Foo.#staticMethod, Decl(privateNameInInExpressionTransform.ts, 3, 27))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 6, 10))
|
|
}
|
|
precedence(v: any) {
|
|
>precedence : Symbol(Foo.precedence, Decl(privateNameInInExpressionTransform.ts, 11, 5))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
|
|
// '==' and '||' have lower precedence than 'in'
|
|
// 'in' naturally has same precedence as 'in'
|
|
// '<<' has higher precedence than 'in'
|
|
|
|
v == #field in v || v; // Good precedence: (v == (#field in v)) || v
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
|
|
v << #field in v << v; // Good precedence (SyntaxError): (v << #field) in (v << v)
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
|
|
v << #field in v == v; // Good precedence (SyntaxError): ((v << #field) in v) == v
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
|
|
v == #field in v in v; // Good precedence: v == ((#field in v) in v)
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
|
|
#field in v && #field in v; // Good precedence: (#field in v) && (#field in v)
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 12, 15))
|
|
}
|
|
invalidLHS(v: any) {
|
|
>invalidLHS : Symbol(Foo.invalidLHS, Decl(privateNameInInExpressionTransform.ts, 26, 5))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 27, 15))
|
|
|
|
'prop' in v = 10;
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 27, 15))
|
|
|
|
#field in v = 10;
|
|
>#field : Symbol(Foo.#field, Decl(privateNameInInExpressionTransform.ts, 0, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 27, 15))
|
|
}
|
|
}
|
|
|
|
class Bar {
|
|
>Bar : Symbol(Bar, Decl(privateNameInInExpressionTransform.ts, 31, 1))
|
|
|
|
#field = 1;
|
|
>#field : Symbol(Bar.#field, Decl(privateNameInInExpressionTransform.ts, 33, 11))
|
|
|
|
check(v: any) {
|
|
>check : Symbol(Bar.check, Decl(privateNameInInExpressionTransform.ts, 34, 15))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 35, 10))
|
|
|
|
#field in v; // expect Bar's 'field' WeakMap
|
|
>#field : Symbol(Bar.#field, Decl(privateNameInInExpressionTransform.ts, 33, 11))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 35, 10))
|
|
}
|
|
}
|
|
|
|
function syntaxError(v: Foo) {
|
|
>syntaxError : Symbol(syntaxError, Decl(privateNameInInExpressionTransform.ts, 38, 1))
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 40, 21))
|
|
>Foo : Symbol(Foo, Decl(privateNameInInExpressionTransform.ts, 0, 0))
|
|
|
|
return #field in v; // expect `return in v` so runtime will have a syntax error
|
|
>v : Symbol(v, Decl(privateNameInInExpressionTransform.ts, 40, 21))
|
|
}
|
|
|
|
export { }
|
|
|