e638af7560
* Added support for private identifier methods. * Added tests for private methods. * Added check to only not allow private name method signatures in anything except classes. Changes objects literal checking to not bail on first private name found in object literal. * Added private accessors tests * Transform private methods Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Rename shouldTransformPrivateFields Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Accept baseline Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Use a single WeakSet for brand-check Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Accept baseline Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Add a test for using private methods in static field initializers Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Add breaking checker test Private methods inside class expressions should not error. Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Add to instances once per-instance Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Accept baseline Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: evaluate receiver and rhs expressions before throwing on readonly assignment Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Add a test for evaluating rhs before readonly assignment Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Transpile private accessors Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Accept baseline Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: handle readonly/writeonly accessors Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * accept baseline Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * add a test for private setter without a getter Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: getAllUnscopedEmitHelpers Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: better handling of duplicate names Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Fixed wrong error message for private methods in class expressions. * change error message Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * add a test for async private methods with a higher target Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: setter assignment returns rhs value Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * add a test for setter assignment return value Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: handle duplicate accessors Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * add tests for duplicate accessors Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * docs: add missing parameter docs Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Fixed failing test. * baseline-accept: ordering changes Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * fix: attach weakSetName to property declaration Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * add a test for nested private methods Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * add a test with any Signed-off-by: Kubilay Kahveci <kahvecikubilay@gmail.com> * Added support for static private fields accessors and methods. * Added error message for private identifiers used with static decorators. There is no spec to go with this behavior as of yet. * Fixed emit static bug that used private names outside of classes for initialization in esnext. Fixed issue where nested privates produce incorrect brand check. * Added tests for private static fields methods and accessors. * Fixed error messages and tests after merge. * Accept new baseline. * Improved duplicate identifier checks for static private class elements. * Added error when using initializers with private static fields when useDefineForClassFields is not specified and target is esnext. * Fixed code review issues. * Removed semantically wrong emit on `useDefineForClassFields:true` with `target:esnext` * Changed emit for uninitialized private static fields. * Added runtime error in helper if a static private field is accessed before it was declared. * Fixed code review comments for private identifier static class elements. * add debug.assertNever for unknown node type (#53) * Fixed code review issues. * Fixed code review issues for private class elements. * Fixes class shadowing when checking access to a private static class element. * fix private methods/accessors in class expr inside a loop * collapse switch case * fix class name * simplify getPrivateMethodsAndAccessors * remove findPreviousAccessorInfo * lazily create weakSetName identifier * do not allocate a node if not needed in visitMehodDeclaration (#55) * Removed all the emit helpers for private identifier methods accessors and modified the existing helpers for get and set fields to do the same job. * Simplified emit for private identifier class elements. * do not clone the receiver (#57) * leave bad code in for #constructor and duplicate private names (#58) * Added check for WeakSet collision. * Added error for using a set only accessor. * update keyof tests and ?? (#62) * replace ?? with || * update keyof tests * fix emit helpers comments * produce an error if private field helpers are not up to date * add tests * fix setter-only compound assignment * fix tests * fix duplicated trailing comments (#64) * clear receiver pos and setTextRange on helper calls Co-authored-by: Kubilay Kahveci <kahvecikubilay@gmail.com>
120 lines
5.6 KiB
Plaintext
120 lines
5.6 KiB
Plaintext
=== tests/cases/conformance/classes/members/privateNames/privateWriteOnlyAccessorRead.ts ===
|
|
class Test {
|
|
>Test : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
|
|
set #value(v: { foo: { bar: number } }) {}
|
|
>#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 1, 13))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
>bar : Symbol(bar, Decl(privateWriteOnlyAccessorRead.ts, 1, 24))
|
|
|
|
set #valueRest(v: number[]) {}
|
|
>#valueRest : Symbol(Test.#valueRest, Decl(privateWriteOnlyAccessorRead.ts, 1, 44))
|
|
>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 2, 17))
|
|
|
|
set #valueOne(v: number) {}
|
|
>#valueOne : Symbol(Test.#valueOne, Decl(privateWriteOnlyAccessorRead.ts, 2, 32))
|
|
>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 3, 16))
|
|
|
|
set #valueCompound(v: number) {}
|
|
>#valueCompound : Symbol(Test.#valueCompound, Decl(privateWriteOnlyAccessorRead.ts, 3, 29))
|
|
>v : Symbol(v, Decl(privateWriteOnlyAccessorRead.ts, 4, 21))
|
|
|
|
m() {
|
|
>m : Symbol(Test.m, Decl(privateWriteOnlyAccessorRead.ts, 4, 34))
|
|
|
|
const foo = { bar: 1 };
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 7, 9))
|
|
>bar : Symbol(bar, Decl(privateWriteOnlyAccessorRead.ts, 7, 17))
|
|
|
|
console.log(this.#value); // error
|
|
>console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
|
|
>console : Symbol(console, Decl(lib.dom.d.ts, --, --))
|
|
>log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --))
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
|
|
this.#value = { foo }; // ok
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 9, 19))
|
|
|
|
this.#value = { foo }; // ok
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 10, 19))
|
|
|
|
this.#value.foo = foo; // error
|
|
>this.#value.foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 7, 9))
|
|
|
|
({ o: this.#value } = { o: { foo } }); //ok
|
|
>o : Symbol(o, Decl(privateWriteOnlyAccessorRead.ts, 13, 6))
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>o : Symbol(o, Decl(privateWriteOnlyAccessorRead.ts, 13, 27))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 13, 32))
|
|
|
|
({ ...this.#value } = { foo }); //ok
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 14, 27))
|
|
|
|
({ foo: this.#value.foo } = { foo }); //error
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 16, 6))
|
|
>this.#value.foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 16, 33))
|
|
|
|
({
|
|
foo: { ...this.#value.foo },
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 17, 6))
|
|
>this.#value.foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 1, 17))
|
|
|
|
} = { foo }); //error
|
|
>foo : Symbol(foo, Decl(privateWriteOnlyAccessorRead.ts, 19, 9))
|
|
|
|
let r = { o: this.#value }; //error
|
|
>r : Symbol(r, Decl(privateWriteOnlyAccessorRead.ts, 21, 7))
|
|
>o : Symbol(o, Decl(privateWriteOnlyAccessorRead.ts, 21, 13))
|
|
>this.#value : Symbol(Test.#value, Decl(privateWriteOnlyAccessorRead.ts, 0, 12))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
|
|
[this.#valueOne, ...this.#valueRest] = [1, 2, 3];
|
|
>this.#valueOne : Symbol(Test.#valueOne, Decl(privateWriteOnlyAccessorRead.ts, 2, 32))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>this.#valueRest : Symbol(Test.#valueRest, Decl(privateWriteOnlyAccessorRead.ts, 1, 44))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
|
|
let arr = [
|
|
>arr : Symbol(arr, Decl(privateWriteOnlyAccessorRead.ts, 24, 7))
|
|
|
|
this.#valueOne,
|
|
>this.#valueOne : Symbol(Test.#valueOne, Decl(privateWriteOnlyAccessorRead.ts, 2, 32))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
|
|
...this.#valueRest
|
|
>this.#valueRest : Symbol(Test.#valueRest, Decl(privateWriteOnlyAccessorRead.ts, 1, 44))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
|
|
];
|
|
|
|
this.#valueCompound += 3;
|
|
>this.#valueCompound : Symbol(Test.#valueCompound, Decl(privateWriteOnlyAccessorRead.ts, 3, 29))
|
|
>this : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
}
|
|
}
|
|
new Test().m();
|
|
>new Test().m : Symbol(Test.m, Decl(privateWriteOnlyAccessorRead.ts, 4, 34))
|
|
>Test : Symbol(Test, Decl(privateWriteOnlyAccessorRead.ts, 0, 0))
|
|
>m : Symbol(Test.m, Decl(privateWriteOnlyAccessorRead.ts, 4, 34))
|
|
|