* Make isDefinition aware of target symbol Initial code, haven't fixed any tests yet. * Update baselines This commit includes a regression for commonjs aliases: ```js // @filename: a.js function f() { } module.exports.f = f // @filename: b.js const { f } = require('./a') f/**/ ``` Now says that `f` in b.js has 1 reference -- the alias `module.exports.f = f`. This is not correct (or not exactly correct), but correctly fixing will involve re-creating the ad-hoc commonjs alias resolution code from the checker. I don't think it's worth it for an edge case like this. * update more unit tests * Fix symbol lookup for constructors * More baselines + two fixes 1. Fix `default` support. 2. Add a secondary declaration location for commonjs assignment declarations. * Update rest of baselines * Switch a few more tests over to baselines
199 lines
4 KiB
Plaintext
199 lines
4 KiB
Plaintext
// === /tests/cases/fourslash/foo.js ===
|
|
// var x = { "/*FIND ALL REFS*/[|someProperty|]": 0 }
|
|
// x["[|someProperty|]"] = 3;
|
|
// x.[|someProperty|] = 5;
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"kind": "property",
|
|
"name": "(property) \"someProperty\": number",
|
|
"textSpan": {
|
|
"start": 11,
|
|
"length": 12
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "\"someProperty\"",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 10,
|
|
"length": 17
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 11,
|
|
"length": 12
|
|
},
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"contextSpan": {
|
|
"start": 10,
|
|
"length": 17
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 33,
|
|
"length": 12
|
|
},
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"contextSpan": {
|
|
"start": 30,
|
|
"length": 22
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 55,
|
|
"length": 12
|
|
},
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"contextSpan": {
|
|
"start": 53,
|
|
"length": 19
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
|
|
// === /tests/cases/fourslash/foo.js ===
|
|
// var x = { "[|someProperty|]": 0 }
|
|
// x["/*FIND ALL REFS*/[|someProperty|]"] = 3;
|
|
// x.[|someProperty|] = 5;
|
|
|
|
[
|
|
{
|
|
"definition": {
|
|
"containerKind": "",
|
|
"containerName": "",
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"kind": "property",
|
|
"name": "(property) \"someProperty\": number",
|
|
"textSpan": {
|
|
"start": 11,
|
|
"length": 12
|
|
},
|
|
"displayParts": [
|
|
{
|
|
"text": "(",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": "property",
|
|
"kind": "text"
|
|
},
|
|
{
|
|
"text": ")",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "\"someProperty\"",
|
|
"kind": "propertyName"
|
|
},
|
|
{
|
|
"text": ":",
|
|
"kind": "punctuation"
|
|
},
|
|
{
|
|
"text": " ",
|
|
"kind": "space"
|
|
},
|
|
{
|
|
"text": "number",
|
|
"kind": "keyword"
|
|
}
|
|
],
|
|
"contextSpan": {
|
|
"start": 10,
|
|
"length": 17
|
|
}
|
|
},
|
|
"references": [
|
|
{
|
|
"textSpan": {
|
|
"start": 11,
|
|
"length": 12
|
|
},
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"contextSpan": {
|
|
"start": 10,
|
|
"length": 17
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": true
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 33,
|
|
"length": 12
|
|
},
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"contextSpan": {
|
|
"start": 30,
|
|
"length": 22
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
},
|
|
{
|
|
"textSpan": {
|
|
"start": 55,
|
|
"length": 12
|
|
},
|
|
"fileName": "/tests/cases/fourslash/foo.js",
|
|
"contextSpan": {
|
|
"start": 53,
|
|
"length": 19
|
|
},
|
|
"isWriteAccess": true,
|
|
"isDefinition": false
|
|
}
|
|
]
|
|
}
|
|
] |