be2db9db12
* Restore original code from bind-toplevel-this With one or two additional comments * Working in JS, but the symbol is not right. Still need to 1. Make it work in Typescript. 2. Add test (and make them work) for the other uses of GlobalThis: window, globalThis, etc. * Check in TS also; update some tests Lots of tests still fail, but all but 1 change so far has been correct. * Update baselines A couple of tests still fail and need to be fixed. * Handle type references to globalThis The type reference must be `typeof globalThis`. Just `globalThis` will be treated as a value reference in type position -- an error. * Restore former behaviour of implicitThis errors I left the noImplicitThis rule for captured use of global this in an arrow function, even though technically it isn't `any` any more -- it's typeof globalThis. However, you should still use some other method to access globals inside an arrow, because captured-global-this is super confusing there. * Test values with type globalThis I ran into a problem with intersecting `Window & typeof globalThis`: 1. This adds a new index signature to Window, which is probably not desired. In fact, with noImplicitAny, it's not desired on globalThis either I think. 2. Adding this type requires editing TSJS-lib-generator, not this repo. So I added the test cases and will probably update them later, when those two problems are fixed. * Add esnext declaration for globalThis * Switch to symbol-based approach I decided I didn't like the import-type-based approach. Update baselines to reflect the difference. * Do not suggest globals for completions at toplevel * Add tests of element and property access * Look up globalThis using normal resolution globalThis is no longer constructed lazily. Its synthetic Identifier node is also now more realistic. * Update fourslash tests * Add missed fourslash test update * Remove esnext.globalthis.d.ts too * Add chained globalThis self-lookup test * Attempt at making globalThis readonly In progress, had to interrupt for other work. * Add/update tests * Addres PR comments: 1. Add parameter to tryGetThisTypeAt to exclude globalThis. 2. Use combined Module flag instead combining them in-place. 3. SymbolDisplay doesn't print 'module globalThis' for this expressions anymore.
12 lines
129 B
TypeScript
12 lines
129 B
TypeScript
// @out: output.js
|
|
// @allowJs: true
|
|
// @checkJs: true
|
|
// @Filename: a.js
|
|
this.a = 10;
|
|
this.a;
|
|
a;
|
|
|
|
// @Filename: b.js
|
|
this.a;
|
|
a;
|