* Disallow property/accessor overrides Unless the base property or accessor is abstract * Disallow uninitialised property overrides This causes quite a few test breaks. We'll probably want to revert many of them by switching to the upcoming `declare x: number` syntax. * Updates from design review + fix ancient bug 1. Don't error when overriding properties from interfaces. 2. Fix error when overriding methods with other things. This had no tests so I assume that the code was always dead and never worked. * Need to add a couple of errors and squash one Will update after checking out other branch for a minute * Everything works so far Need to test properties initialised in constructor * Check for constructor initialisation * change error wording * Improve error wording * Add codefix to add missing 'declare' * Always emit accessors in .d.ts files * Allow 'declare' on any uninitialised property decl * Undo code moves * Let sleeping dogs lie * Correctly set NodeFlags.Ambient And simplify redundant parts of check. * Remove more unneeded code * Update baselines * Update baselines * Update baselines * Ignore this-property assignments * Fix base-in-interface check * Do not error when base parent is interface * Fix base interface check * Add missed baselines * Fix check * Fix new errors in services * Fix new errors in services * Fix errors in testRunner * Add flag and turn off errors when on * Structure of new emit is correct, fake content It is 'hi'. * Basically right emit * Fix one last unitialised property declaration * Haha no I missed another one * Fix whitespace back to CRLF * Minor fix and code cleanup * New test case * Fix bug in isInitializedProperty * Updates from design meeting. 1. Change flag name to useDefineForClassFields (and flip polarity). 2. Forbid ES3 + useDefineForClassFields (since there is no defineProperty). 3. Forbid overriding an abstract property-with-initializer with an accessor. * Update baselines * Object.defineProperty for methods too Using code from Ron from his upcoming refactor of the factory functions. * Update slow baselines * Improve error message * Update src/compiler/transformers/utilities.ts Co-Authored-By: Andrew Branch <andrewbranch@users.noreply.github.com> * Add test of computed properties * Remove done TODO
37 lines
689 B
TypeScript
37 lines
689 B
TypeScript
//// [properties.ts]
|
|
class MyClass
|
|
{
|
|
public get Count(): number
|
|
{
|
|
return 42;
|
|
}
|
|
|
|
public set Count(value: number)
|
|
{
|
|
//
|
|
}
|
|
}
|
|
|
|
//// [properties.js]
|
|
var MyClass = /** @class */ (function () {
|
|
function MyClass() {
|
|
}
|
|
Object.defineProperty(MyClass.prototype, "Count", {
|
|
get: function () {
|
|
return 42;
|
|
},
|
|
set: function (value) {
|
|
//
|
|
},
|
|
enumerable: true,
|
|
configurable: true
|
|
});
|
|
return MyClass;
|
|
}());
|
|
//# sourceMappingURL=properties.js.map
|
|
|
|
//// [properties.d.ts]
|
|
declare class MyClass {
|
|
get Count(): number;
|
|
set Count(value: number);
|
|
}
|