2016-03-19 20:58:06 +01:00
#!/usr/bin/env python3
2020-04-16 19:14:08 +02:00
# Copyright (c) 2015-2020 The Bitcoin Core developers
2016-03-19 20:58:06 +01:00
# Distributed under the MIT software license, see the accompanying
2015-04-28 18:41:54 +02:00
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
2017-01-18 00:34:40 +01:00
""" Test BIP66 (DER SIG).
2017-06-28 22:56:37 +02:00
Test that the DERSIG soft - fork activates at ( regtest ) height 1251.
2017-01-18 00:34:40 +01:00
"""
2015-04-28 18:41:54 +02:00
2018-07-30 10:16:40 +02:00
from test_framework . blocktools import create_coinbase , create_block , create_transaction
2018-07-07 00:10:35 +02:00
from test_framework . messages import msg_block
2020-07-19 09:47:05 +02:00
from test_framework . p2p import P2PInterface
2015-05-02 12:53:35 +02:00
from test_framework . script import CScript
2018-07-07 00:10:35 +02:00
from test_framework . test_framework import BitcoinTestFramework
2018-08-24 21:26:42 +02:00
from test_framework . util import (
assert_equal ,
)
2015-04-28 18:41:54 +02:00
2017-06-28 22:56:37 +02:00
DERSIG_HEIGHT = 1251
# A canonical signature consists of:
2015-04-28 18:41:54 +02:00
# <30> <total len> <02> <len R> <R> <02> <len S> <S> <hashtype>
def unDERify ( tx ) :
2017-01-18 00:34:40 +01:00
"""
2015-04-28 18:41:54 +02:00
Make the signature in vin 0 of a tx non - DER - compliant ,
by adding padding after the S - value .
2017-01-18 00:34:40 +01:00
"""
2015-04-28 18:41:54 +02:00
scriptSig = CScript ( tx . vin [ 0 ] . scriptSig )
newscript = [ ]
for i in scriptSig :
if ( len ( newscript ) == 0 ) :
2016-04-10 16:54:28 +02:00
newscript . append ( i [ 0 : - 1 ] + b ' \0 ' + i [ - 1 : ] )
2015-04-28 18:41:54 +02:00
else :
newscript . append ( i )
tx . vin [ 0 ] . scriptSig = CScript ( newscript )
2017-06-28 22:56:37 +02:00
class BIP66Test ( BitcoinTestFramework ) :
2017-06-10 00:21:21 +02:00
def set_test_params ( self ) :
2015-04-28 18:41:54 +02:00
self . num_nodes = 1
2020-02-25 17:38:56 +01:00
self . extra_args = [ [
' -whitelist=noban@127.0.0.1 ' ,
' -par=1 ' , # Use only one script thread to get the exact log msg for testing
] ]
2017-06-28 22:56:37 +02:00
self . setup_clean_chain = True
2020-03-13 16:10:36 +01:00
self . rpc_timeout = 240
2015-04-28 18:41:54 +02:00
2018-09-09 19:32:37 +02:00
def skip_test_if_missing_module ( self ) :
self . skip_if_no_wallet ( )
2019-07-02 20:23:04 +02:00
def test_dersig_info ( self , * , is_active ) :
2019-05-20 20:58:09 +02:00
assert_equal ( self . nodes [ 0 ] . getblockchaininfo ( ) [ ' softforks ' ] [ ' bip66 ' ] ,
2019-07-02 20:23:04 +02:00
{
2019-05-20 20:58:09 +02:00
" active " : is_active ,
" height " : DERSIG_HEIGHT ,
" type " : " buried " ,
2019-07-02 20:23:04 +02:00
} ,
)
2015-04-28 18:41:54 +02:00
def run_test ( self ) :
2017-10-17 22:16:39 +02:00
self . nodes [ 0 ] . add_p2p_connection ( P2PInterface ( ) )
2017-08-24 21:36:02 +02:00
2019-07-02 20:23:04 +02:00
self . test_dersig_info ( is_active = False )
2017-06-28 22:56:37 +02:00
self . log . info ( " Mining %d blocks " , DERSIG_HEIGHT - 2 )
2018-07-30 10:16:40 +02:00
self . coinbase_txids = [ self . nodes [ 0 ] . getblock ( b ) [ ' tx ' ] [ 0 ] for b in self . nodes [ 0 ] . generate ( DERSIG_HEIGHT - 2 ) ]
2015-04-28 18:41:54 +02:00
self . nodeaddress = self . nodes [ 0 ] . getnewaddress ( )
2017-06-28 22:56:37 +02:00
self . log . info ( " Test that a transaction with non-DER signature can still appear in a block " )
2018-07-30 10:16:40 +02:00
spendtx = create_transaction ( self . nodes [ 0 ] , self . coinbase_txids [ 0 ] ,
2018-08-09 19:27:45 +02:00
self . nodeaddress , amount = 1.0 )
2015-04-28 18:41:54 +02:00
unDERify ( spendtx )
spendtx . rehash ( )
2017-06-28 22:56:37 +02:00
tip = self . nodes [ 0 ] . getbestblockhash ( )
block_time = self . nodes [ 0 ] . getblockheader ( tip ) [ ' mediantime ' ] + 1
block = create_block ( int ( tip , 16 ) , create_coinbase ( DERSIG_HEIGHT - 1 ) , block_time )
block . nVersion = 2
2015-04-28 18:41:54 +02:00
block . vtx . append ( spendtx )
block . hashMerkleRoot = block . calc_merkle_root ( )
block . rehash ( )
block . solve ( )
2019-05-20 20:58:09 +02:00
self . test_dersig_info ( is_active = False ) # Not active as of current tip and next block does not need to obey rules
2017-08-24 21:36:02 +02:00
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
2019-05-20 20:58:09 +02:00
self . test_dersig_info ( is_active = True ) # Not active as of current tip, but next block must obey rules
2017-06-28 22:56:37 +02:00
assert_equal ( self . nodes [ 0 ] . getbestblockhash ( ) , block . hash )
self . log . info ( " Test that blocks must now be at least version 3 " )
tip = block . sha256
block_time + = 1
block = create_block ( tip , create_coinbase ( DERSIG_HEIGHT ) , block_time )
2015-04-28 18:41:54 +02:00
block . nVersion = 2
block . rehash ( )
block . solve ( )
2018-08-24 21:26:42 +02:00
with self . nodes [ 0 ] . assert_debug_log ( expected_msgs = [ ' {} , bad-version(0x00000002) ' . format ( block . hash ) ] ) :
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
assert_equal ( int ( self . nodes [ 0 ] . getbestblockhash ( ) , 16 ) , tip )
self . nodes [ 0 ] . p2p . sync_with_ping ( )
2017-06-28 22:56:37 +02:00
self . log . info ( " Test that transactions with non-DER signatures cannot appear in a block " )
2015-04-28 18:41:54 +02:00
block . nVersion = 3
2017-06-28 22:56:37 +02:00
2018-07-30 10:16:40 +02:00
spendtx = create_transaction ( self . nodes [ 0 ] , self . coinbase_txids [ 1 ] ,
2018-08-09 19:27:45 +02:00
self . nodeaddress , amount = 1.0 )
2016-07-22 01:27:55 +02:00
unDERify ( spendtx )
spendtx . rehash ( )
2017-06-28 22:56:37 +02:00
# First we show that this tx is valid except for DERSIG by getting it
2018-06-23 22:16:54 +02:00
# rejected from the mempool for exactly that reason.
assert_equal (
2019-10-10 17:19:42 +02:00
[ { ' txid ' : spendtx . hash , ' allowed ' : False , ' reject-reason ' : ' non-mandatory-script-verify-flag (Non-canonical DER signature) ' } ] ,
2019-02-14 09:07:29 +01:00
self . nodes [ 0 ] . testmempoolaccept ( rawtxs = [ spendtx . serialize ( ) . hex ( ) ] , maxfeerate = 0 )
2018-06-23 22:16:54 +02:00
)
2017-06-28 22:56:37 +02:00
2018-06-23 22:16:54 +02:00
# Now we verify that a block with this transaction is also invalid.
2016-07-22 01:27:55 +02:00
block . vtx . append ( spendtx )
block . hashMerkleRoot = block . calc_merkle_root ( )
block . rehash ( )
block . solve ( )
2019-08-19 17:55:38 +02:00
with self . nodes [ 0 ] . assert_debug_log ( expected_msgs = [ ' CheckInputScripts on {} failed with non-mandatory-script-verify-flag (Non-canonical DER signature) ' . format ( block . vtx [ - 1 ] . hash ) ] ) :
2018-08-24 21:26:42 +02:00
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
assert_equal ( int ( self . nodes [ 0 ] . getbestblockhash ( ) , 16 ) , tip )
self . nodes [ 0 ] . p2p . sync_with_ping ( )
2017-06-28 22:56:37 +02:00
self . log . info ( " Test that a version 3 block with a DERSIG-compliant transaction is accepted " )
2018-08-09 19:27:45 +02:00
block . vtx [ 1 ] = create_transaction ( self . nodes [ 0 ] , self . coinbase_txids [ 1 ] , self . nodeaddress , amount = 1.0 )
2017-06-28 22:56:37 +02:00
block . hashMerkleRoot = block . calc_merkle_root ( )
2015-04-28 18:41:54 +02:00
block . rehash ( )
block . solve ( )
2017-06-28 22:56:37 +02:00
2019-05-20 20:58:09 +02:00
self . test_dersig_info ( is_active = True ) # Not active as of current tip, but next block must obey rules
2017-08-24 21:36:02 +02:00
self . nodes [ 0 ] . p2p . send_and_ping ( msg_block ( block ) )
2019-07-02 20:23:04 +02:00
self . test_dersig_info ( is_active = True ) # Active as of current tip
2017-06-28 22:56:37 +02:00
assert_equal ( int ( self . nodes [ 0 ] . getbestblockhash ( ) , 16 ) , block . sha256 )
2015-04-28 18:41:54 +02:00
2019-07-02 20:23:04 +02:00
2015-04-28 18:41:54 +02:00
if __name__ == ' __main__ ' :
BIP66Test ( ) . main ( )