Merge pull request #2238 from rnicoll/1.21-dont-send-alert

Don't send a Bitcoin alert to Dogecoin clients
This commit is contained in:
Patrick Lodder 2021-06-03 18:18:56 +02:00 committed by GitHub
commit 314ae07dcd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -2469,12 +2469,11 @@ void PeerManager::ProcessMessage(CNode& pfrom, const std::string& msg_type, CDat
AddTimeData(pfrom.addr, nTimeOffset);
// If the peer is old enough to have the old alert system, send it the final alert.
// TODO: Decide if we need to reintroduce alerts to Dogecoin
// https://github.com/dogecoin/dogecoin/issues/2231
if (greatest_common_version <= 70012) {
// Dogecoin: Do not send a Bitcoin alert to Dogecoin clients.
/* if (greatest_common_version <= 70012) {
CDataStream finalAlert(ParseHex("60010000000000000000000000ffffff7f00000000ffffff7ffeffff7f01ffffff7f00000000ffffff7f00ffffff7f002f555247454e543a20416c657274206b657920636f6d70726f6d697365642c2075706772616465207265717569726564004630440220653febd6410f470f6bae11cad19c48413becb1ac2c17f908fd0fd53bdc3abd5202206d0e9c96fe88d4a0f01ed9dedae2b6f9e00da94cad0fecaae66ecf689bf71b50"), SER_NETWORK, PROTOCOL_VERSION);
m_connman.PushMessage(&pfrom, CNetMsgMaker(greatest_common_version).Make("alert", finalAlert));
}
} */
// Feeler connections exist only to verify if address is online.
if (pfrom.IsFeelerConn()) {