From 3aa0130b963087025b64108225bbadea36d8c6df Mon Sep 17 00:00:00 2001 From: "Wladimir J. van der Laan" Date: Mon, 9 Mar 2015 16:09:54 +0100 Subject: [PATCH] test: remove fSkipProofOfWork Not used, and REGTEST already allows creating blocks at the lowerst possible difficulty. --- src/chainparams.cpp | 1 - src/chainparams.h | 3 --- src/main.cpp | 3 +-- src/pow.cpp | 3 --- 4 files changed, 1 insertion(+), 9 deletions(-) diff --git a/src/chainparams.cpp b/src/chainparams.cpp index c48ccbc08..2bc897651 100644 --- a/src/chainparams.cpp +++ b/src/chainparams.cpp @@ -170,7 +170,6 @@ public: fAllowMinDifficultyBlocks = false; fRequireStandard = true; fMineBlocksOnDemand = false; - fSkipProofOfWorkCheck = false; fTestnetToBeDeprecatedFieldRPC = false; } diff --git a/src/chainparams.h b/src/chainparams.h index 48b1383a6..134dcd655 100644 --- a/src/chainparams.h +++ b/src/chainparams.h @@ -60,8 +60,6 @@ public: bool DefaultCheckMemPool() const { return fDefaultCheckMemPool; } /** Allow mining of a min-difficulty block */ bool AllowMinDifficultyBlocks() const { return fAllowMinDifficultyBlocks; } - /** Skip proof-of-work check: allow mining of any difficulty block */ - bool SkipProofOfWorkCheck() const { return fSkipProofOfWorkCheck; } /** Make standard checks */ bool RequireStandard() const { return fRequireStandard; } int64_t TargetTimespan() const { return nTargetTimespan; } @@ -104,7 +102,6 @@ protected: bool fAllowMinDifficultyBlocks; bool fRequireStandard; bool fMineBlocksOnDemand; - bool fSkipProofOfWorkCheck; bool fTestnetToBeDeprecatedFieldRPC; }; diff --git a/src/main.cpp b/src/main.cpp index 0b36b5f21..f47155ca9 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -2593,8 +2593,7 @@ bool ContextualCheckBlockHeader(const CBlockHeader& block, CValidationState& sta int nHeight = pindexPrev->nHeight+1; // Check proof of work - if ((!Params().SkipProofOfWorkCheck()) && - (block.nBits != GetNextWorkRequired(pindexPrev, &block))) + if ((block.nBits != GetNextWorkRequired(pindexPrev, &block))) return state.DoS(100, error("%s: incorrect proof of work", __func__), REJECT_INVALID, "bad-diffbits"); diff --git a/src/pow.cpp b/src/pow.cpp index b75b293c9..eb899ffc9 100644 --- a/src/pow.cpp +++ b/src/pow.cpp @@ -87,9 +87,6 @@ bool CheckProofOfWork(uint256 hash, unsigned int nBits) bool fOverflow; arith_uint256 bnTarget; - if (Params().SkipProofOfWorkCheck()) - return true; - bnTarget.SetCompact(nBits, &fNegative, &fOverflow); // Check range