maxmustermann/dogecoin
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

wallet: error if an explicit fee rate was given but the needed fee rate differed

Browse source 
This avoids cases where a user requests a fee rate below the minimum and is silently overruled by the wallet.
This commit is contained in:
Karl-Johan Alm 2020-03-03 14:09:02 +09:00
parent ec79b5f86b
commit 44cc75f80e
No known key found for this signature in database
GPG key ID: 57AF762DB3353322
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/wallet/wallet.cpp
View file

@ -2729,6 +2729,12 @@ bool CWallet::CreateTransaction(const std::vector<CRecipient>& vecSend, CTransac
// Get the fee rate to use effective values in coin selection
CFeeRate nFeeRateNeeded = GetMinimumFeeRate(*this, coin_control, &feeCalc);
// Do not, ever, assume that it's fine to change the fee rate if the user has explicitly
// provided one
if (coin_control.m_feerate && nFeeRateNeeded > *coin_control.m_feerate) {
error = strprintf(_("Fee rate (%s) is lower than the minimum fee rate setting (%s)"), coin_control.m_feerate->ToString(), nFeeRateNeeded.ToString());
return false;
}
nFeeRet = 0;
bool pick_new_inputs = true;