From 5555d978b056ab0e0e59faaf2d2067ec43fffaef Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Tue, 26 May 2020 20:06:07 -0400 Subject: [PATCH 1/3] wallet: Make PeriodicFlush uninterruptible --- src/wallet/db.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/wallet/db.cpp b/src/wallet/db.cpp index 1b2bd83a4..95a5b91ce 100644 --- a/src/wallet/db.cpp +++ b/src/wallet/db.cpp @@ -14,8 +14,6 @@ #include #endif -#include - namespace { //! Make sure database has a unique fileid within the environment. If it @@ -824,7 +822,6 @@ bool BerkeleyBatch::PeriodicFlush(BerkeleyDatabase& database) if (nRefCount == 0) { - boost::this_thread::interruption_point(); std::map::iterator mi = env->mapFileUseCount.find(strFile); if (mi != env->mapFileUseCount.end()) { From fa7b885f51ff848d3f913bc6e15d24528300c210 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Fri, 24 Apr 2020 11:23:40 -0400 Subject: [PATCH 2/3] walletdb: Remove unsed boost/thread --- src/wallet/walletdb.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/wallet/walletdb.cpp b/src/wallet/walletdb.cpp index 331408ef4..cb2004bc3 100644 --- a/src/wallet/walletdb.cpp +++ b/src/wallet/walletdb.cpp @@ -18,8 +18,6 @@ #include #include -#include - namespace DBKeys { const std::string ACENTRY{"acentry"}; const std::string ACTIVEEXTERNALSPK{"activeexternalspk"}; @@ -738,11 +736,7 @@ DBErrors WalletBatch::LoadWallet(CWallet* pwallet) pwallet->WalletLogPrintf("%s\n", strErr); } pcursor->close(); - } - catch (const boost::thread_interrupted&) { - throw; - } - catch (...) { + } catch (...) { result = DBErrors::CORRUPT; } From fa1c74fd0342b74d44cc4e41fff3890c1434e8f7 Mon Sep 17 00:00:00 2001 From: MarcoFalke Date: Tue, 2 Jun 2020 07:14:04 -0400 Subject: [PATCH 3/3] wallet: Remove unused boost::thread_interrupted FindWalletTx is only called by zapwallet, which is never called in a boost::thread --- src/wallet/walletdb.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/wallet/walletdb.cpp b/src/wallet/walletdb.cpp index cb2004bc3..0a886c231 100644 --- a/src/wallet/walletdb.cpp +++ b/src/wallet/walletdb.cpp @@ -874,11 +874,7 @@ DBErrors WalletBatch::FindWalletTx(std::vector& vTxHash, std::listclose(); - } - catch (const boost::thread_interrupted&) { - throw; - } - catch (...) { + } catch (...) { result = DBErrors::CORRUPT; }