From 5983a4e50f2c3f53024d9a5cecab69f67c882cca Mon Sep 17 00:00:00 2001 From: Mike Hearn Date: Tue, 10 Mar 2015 11:33:46 -0700 Subject: [PATCH] Add a NODE_GETUTXO service bit and document NODE_NETWORK. Stop translating the NODE_* names as they are technical and cannot be translated. --- src/protocol.h | 7 +++++++ src/qt/guiutil.cpp | 7 +++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/protocol.h b/src/protocol.h index e838c0d36..fd23eae1f 100644 --- a/src/protocol.h +++ b/src/protocol.h @@ -67,7 +67,14 @@ public: /** nServices flags */ enum { + // NODE_NETWORK means that the node is capable of serving the block chain. It is currently + // set by all Bitcoin Core nodes, and is unset by SPV clients or other peers that just want + // network services but don't provide them. NODE_NETWORK = (1 << 0), + // NODE_GETUTXO means the node is capable of responding to the getutxo protocol request. + // Bitcoin Core does not support this but a patch set called Bitcoin XT does. + // See BIP 64 for details on how this is implemented. + NODE_GETUTXO = (1 << 1), // Bits 24-31 are reserved for temporary experiments. Just pick a bit that // isn't getting used, or one not being used much, and notify the diff --git a/src/qt/guiutil.cpp b/src/qt/guiutil.cpp index 9db0a7597..a5ee81db6 100644 --- a/src/qt/guiutil.cpp +++ b/src/qt/guiutil.cpp @@ -878,10 +878,13 @@ QString formatServicesStr(quint64 mask) switch (check) { case NODE_NETWORK: - strList.append(QObject::tr("NETWORK")); + strList.append("NETWORK"); + break; + case NODE_GETUTXO: + strList.append("GETUTXO"); break; default: - strList.append(QString("%1[%2]").arg(QObject::tr("UNKNOWN")).arg(check)); + strList.append(QString("%1[%2]").arg("UNKNOWN").arg(check)); } } }