Merge #19605: doc: set CC_FOR_BUILD when building on OpenBSD

01cd24c226 doc: set CC_FOR_BUILD when building on OpenBSD (fanquake)

Pull request description:

  Closes: #19559

  While #19559 has been fixed upstream, it makes sense to not only
  recommend using `CC_FOR_BUILD`here  until the fix is pulled in as
  part of our next libsecp update, but after discussing with Cory,
  he suggested we should be setting this on OpenBSD (which still has
  the an ancient GCC) regardless.

ACKs for top commit:
  real-or-random:
    ACK 01cd24c226 I looked at the diff (but can't test the instructions on OpenBSD)
  laanwj:
    Code review ACK 01cd24c226

Tree-SHA512: 322802b9303771f1be2ad9628f268dfa71dc7ee77948fa2a34f21eceb19b2d8efdd8876c8f0778adbfcde48fa0f88cd4e698ae425428159abca38e8c7980da1d
This commit is contained in:
fanquake 2020-08-10 22:20:22 +08:00
commit 6d5a9fec2d
No known key found for this signature in database
GPG key ID: 2EEB9F5CC09526C1

View file

@ -1,6 +1,6 @@
OpenBSD build guide OpenBSD build guide
====================== ======================
(updated for OpenBSD 6.4) (updated for OpenBSD 6.7)
This guide describes how to build bitcoind and command-line utilities on OpenBSD. This guide describes how to build bitcoind and command-line utilities on OpenBSD.
@ -15,7 +15,7 @@ Run the following as root to install the base dependencies for building:
pkg_add git gmake libevent libtool boost pkg_add git gmake libevent libtool boost
pkg_add autoconf # (select highest version, e.g. 2.69) pkg_add autoconf # (select highest version, e.g. 2.69)
pkg_add automake # (select highest version, e.g. 1.16) pkg_add automake # (select highest version, e.g. 1.16)
pkg_add python # (select highest version, e.g. 3.6) pkg_add python # (select highest version, e.g. 3.8)
git clone https://github.com/bitcoin/bitcoin.git git clone https://github.com/bitcoin/bitcoin.git
``` ```
@ -23,10 +23,10 @@ git clone https://github.com/bitcoin/bitcoin.git
See [dependencies.md](dependencies.md) for a complete overview. See [dependencies.md](dependencies.md) for a complete overview.
**Important**: From OpenBSD 6.2 onwards a C++11-supporting clang compiler is **Important**: From OpenBSD 6.2 onwards a C++11-supporting clang compiler is
part of the base image, and while building it is necessary to make sure that this part of the base image, and while building it is necessary to make sure that
compiler is used and not ancient g++ 4.2.1. This is done by appending this compiler is used and not ancient g++ 4.2.1. This is done by appending
`CC=cc CXX=c++` to configuration commands. Mixing different compilers `CC=cc CC_FOR_BUILD=cc CXX=c++` to configuration commands. Mixing different
within the same executable will result in linker errors. compilers within the same executable will result in errors.
### Building BerkeleyDB ### Building BerkeleyDB
@ -77,7 +77,7 @@ To configure with wallet:
To configure without wallet: To configure without wallet:
```bash ```bash
./configure --disable-wallet --with-gui=no CC=cc CXX=c++ MAKE=gmake ./configure --disable-wallet --with-gui=no CC=cc CC_FOR_BUILD=cc CXX=c++ MAKE=gmake
``` ```
Build and run the tests: Build and run the tests: