maxmustermann/dogecoin
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Check for weak RPC passwords.

Browse source
This commit is contained in:
Joshua Charles Campbell 2014-01-05 13:12:23 -07:00
parent 76a5ddbd06
commit 7de7798ee0
1 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/bitcoinrpc.cpp
View file

@ -729,11 +729,31 @@ static void RPCAcceptHandler(boost::shared_ptr< basic_socket_acceptor<Protocol,
}
}
// Rough check of password strength based on 0-order entropy.
// Should work for both passwords and phrases without any complicated rules.
// -- orezpraw, Jan 5, 2014
static int weakPassword(std::string passwd)
{
char i;
double uniqueChars = 0;
for (i = CHAR_MIN; i < CHAR_MAX; i++) {
if (passwd.find(i) != std::string::npos)
uniqueChars += 1;
}
double bits = (log(uniqueChars)/log(2)) * ((double)passwd.size());
if (bits < 64)
return 1;
else
return 0;
}
void StartRPCThreads()
{
strRPCUserColonPass = mapArgs["-rpcuser"] + ":" + mapArgs["-rpcpassword"];
if ((mapArgs["-rpcpassword"] == "") ||
(mapArgs["-rpcuser"] == mapArgs["-rpcpassword"]))
(mapArgs["-rpcuser"] == mapArgs["-rpcpassword"])
|| weakPassword(mapArgs["-rpcpassword"]))
{
unsigned char rand_pwd[32];
RAND_bytes(rand_pwd, 32);
@ -743,7 +763,7 @@ void StartRPCThreads()
else if (mapArgs.count("-daemon"))
strWhatAmI = strprintf(_("To use the %s option"), "\"-daemon\"");
uiInterface.ThreadSafeMessageBox(strprintf(
_("%s, you must set a rpcpassword in the configuration file:\n"
_("%s, you must set a long rpcpassword in the configuration file:\n"
"%s\n"
"It is recommended you use the following random password:\n"
"rpcuser=dogecoinrpc\n"