Merge #19947: Test: Cover "change_type" option of "walletcreatefundedpsbt" RPC
a56e9f5670
test: Assert exclusive PSBT funding options (Oliver Gugger)64bc5efd39
test: Assert PSBT change type (Oliver Gugger) Pull request description: Increases test coverage of the `walletcreatefundedpsbt` RPC. Tests the following combinations: - Make sure the global option `-changetype` is used as the default value for the `change_type` option if not specified. - Make sure the global option `-changetype` can be overwritten by explicitly setting the `change_type` option of the `walletcreatefundedpsbt` RPC call. - Make sure the options `change_type` and `changeAddress` are mutually exclusive. ACKs for top commit: achow101: ACKa56e9f5670
Tree-SHA512: bf0fb20c890887b7228ad9277fdb32f367ba772eed6efbe2b4f471f808d4d435110256601e8ebd9bea57026d9f22f3cc3c26a009b017e3da6d8fc6896313def5
This commit is contained in:
commit
875e1ccc9f
1 changed files with 24 additions and 1 deletions
|
@ -30,7 +30,7 @@ class PSBTTest(BitcoinTestFramework):
|
|||
self.num_nodes = 3
|
||||
self.extra_args = [
|
||||
["-walletrbf=1"],
|
||||
["-walletrbf=0"],
|
||||
["-walletrbf=0", "-changetype=legacy"],
|
||||
[]
|
||||
]
|
||||
self.supports_cli = False
|
||||
|
@ -83,6 +83,14 @@ class PSBTTest(BitcoinTestFramework):
|
|||
connect_nodes(self.nodes[0], 1)
|
||||
connect_nodes(self.nodes[0], 2)
|
||||
|
||||
def assert_change_type(self, psbtx, expected_type):
|
||||
"""Assert that the given PSBT has a change output with the given type."""
|
||||
|
||||
# The decodepsbt RPC is stateless and independent of any settings, we can always just call it on the first node
|
||||
decoded_psbt = self.nodes[0].decodepsbt(psbtx["psbt"])
|
||||
changepos = psbtx["changepos"]
|
||||
assert_equal(decoded_psbt["tx"]["vout"][changepos]["scriptPubKey"]["type"], expected_type)
|
||||
|
||||
def run_test(self):
|
||||
# Create and fund a raw tx for sending 10 BTC
|
||||
psbtx1 = self.nodes[0].walletcreatefundedpsbt([], {self.nodes[2].getnewaddress():10})['psbt']
|
||||
|
@ -301,6 +309,21 @@ class PSBTTest(BitcoinTestFramework):
|
|||
# when attempting BnB coin selection
|
||||
self.nodes[0].walletcreatefundedpsbt([], [{self.nodes[2].getnewaddress():unspent["amount"]+1}], block_height+2, {"changeAddress":self.nodes[1].getnewaddress()}, False)
|
||||
|
||||
# Make sure the wallet's change type is respected by default
|
||||
small_output = {self.nodes[0].getnewaddress():0.1}
|
||||
psbtx_native = self.nodes[0].walletcreatefundedpsbt([], [small_output])
|
||||
self.assert_change_type(psbtx_native, "witness_v0_keyhash")
|
||||
psbtx_legacy = self.nodes[1].walletcreatefundedpsbt([], [small_output])
|
||||
self.assert_change_type(psbtx_legacy, "pubkeyhash")
|
||||
|
||||
# Make sure the change type of the wallet can also be overwritten
|
||||
psbtx_np2wkh = self.nodes[1].walletcreatefundedpsbt([], [small_output], 0, {"change_type":"p2sh-segwit"})
|
||||
self.assert_change_type(psbtx_np2wkh, "scripthash")
|
||||
|
||||
# Make sure the change type cannot be specified if a change address is given
|
||||
invalid_options = {"change_type":"legacy","changeAddress":self.nodes[0].getnewaddress()}
|
||||
assert_raises_rpc_error(-8, "both change address and address type options", self.nodes[0].walletcreatefundedpsbt, [], [small_output], 0, invalid_options)
|
||||
|
||||
# Regression test for 14473 (mishandling of already-signed witness transaction):
|
||||
psbtx_info = self.nodes[0].walletcreatefundedpsbt([{"txid":unspent["txid"], "vout":unspent["vout"]}], [{self.nodes[2].getnewaddress():unspent["amount"]+1}], 0, {"add_inputs": True})
|
||||
complete_psbt = self.nodes[0].walletprocesspsbt(psbtx_info["psbt"])
|
||||
|
|
Loading…
Reference in a new issue