From 9be7fd35c5d631c2cc34d3b4fa63ae0a9d5a68ef Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Sun, 31 May 2020 14:15:12 +0200 Subject: [PATCH] rpc: make generatetoaddress locals const and named the same as in generatetodescriptor just above. --- src/rpc/mining.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp index 52b5f6485..b6133a111 100644 --- a/src/rpc/mining.cpp +++ b/src/rpc/mining.cpp @@ -257,11 +257,8 @@ static UniValue generatetoaddress(const JSONRPCRequest& request) }, }.Check(request); - int nGenerate = request.params[0].get_int(); - uint64_t nMaxTries{DEFAULT_MAX_TRIES}; - if (!request.params[2].isNull()) { - nMaxTries = request.params[2].get_int(); - } + const int num_blocks{request.params[0].get_int()}; + const uint64_t max_tries{request.params[2].isNull() ? DEFAULT_MAX_TRIES : request.params[2].get_int()}; CTxDestination destination = DecodeDestination(request.params[1].get_str()); if (!IsValidDestination(destination)) { @@ -273,7 +270,7 @@ static UniValue generatetoaddress(const JSONRPCRequest& request) CScript coinbase_script = GetScriptForDestination(destination); - return generateBlocks(chainman, mempool, coinbase_script, nGenerate, nMaxTries); + return generateBlocks(chainman, mempool, coinbase_script, num_blocks, max_tries); } static UniValue generateblock(const JSONRPCRequest& request)