Prevent socket leak in ThreadSocketHandler.
When we are over our outbound limit ThreadSocketHandler would try to keep the connection if the peer was addnoded. This didn't actually work for two reasons: It didn't actually run the accept code due to mistaken code flow, and because we have a limited number of outbound semaphores it couldn't actually use the connection. Instead it leaked the socket, which might have caused issue #4034. This patch just takes out the non-functioning white-listing for now.
This commit is contained in:
parent
f35f493d20
commit
b9ad84bb6c
|
@ -944,11 +944,7 @@ void ThreadSocketHandler()
|
||||||
}
|
}
|
||||||
else if (nInbound >= nMaxConnections - MAX_OUTBOUND_CONNECTIONS)
|
else if (nInbound >= nMaxConnections - MAX_OUTBOUND_CONNECTIONS)
|
||||||
{
|
{
|
||||||
{
|
closesocket(hSocket);
|
||||||
LOCK(cs_setservAddNodeAddresses);
|
|
||||||
if (!setservAddNodeAddresses.count(addr))
|
|
||||||
closesocket(hSocket);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
else if (CNode::IsBanned(addr))
|
else if (CNode::IsBanned(addr))
|
||||||
{
|
{
|
||||||
|
|
Loading…
Reference in a new issue