Merge #10450: Fix bumpfee rpc "errors" return value
1b6602f
Fix bumpfee rpc "errors" return value (Russell Yanofsky)
Tree-SHA512: a55d4dbe28c75f31fde3b7de60479265bb8f3777f432d1db321f1dd848d5274c353f757b09ed3cad9c69c08acbf3906679d27052267db943ab2b19629f79bd81
This commit is contained in:
commit
ef2d062c9f
2 changed files with 2 additions and 1 deletions
|
@ -2909,7 +2909,7 @@ UniValue bumpfee(const JSONRPCRequest& request)
|
||||||
UniValue errors(UniValue::VARR);
|
UniValue errors(UniValue::VARR);
|
||||||
for (const std::string& err: feeBump.getErrors())
|
for (const std::string& err: feeBump.getErrors())
|
||||||
errors.push_back(err);
|
errors.push_back(err);
|
||||||
result.push_back(errors);
|
result.push_back(Pair("errors", errors));
|
||||||
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
|
@ -88,6 +88,7 @@ def test_simple_bumpfee_succeeds(rbf_node, peer_node, dest_address):
|
||||||
sync_mempools((rbf_node, peer_node))
|
sync_mempools((rbf_node, peer_node))
|
||||||
assert rbfid in rbf_node.getrawmempool() and rbfid in peer_node.getrawmempool()
|
assert rbfid in rbf_node.getrawmempool() and rbfid in peer_node.getrawmempool()
|
||||||
bumped_tx = rbf_node.bumpfee(rbfid)
|
bumped_tx = rbf_node.bumpfee(rbfid)
|
||||||
|
assert_equal(bumped_tx["errors"], [])
|
||||||
assert bumped_tx["fee"] - abs(rbftx["fee"]) > 0
|
assert bumped_tx["fee"] - abs(rbftx["fee"]) > 0
|
||||||
# check that bumped_tx propogates, original tx was evicted and has a wallet conflict
|
# check that bumped_tx propogates, original tx was evicted and has a wallet conflict
|
||||||
sync_mempools((rbf_node, peer_node))
|
sync_mempools((rbf_node, peer_node))
|
||||||
|
|
Loading…
Reference in a new issue