564e1ab0f3
fa188c9c59
test: Use MiniWalet in p2p_feefilter (MarcoFalke)fa39c62eb7
test: inline hashToHex (MarcoFalke) Pull request description: This introduces a minimalistic test wallet, which can be used as a drop in replacement for the Bitcoin Core wallet to create dummy transactions with a given fee rate. ACKs for top commit: jnewbery: utACKfa188c9c59
Tree-SHA512: 0aad9cb14eea4f0055bd6a47cc8c8f82a16941b152598c3bf1e083aae84cca4ffa23f0b854a362a68be1b917deba1b5ec7c0207b63b0805d747ba9a7d1d82efe
123 lines
5 KiB
Python
Executable file
123 lines
5 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2016-2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test processing of feefilter messages."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.messages import MSG_TX, MSG_WTX, msg_feefilter
|
|
from test_framework.p2p import P2PInterface, p2p_lock
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
from test_framework.wallet import MiniWallet
|
|
|
|
|
|
class FeefilterConn(P2PInterface):
|
|
feefilter_received = False
|
|
|
|
def on_feefilter(self, message):
|
|
self.feefilter_received = True
|
|
|
|
def assert_feefilter_received(self, recv: bool):
|
|
with p2p_lock:
|
|
assert_equal(self.feefilter_received, recv)
|
|
|
|
|
|
class TestP2PConn(P2PInterface):
|
|
def __init__(self):
|
|
super().__init__()
|
|
self.txinvs = []
|
|
|
|
def on_inv(self, message):
|
|
for i in message.inv:
|
|
if (i.type == MSG_TX) or (i.type == MSG_WTX):
|
|
self.txinvs.append('{:064x}'.format(i.hash))
|
|
|
|
def wait_for_invs_to_match(self, invs_expected):
|
|
invs_expected.sort()
|
|
self.wait_until(lambda: invs_expected == sorted(self.txinvs))
|
|
|
|
def clear_invs(self):
|
|
with p2p_lock:
|
|
self.txinvs = []
|
|
|
|
|
|
class FeeFilterTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
# We lower the various required feerates for this test
|
|
# to catch a corner-case where feefilter used to slightly undercut
|
|
# mempool and wallet feerate calculation based on GetFee
|
|
# rounding down 3 places, leading to stranded transactions.
|
|
# See issue #16499
|
|
# grant noban permission to all peers to speed up tx relay / mempool sync
|
|
self.extra_args = [[
|
|
"-minrelaytxfee=0.00000100",
|
|
"-mintxfee=0.00000100",
|
|
"-whitelist=noban@127.0.0.1",
|
|
]] * self.num_nodes
|
|
|
|
def run_test(self):
|
|
self.test_feefilter_forcerelay()
|
|
self.test_feefilter()
|
|
|
|
def test_feefilter_forcerelay(self):
|
|
self.log.info('Check that peers without forcerelay permission (default) get a feefilter message')
|
|
self.nodes[0].add_p2p_connection(FeefilterConn()).assert_feefilter_received(True)
|
|
|
|
self.log.info('Check that peers with forcerelay permission do not get a feefilter message')
|
|
self.restart_node(0, extra_args=['-whitelist=forcerelay@127.0.0.1'])
|
|
self.nodes[0].add_p2p_connection(FeefilterConn()).assert_feefilter_received(False)
|
|
|
|
# Restart to disconnect peers and load default extra_args
|
|
self.restart_node(0)
|
|
self.connect_nodes(1, 0)
|
|
|
|
def test_feefilter(self):
|
|
node1 = self.nodes[1]
|
|
node0 = self.nodes[0]
|
|
miniwallet = MiniWallet(node1)
|
|
# Add enough mature utxos to the wallet, so that all txs spend confirmed coins
|
|
miniwallet.generate(5)
|
|
node1.generate(100)
|
|
|
|
conn = self.nodes[0].add_p2p_connection(TestP2PConn())
|
|
|
|
self.log.info("Test txs paying 0.2 sat/byte are received by test connection")
|
|
txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00000200'), from_node=node1)['wtxid'] for _ in range(3)]
|
|
conn.wait_for_invs_to_match(txids)
|
|
conn.clear_invs()
|
|
|
|
# Set a fee filter of 0.15 sat/byte on test connection
|
|
conn.send_and_ping(msg_feefilter(150))
|
|
|
|
self.log.info("Test txs paying 0.15 sat/byte are received by test connection")
|
|
txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00000150'), from_node=node1)['wtxid'] for _ in range(3)]
|
|
conn.wait_for_invs_to_match(txids)
|
|
conn.clear_invs()
|
|
|
|
self.log.info("Test txs paying 0.1 sat/byte are no longer received by test connection")
|
|
txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00000100'), from_node=node1)['wtxid'] for _ in range(3)]
|
|
self.sync_mempools() # must be sure node 0 has received all txs
|
|
|
|
# Send one transaction from node0 that should be received, so that we
|
|
# we can sync the test on receipt (if node1's txs were relayed, they'd
|
|
# be received by the time this node0 tx is received). This is
|
|
# unfortunately reliant on the current relay behavior where we batch up
|
|
# to 35 entries in an inv, which means that when this next transaction
|
|
# is eligible for relay, the prior transactions from node1 are eligible
|
|
# as well.
|
|
txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00020000'), from_node=node0)['wtxid'] for _ in range(3)]
|
|
conn.wait_for_invs_to_match(txids)
|
|
conn.clear_invs()
|
|
|
|
self.log.info("Remove fee filter and check txs are received again")
|
|
conn.send_and_ping(msg_feefilter(0))
|
|
txids = [miniwallet.send_self_transfer(fee_rate=Decimal('0.00020000'), from_node=node1)['wtxid'] for _ in range(3)]
|
|
conn.wait_for_invs_to_match(txids)
|
|
conn.clear_invs()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
FeeFilterTest().main()
|