Go to file

MarcoFalke 0b68fca700 Merge #16092 : Don't use global (external) symbols for symbols that are used in only one translation unit `0959d37e3e` Don't use global (external) symbols for symbols that are used in only one translation unit (practicalswift) Pull request description: Don't use global (external) symbols for symbols that are used in only one translation unit. Before: ``` $ for SYMBOL in $(nm src/bitcoind \| grep -E ' [BD] ' \| c++filt \| cut -f3- -d' ' \| grep -v @ \| grep -v : \| sort \| grep '[a-z]' \| sort -u \| grep -vE '(^_\|typeinfo\|vtable)'); do REFERENCES=$(git grep -lE "([^a-zA-Z]\|^)${SYMBOL}([^a-zA-Z]\|\$)" -- ".cpp" ".h") N_REFERENCES=$(wc -l <<< "${REFERENCES}") if [[ ${N_REFERENCES} > 1 ]]; then continue fi echo "Global symbol ${SYMBOL} is used in only one translation unit: ${REFERENCES}" done Global symbol g_chainstate is used in only one translation unit: src/validation.cpp Global symbol g_ui_signals is used in only one translation unit: src/ui_interface.cpp Global symbol instance_of_cmaincleanup is used in only one translation unit: src/validation.cpp Global symbol instance_of_cnetcleanup is used in only one translation unit: src/net.cpp Global symbol instance_of_cnetprocessingcleanup is used in only one translation unit: src/net_processing.cpp Global symbol pindexBestForkBase is used in only one translation unit: src/validation.cpp Global symbol pindexBestForkTip is used in only one translation unit: src/validation.cpp $ ``` After: ``` $ for SYMBOL in $(nm src/bitcoind \| grep -E ' [BD] ' \| c++filt \| cut -f3- -d' ' \| grep -v @ \| grep -v : \| sort \| grep '[a-z]' \| sort -u \| grep -vE '(^_\|typeinfo\|vtable)'); do REFERENCES=$(git grep -lE "([^a-zA-Z]\|^)${SYMBOL}([^a-zA-Z]\|\$)" -- ".cpp" ".h") N_REFERENCES=$(wc -l <<< "${REFERENCES}") if [[ ${N_REFERENCES} > 1 ]]; then continue fi echo "Global symbol ${SYMBOL} is used in only one translation unit: ${REFERENCES}" done $ ``` ♻️ Think about future generations: save the global namespace from unnecessary pollution! ♻️ ACKs for commit 0959d3: Empact: ACK `0959d37e3e` MarcoFalke: ACK `0959d37e3e` hebasto: ACK `0959d37e3e` promag: ACK `0959d37`. Tree-SHA512: 722f66bb50450f19b57e8a8fbe949f30cd651eb8564e5787cbb772a539bf3a288c048dc49e655fd73ece6a46f6dafade515ec4004729bf2b3ab83117b7c5d153		2019-06-18 15:59:53 -04:00
.github	Get more info about GUI-related issue on Linux	2018-12-27 06:53:07 +02:00
.travis	Merge #16186 : doc/lint: Fix spelling errors identified by codespell 1.15.0	2019-06-16 09:57:09 +08:00
.tx	qt: Pre-0.18 split-off translations update	2019-02-04 15:24:37 +01:00
build-aux/m4	[depends] boost: update to 1.70	2019-05-03 13:22:17 +01:00
build_msvc	build: bump bitcoin_config.h packages to v0.18	2019-05-23 18:02:51 +02:00
contrib	Merge #16186 : doc/lint: Fix spelling errors identified by codespell 1.15.0	2019-06-16 09:57:09 +08:00
depends	Merge #15461 : [depends] update to Boost 1.70	2019-06-06 13:42:25 +02:00
doc	Merge #16171 : Remove -mempoolreplacement to prevent needless block prop slowness.	2019-06-18 10:04:14 -04:00
share	Merge #15548 : build: use full version string in setup.exe	2019-03-12 10:43:08 +01:00
src	Merge #16092 : Don't use global (external) symbols for symbols that are used in only one translation unit	2019-06-18 15:59:53 -04:00
test	Merge #16112 : util: Log early messages	2019-06-18 12:32:32 -04:00
.appveyor.yml	appveyor: Write @PACKAGE_NAME@ to config	2019-04-26 13:07:11 -04:00
.cirrus.yml	cirrus ci: Inital config	2019-02-03 10:24:39 -05:00
.gitattributes	Separate protocol versioning from clientversion	2014-10-29 00:24:40 -04:00
.gitignore	.gitignore: Don't ignore depends patches	2019-05-07 21:33:54 -04:00
.python-version	.python-version: Specify full version 3.5.6	2019-03-02 12:06:26 -05:00
.style.yapf	test: .style.yapf: Set column_limit=160	2019-03-04 18:28:13 -05:00
.travis.yml	travis: Use absolute paths for cache dirs	2019-06-14 10:47:48 -04:00
autogen.sh	Add "export LC_ALL=C" to all shell scripts	2018-06-14 15:27:52 +02:00
configure.ac	configure: Add flag for enabling thread_local.	2019-05-23 15:15:46 -04:00
CONTRIBUTING.md	doc: Rework section on ACK	2019-06-13 10:08:25 -04:00
COPYING	[Trivial] Update license year range to 2019	2018-12-31 04:27:59 +01:00
INSTALL.md	Update INSTALL landing redirection notice for build instructions.	2016-10-06 12:27:23 +13:00
libbitcoinconsensus.pc.in	Unify package name to as few places as possible without major changes	2015-12-14 02:11:10 +00:00
Makefile.am	Merge #12051 : add missing debian contrib file to tarball	2019-04-29 08:48:39 -04:00
README.md	docs: Update Transifex links	2019-03-02 17:42:33 +08:00
SECURITY.md	doc: Remove explicit mention of version from SECURITY.md	2019-06-14 06:39:17 -04:00

README.md

Bitcoin Core integration/staging tree

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.