- Get rid of hardcoded wallet "" names and -wallet="" args - Get rid of setup_nodes (-wallet, -nowallet, -disablewallet) argument rewriting Motivation: - Simplify test framework behavior so it's easier to write new tests without having arguments mangled by the framework - Make tests more readable, replacing unexplained "" string literals with default_wallet_name references - Make it trivial to update default wallet name and wallet data filename for sqlite #19077 testing - Stop relying on -wallet arguments to create wallets, so it is easy to change -wallet option in the future to only load existing wallets not create new ones (to avoid accidental wallet creation, and encourage use of wallet encryption and descriptor features)
35 lines
1.5 KiB
Python
Executable file
35 lines
1.5 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test a node with the -disablewallet option.
|
|
|
|
- Test that validateaddress RPC works when running with -disablewallet
|
|
- Test that it is not possible to mine to an invalid address.
|
|
"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_raises_rpc_error
|
|
|
|
class DisableWalletTest (BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-disablewallet"]]
|
|
self.wallet_names = []
|
|
|
|
def run_test (self):
|
|
# Make sure wallet is really disabled
|
|
assert_raises_rpc_error(-32601, 'Method not found', self.nodes[0].getwalletinfo)
|
|
x = self.nodes[0].validateaddress('3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy')
|
|
assert x['isvalid'] == False
|
|
x = self.nodes[0].validateaddress('mneYUmWYsuk7kySiURxCi3AGxrAqZxLgPZ')
|
|
assert x['isvalid'] == True
|
|
|
|
# Checking mining to an address without a wallet. Generating to a valid address should succeed
|
|
# but generating to an invalid address will fail.
|
|
self.nodes[0].generatetoaddress(1, 'mneYUmWYsuk7kySiURxCi3AGxrAqZxLgPZ')
|
|
assert_raises_rpc_error(-5, "Invalid address", self.nodes[0].generatetoaddress, 1, '3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy')
|
|
|
|
if __name__ == '__main__':
|
|
DisableWalletTest ().main ()
|