maxmustermann/dogecoin
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
15280 commits 12 branches 161 tags 1.2 GiB
C++ 65.7%
Python 15%
C 12.5%
M4 2.7%
Makefile 1.5%
Other 2.5%
Go to file
MarcoFalke 57ee73990f
Merge #11538: qa: Fix race condition failures in replace-by-fee.py, sendheaders.py 
6d51eaefe qa: Fix race condition in sendheaders.py (Suhas Daftuar)
c96b2e4f0 qa: Fix replace-by-fee race condition failures (Suhas Daftuar)

Pull request description:

  I think #11407 broke replace-by-fee by introducing a race condition.  I was observing frequent failures of replace-by-fee locally, always with a mempool sync failure (the sync call was added in #11407).

  It appeared to me like there were two causes: sometimes the node would be in IBD and not request the transaction that was relayed; other times the blocks generated in make_utxo wouldn't have relayed quickly enough for the spend of the transaction to be accepted.  I believe I've fixed both potential errors.

  ping @instagibbs

  Edit: I found a race condition in the sendheaders.py test, where if the verack from the python node wasn't processed before the first block in the test was generated, then no block announcement would go out to that peer, breaking the test.  Fixed by adding a sync_with_ping after waiting for verack.

Tree-SHA512: 6ad160966e432c151c1ce6e88ae67e60e47123523bda3755cf7697a00e1a5ba38de8561751826e3d7cf0e492f8c2aec298e1b4de8424ebbaf497f099a1ef1d07
2017-10-23 17:19:26 +02:00
.github Mention reporting security issues responsibly 2016-11-10 14:41:40 +01:00
.tx qt: Set transifex slug to 0.14 2017-01-02 09:36:03 +01:00
build-aux/m4 Explicitly search for bdb5.3. 2017-07-02 02:48:00 +00:00
contrib [verify-commits] Allow revoked keys to expire 2017-10-20 16:35:16 -04:00
depends [depends] native_ds_store 1.1.2 2017-10-07 14:50:25 +08:00
doc Merge #11437: [Docs] Update Windows build instructions for using WSL and Ubuntu 17.04 2017-10-05 18:06:10 +02:00
share Remove extremely outdated share/certs dir 2017-09-21 15:42:40 +12:00
src Merge #11499: [Qt] Add upload and download info to the peerlist (debug menu) 2017-10-22 15:33:11 -10:00
test Merge #11538: qa: Fix race condition failures in replace-by-fee.py, sendheaders.py 2017-10-23 17:19:26 +02:00
.gitattributes Separate protocol versioning from clientversion 2014-10-29 00:24:40 -04:00
.gitignore Use shared config file for functional and util tests 2017-05-03 14:18:30 -04:00
.travis.yml Revert "travis: filter out pyenv" 2017-10-18 14:42:08 -04:00
autogen.sh Add MIT license to autogen.sh and share/genbuild.sh 2016-09-21 23:01:36 +00:00
configure.ac qa: Fix lcov for out-of-tree builds 2017-10-02 13:30:39 +02:00
CONTRIBUTING.md Update CONTRIBUTRING.md to reduce unnecesarry review workload 2017-09-07 16:57:40 -07:00
COPYING Put back inadvertently removed copyright notices 2017-09-13 07:24:42 +00:00
INSTALL.md Update INSTALL landing redirection notice for build instructions. 2016-10-06 12:27:23 +13:00
libbitcoinconsensus.pc.in Unify package name to as few places as possible without major changes 2015-12-14 02:11:10 +00:00
Makefile.am Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74 2017-09-29 14:27:20 +02:00
README.md Squashed 'src/univalue/' changes from 16a1f7f6e..fe805ea74 2017-09-29 14:27:20 +02:00

README.md

Bitcoin Core integration/staging tree

Build Status

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoin.org/en/download, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md.

The developer mailing list should be used to discuss complicated or controversial changes before working on a patch set.

Developer IRC can be found on Freenode at #bitcoin-core-dev.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.