Updates Python linters, spellchecking, and ShellCheck versions. The PR links are updated for the dependency versions in test/README.md. ShellCheck SC2230 removed to align with with new behaviour in v0.7.1. Fixes #19346.
61 lines
2 KiB
Bash
Executable file
61 lines
2 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
#
|
|
# Copyright (c) 2018-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check for shellcheck warnings in shell scripts.
|
|
|
|
export LC_ALL=C
|
|
|
|
# The shellcheck binary segfault/coredumps in Travis with LC_ALL=C
|
|
# It does not do so in Ubuntu 14.04, 16.04, 18.04 in versions 0.3.3, 0.3.7, 0.4.6
|
|
# respectively. So export LC_ALL=C is set as required by lint-shell-locale.sh
|
|
# but unset here in case of running in Travis.
|
|
if [ "$TRAVIS" = "true" ]; then
|
|
unset LC_ALL
|
|
fi
|
|
|
|
# Disabled warnings:
|
|
disabled=(
|
|
SC2046 # Quote this to prevent word splitting.
|
|
SC2086 # Double quote to prevent globbing and word splitting.
|
|
SC2162 # read without -r will mangle backslashes.
|
|
)
|
|
disabled_gitian=(
|
|
SC2094 # Make sure not to read and write the same file in the same pipeline.
|
|
SC2129 # Consider using { cmd1; cmd2; } >> file instead of individual redirects.
|
|
)
|
|
|
|
EXIT_CODE=0
|
|
|
|
if ! command -v shellcheck > /dev/null; then
|
|
echo "Skipping shell linting since shellcheck is not installed."
|
|
exit $EXIT_CODE
|
|
fi
|
|
|
|
SHELLCHECK_CMD=(shellcheck --external-sources --check-sourced)
|
|
EXCLUDE="--exclude=$(IFS=','; echo "${disabled[*]}")"
|
|
if ! "${SHELLCHECK_CMD[@]}" "$EXCLUDE" $(git ls-files -- '*.sh' | grep -vE 'src/(leveldb|secp256k1|univalue)/'); then
|
|
EXIT_CODE=1
|
|
fi
|
|
|
|
if ! command -v yq > /dev/null; then
|
|
echo "Skipping Gitian descriptor scripts checking since yq is not installed."
|
|
exit $EXIT_CODE
|
|
fi
|
|
|
|
EXCLUDE_GITIAN=${EXCLUDE}",$(IFS=','; echo "${disabled_gitian[*]}")"
|
|
for descriptor in $(git ls-files -- 'contrib/gitian-descriptors/*.yml')
|
|
do
|
|
script=$(basename "$descriptor")
|
|
# Use #!/bin/bash as gitian-builder/bin/gbuild does to complete a script.
|
|
echo "#!/bin/bash" > $script
|
|
yq -r .script "$descriptor" >> $script
|
|
if ! "${SHELLCHECK_CMD[@]}" "$EXCLUDE_GITIAN" $script; then
|
|
EXIT_CODE=1
|
|
fi
|
|
rm $script
|
|
done
|
|
|
|
exit $EXIT_CODE
|