78f912c901
10d61505fe[test] remove confusing p2p property (gzhao408)549d30faf0scripted-diff: replace p2p with p2ps[0] in p2p_invalid_tx (gzhao408)7a0de46aea[doc] sample code for test framework p2p objects (gzhao408)784f757994[refactor] clarify tests by referencing p2p objects directly (gzhao408) Pull request description: The `TestNode` has a `p2p` property which is an alias for `p2ps[0]`. I think this should be removed because it can be confusing and misleading (to both the test writer and reviewer), especially if a TestNode has multiple p2ps connected (which is the case for many tests). Another example is when a test has multiple subtests that connect 1 p2p and use the `p2p` property to reference it. If the subtests don't completely clean up after themselves, the subtests may affect one another. The best way to refer to a connected p2p is use the object returned by `add_p2p_connection` like this: ```py p2p_conn = node.add_p2p_connection(P2PInterface()) ``` A good example is [p2p_invalid_locator.py](https://github.com/bitcoin/bitcoin/blob/master/test/functional/p2p_invalid_locator.py), which cleans up after itself (waits in both `wait_for_disconnect` and in `disconnect_p2ps`) but wouldn't need so much complexity if it just referenced the connections directly. If there is only one connected, it's not really that tedious to just use `node.p2ps[0]` instead of `node.p2p` (and it can always be aliased inside the test itself). ACKs for top commit: robot-dreams: utACK10d61505fejnewbery: utACK10d61505feguggero: Concept ACK10d61505. Tree-SHA512: 5965548929794ec660dae03467640cb2156d7d826cefd26d3a126472cbc2494b855c1d26bbb7b412281fbdc92b9798b9765a85c27bc1a97f7798f27f64db6f13
90 lines
4.6 KiB
Python
Executable file
90 lines
4.6 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test p2p blocksonly"""
|
|
|
|
from test_framework.messages import msg_tx, CTransaction, FromHex
|
|
from test_framework.p2p import P2PInterface
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
|
|
class P2PBlocksOnly(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = False
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-blocksonly"]]
|
|
|
|
def run_test(self):
|
|
block_relay_peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
|
|
self.log.info('Check that txs from p2p are rejected and result in disconnect')
|
|
prevtx = self.nodes[0].getblock(self.nodes[0].getblockhash(1), 2)['tx'][0]
|
|
rawtx = self.nodes[0].createrawtransaction(
|
|
inputs=[{
|
|
'txid': prevtx['txid'],
|
|
'vout': 0
|
|
}],
|
|
outputs=[{
|
|
self.nodes[0].get_deterministic_priv_key().address: 50 - 0.00125
|
|
}],
|
|
)
|
|
sigtx = self.nodes[0].signrawtransactionwithkey(
|
|
hexstring=rawtx,
|
|
privkeys=[self.nodes[0].get_deterministic_priv_key().key],
|
|
prevtxs=[{
|
|
'txid': prevtx['txid'],
|
|
'vout': 0,
|
|
'scriptPubKey': prevtx['vout'][0]['scriptPubKey']['hex'],
|
|
}],
|
|
)['hex']
|
|
assert_equal(self.nodes[0].getnetworkinfo()['localrelay'], False)
|
|
with self.nodes[0].assert_debug_log(['transaction sent in violation of protocol peer=0']):
|
|
block_relay_peer.send_message(msg_tx(FromHex(CTransaction(), sigtx)))
|
|
block_relay_peer.wait_for_disconnect()
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], 0)
|
|
|
|
# Remove the disconnected peer and add a new one.
|
|
del self.nodes[0].p2ps[0]
|
|
tx_relay_peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
|
|
self.log.info('Check that txs from rpc are not rejected and relayed to other peers')
|
|
assert_equal(self.nodes[0].getpeerinfo()[0]['relaytxes'], True)
|
|
txid = self.nodes[0].testmempoolaccept([sigtx])[0]['txid']
|
|
with self.nodes[0].assert_debug_log(['received getdata for: wtx {} peer=1'.format(txid)]):
|
|
self.nodes[0].sendrawtransaction(sigtx)
|
|
tx_relay_peer.wait_for_tx(txid)
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], 1)
|
|
|
|
self.log.info('Check that txs from peers with relay-permission are not rejected and relayed to others')
|
|
self.log.info("Restarting node 0 with relay permission and blocksonly")
|
|
self.restart_node(0, ["-persistmempool=0", "-whitelist=relay@127.0.0.1", "-blocksonly"])
|
|
assert_equal(self.nodes[0].getrawmempool(), [])
|
|
first_peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
second_peer = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
peer_1_info = self.nodes[0].getpeerinfo()[0]
|
|
assert_equal(peer_1_info['permissions'], ['relay'])
|
|
peer_2_info = self.nodes[0].getpeerinfo()[1]
|
|
assert_equal(peer_2_info['permissions'], ['relay'])
|
|
assert_equal(self.nodes[0].testmempoolaccept([sigtx])[0]['allowed'], True)
|
|
txid = self.nodes[0].testmempoolaccept([sigtx])[0]['txid']
|
|
|
|
self.log.info('Check that the tx from first_peer with relay-permission is relayed to others (ie.second_peer)')
|
|
with self.nodes[0].assert_debug_log(["received getdata"]):
|
|
# Note that normally, first_peer would never send us transactions since we're a blocksonly node.
|
|
# By activating blocksonly, we explicitly tell our peers that they should not send us transactions,
|
|
# and Bitcoin Core respects that choice and will not send transactions.
|
|
# But if, for some reason, first_peer decides to relay transactions to us anyway, we should relay them to
|
|
# second_peer since we gave relay permission to first_peer.
|
|
# See https://github.com/bitcoin/bitcoin/issues/19943 for details.
|
|
first_peer.send_message(msg_tx(FromHex(CTransaction(), sigtx)))
|
|
self.log.info('Check that the peer with relay-permission is still connected after sending the transaction')
|
|
assert_equal(first_peer.is_connected, True)
|
|
second_peer.wait_for_tx(txid)
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], 1)
|
|
self.log.info("Relay-permission peer's transaction is accepted and relayed")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
P2PBlocksOnly().main()
|