The value of DEFAULT_INCREMENTAL_RELAY_FEE has never been tuned for Dogecoin since porting from Bitcoin Core 0.14. Even though the dual meaning of this parameter is suboptimal, it can still be tuned. This commit sets the value to 1/10th of DEFAULT_MIN_RELAY_TX_FEE from validation.h, which causes: 1. Mempool limiting to be performed in steps of 0.0001 DOGE/kb instead of 0.00001 DOGE/kb 2. RBF to be accepted by the mempool if the new fee is at least 0.0001 DOGE/kb higher than the previous fee known to the mempool 3. RBF to be cheaper than CPFP by a factor 10 (as the latter would require a fee of more than 0.001 DOGE/kb on a subsequent bumping transaction), to encourage mempool replacement over prioritizing through additional transactions that need to be mined. 4. Mempool limiting to be 10x faster to reset to zero than before, because for bitcoin, fee increments equaled their minimum fee, but for us this was 1/100th. mempool_tests.cpp has been reworked a bit to reflect the reality of having a lower increment than the minimum fee, as even though this already was the case, this was not tested correctly due to the static values in the unit test. |
||
---|---|---|
.. | ||
data | ||
addrman_tests.cpp | ||
alert_tests.cpp | ||
allocator_tests.cpp | ||
amount_tests.cpp | ||
arith_uint256_tests.cpp | ||
auxpow_tests.cpp | ||
base32_tests.cpp | ||
base58_tests.cpp | ||
base64_tests.cpp | ||
bctest.py | ||
bip32_tests.cpp | ||
bitcoin-util-test.py | ||
blockencodings_tests.cpp | ||
bloom_tests.cpp | ||
bswap_tests.cpp | ||
buildenv.py.in | ||
checkqueue_tests.cpp | ||
coins_tests.cpp | ||
compress_tests.cpp | ||
crypto_tests.cpp | ||
cuckoocache_tests.cpp | ||
dbwrapper_tests.cpp | ||
dogecoin_tests.cpp | ||
DoS_tests.cpp | ||
getarg_tests.cpp | ||
hash_tests.cpp | ||
key_tests.cpp | ||
limitedmap_tests.cpp | ||
main_tests.cpp | ||
Makefile | ||
mempool_tests.cpp | ||
merkle_tests.cpp | ||
miner_tests.cpp | ||
multisig_tests.cpp | ||
net_tests.cpp | ||
netbase_tests.cpp | ||
pmt_tests.cpp | ||
policyestimator_tests.cpp | ||
pow_tests.cpp | ||
prevector_tests.cpp | ||
raii_event_tests.cpp | ||
README.md | ||
reverselock_tests.cpp | ||
rpc_tests.cpp | ||
sanity_tests.cpp | ||
scheduler_tests.cpp | ||
script_P2SH_tests.cpp | ||
script_tests.cpp | ||
scriptnum10.h | ||
scriptnum_tests.cpp | ||
scrypt_tests.cpp | ||
serialize_tests.cpp | ||
sighash_tests.cpp | ||
sigopcount_tests.cpp | ||
skiplist_tests.cpp | ||
streams_tests.cpp | ||
test_bitcoin.cpp | ||
test_bitcoin.h | ||
test_bitcoin_fuzzy.cpp | ||
test_random.h | ||
testutil.cpp | ||
testutil.h | ||
timedata_tests.cpp | ||
transaction_tests.cpp | ||
txvalidationcache_tests.cpp | ||
uint256_tests.cpp | ||
univalue_tests.cpp | ||
util_tests.cpp | ||
versionbits_tests.cpp |
Compiling/running unit tests
Unit tests will be automatically compiled if dependencies were met in ./configure
and tests weren't explicitly disabled.
After configuring, they can be run with make check
.
To run the bitcoind tests manually, launch src/test/test_bitcoin
.
To add more bitcoind tests, add BOOST_AUTO_TEST_CASE
functions to the existing
.cpp files in the test/
directory or add new .cpp files that
implement new BOOST_AUTO_TEST_SUITE sections.
To run the bitcoin-qt tests manually, launch src/qt/test/test_bitcoin-qt
To add more bitcoin-qt tests, add them to the src/qt/test/
directory and
the src/qt/test/test_main.cpp
file.
Running individual tests
test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:
test_bitcoin --log_level=all --run_test=getarg_tests
... or to run just the doubledash test:
test_bitcoin --run_test=getarg_tests/doubledash
Run test_bitcoin --help
for the full list.
Note on adding test cases
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since bitcoin already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).
The build system is setup to compile an executable called test_bitcoin
that runs all of the unit tests. The main source file is called
test_bitcoin.cpp. To add a new unit test file to our test suite you need
to add the file to src/Makefile.test.include
. The pattern is to create
one test file for each class or source file for which you want to create
unit tests. The file naming convention is <source_filename>_tests.cpp
and such files should wrap their tests in a test suite
called <source_filename>_tests
. For an example of this pattern,
examine uint256_tests.cpp
.
For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.
bitcoin-util-test.py
The test directory also contains the bitcoin-util-test.py tool, which tests bitcoin utils (currently just bitcoin-tx). This test gets run automatically during the make check
build process. It is also possible to run the test manually from the src directory:
test/bitcoin-util-test.py --srcdir=[current directory]