dogecoin/src
MarcoFalke 6677be64f6
Merge #17473: refactor: Settings code cleanups
e9fd366044 refactor: Remove null setting check in GetSetting() (Russell Yanofsky)
cba2710220 scripted-diff: Remove unused ArgsManager type flags in tests (Russell Yanofsky)
425bb30725 refactor: Add util_CheckValue test (Russell Yanofsky)
0fa54358b0 refactor: Add ArgsManager::GetSettingsList method (Russell Yanofsky)
3e185522ac refactor: Get rid of ArgsManagerHelper class (Russell Yanofsky)
dc0f148074 refactor: Replace FlagsOfKnownArg with GetArgFlags (Russell Yanofsky)
57e8b7a727 refactor: Clean up includeconf comments (Russell Yanofsky)
3f7dc9b808 refactor: Clean up long lines in settings code (Russell Yanofsky)

Pull request description:

  This PR doesn't change behavior. It just implements some suggestions from #15934 and #16545 and few other small cleanups.

ACKs for top commit:
  jnewbery:
    Code review ACK e9fd366044
  MarcoFalke:
    ACK e9fd366044 🚟

Tree-SHA512: 6e100d92c72f72bc39567187ab97a3547b3c06e5fcf1a1b74023358b8bca552124ca6a53c0ab53179b7f1329c03d9a73faaef6d73d2cd1a2321568a0286525e2
2019-12-20 03:05:28 +07:00
..
bench Merge #17593: test: move more utility functions into test utility library 2019-12-16 16:08:56 -05:00
compat [MOVEONLY] Move cpuid code from random & sha256 to compat/cpuid 2019-11-12 14:50:44 -08:00
config
consensus net: Fix uninitialized read in ProcessMessage(...) 2019-11-27 21:27:56 +00:00
crypto Report amount of data gathered from environment 2019-11-12 15:35:26 -08:00
index
interfaces Merge #17750: util: change GetWarnings parameter to bool 2019-12-16 16:07:20 -05:00
leveldb
logging logs: add BCLog::Timer and related macros 2019-11-04 14:13:52 -05:00
node Merge #17564: rpc: Use mempool from node context instead of global 2019-12-16 16:05:06 -05:00
policy refactor: Remove redundant c_str() calls in formatting 2019-10-28 13:31:33 +01:00
primitives
qt Merge #17750: util: change GetWarnings parameter to bool 2019-12-16 16:07:20 -05:00
rpc Merge #17750: util: change GetWarnings parameter to bool 2019-12-16 16:07:20 -05:00
script Merge #17439: refactor: Use proper MAX_SCRIPT_ELEMENT_SIZE constants consistently 2019-11-21 10:11:06 -05:00
secp256k1
support Fix segfault in allocator_tests/arena_tests 2019-11-16 10:43:37 -08:00
test Merge #17473: refactor: Settings code cleanups 2019-12-20 03:05:28 +07:00
univalue Update univalue subtree 2019-10-30 16:24:02 -04:00
util Merge #17473: refactor: Settings code cleanups 2019-12-20 03:05:28 +07:00
wallet Merge #17537: wallet: Cleanup and move opportunistic and superfluous TopUp()s 2019-12-17 12:01:18 -05:00
zmq Pass block height in Chain::BlockConnected/Chain::BlockDisconnected 2019-11-05 12:59:16 -05:00
.clang-format
addrdb.cpp
addrdb.h refactor: Remove addrdb.h dependency from node.h 2019-10-29 11:30:12 +02:00
addrman.cpp
addrman.h
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp
banman.h Merge #17297: refactor: Remove addrdb.h dependency from node.h 2019-11-04 13:18:27 +01:00
base58.cpp util: Don't allow base58-decoding of std::string:s containing non-base58 characters 2019-12-12 11:01:56 +00:00
base58.h Add bounds checks in key_io before DecodeBase58Check 2019-12-05 16:31:09 -08:00
bech32.cpp
bech32.h
bitcoin-cli-res.rc
bitcoin-cli.cpp util: remove unwanted fields from bitcoin-cli -getinfo 2019-12-04 06:48:53 +00:00
bitcoin-tx-res.rc
bitcoin-tx.cpp refactor: Remove redundant c_str() calls in formatting 2019-10-28 13:31:33 +01:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp doc: rename wallet-tool references to bitcoin-wallet 2019-12-02 12:06:35 -05:00
bitcoind-res.rc
bitcoind.cpp Merge #16839: Replace Connman and BanMan globals with NodeContext local 2019-10-30 12:35:41 +01:00
blockencodings.cpp [validation] Add CValidationState subclasses 2019-10-29 15:46:45 -04:00
blockencodings.h
blockfilter.cpp cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice 2019-12-06 21:47:55 +01:00
blockfilter.h cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice 2019-12-06 21:47:55 +01:00
bloom.cpp
bloom.h
chain.cpp
chain.h
chainparams.cpp fix uninitialized variable nMinerConfirmationWindow 2019-11-12 17:59:52 -06:00
chainparams.h doc: Remove explicit network name references 2019-11-01 12:06:35 +01:00
chainparamsbase.cpp
chainparamsbase.h doc: Remove explicit network name references 2019-11-01 12:06:35 +01:00
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp
coins.h
compat.h
compressor.cpp
compressor.h
core_io.h
core_memusage.h
core_read.cpp
core_write.cpp
cuckoocache.h Use correct C++11 header for std::swap() 2019-11-29 21:23:25 +02:00
dbwrapper.cpp
dbwrapper.h
dummywallet.cpp scripted-diff: Rename InitInterfaces to NodeContext 2019-10-28 10:30:51 -04:00
flatfile.cpp
flatfile.h
fs.cpp Fix occurences of c_str() used with size() to data() 2019-10-28 13:41:45 +01:00
fs.h wallet: unbreak with boost 1.72 2019-12-11 18:51:16 +00:00
hash.cpp
hash.h
httprpc.cpp Add RPC Whitelist Feature from #12248 2019-12-11 12:33:54 -08:00
httprpc.h
httpserver.cpp http: add missing header bootlegged by boost < 1.72 2019-10-25 13:11:09 +00:00
httpserver.h
indirectmap.h
init.cpp Merge #12763: Add RPC Whitelist Feature from #12248 2019-12-13 11:27:36 +01:00
init.h Pass NodeContext, ConnMan, BanMan references more places 2019-10-28 10:30:51 -04:00
key.cpp Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2019-11-20 12:43:55 +01:00
key.h Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2019-11-20 12:43:55 +01:00
key_io.cpp Add bounds checks in key_io before DecodeBase58Check 2019-12-05 16:31:09 -08:00
key_io.h
limitedmap.h
logging.cpp scripted-diff: Change BCLog::DB to BCLog::WALLETDB 2019-11-08 18:45:38 +01:00
logging.h scripted-diff: Change BCLog::DB to BCLog::WALLETDB 2019-11-08 18:45:38 +01:00
Makefile.am build: Create test utility library from src/test/util/ 2019-11-21 21:13:08 +01:00
Makefile.bench.include [test] move wallet helper functions into test library 2019-11-25 16:40:09 +01:00
Makefile.leveldb.include
Makefile.qt.include Merge #17513: refactor, qt: Nuke some circular dependencies 2019-11-21 19:38:39 +01:00
Makefile.qt_locale.include
Makefile.qttest.include build: Create test utility library from src/test/util/ 2019-11-21 21:13:08 +01:00
Makefile.test.include tests: Add fuzzing harness for various hex related functions 2019-12-16 22:50:49 +00:00
Makefile.test_util.include [test] move wallet helper functions into test library 2019-11-25 16:40:09 +01:00
memusage.h
merkleblock.cpp
merkleblock.h
miner.cpp refactor: Remove unused COINBASE_FLAGS 2019-11-20 19:06:52 -05:00
miner.h
net.cpp Seed RNG with precision timestamps on receipt of net messages. 2019-11-23 16:06:34 -05:00
net.h Merge #17243: p2p: add PoissonNextSend method that returns mockable time 2019-11-05 12:38:28 -05:00
net_permissions.cpp
net_permissions.h
net_processing.cpp Merge #17243: p2p: add PoissonNextSend method that returns mockable time 2019-11-05 12:38:28 -05:00
net_processing.h [validation] Add CValidationState subclasses 2019-10-29 15:46:45 -04:00
net_types.h refactor: Remove addrdb.h dependency from node.h 2019-10-29 11:30:12 +02:00
netaddress.cpp
netaddress.h CNetAddr: fix IsRFC2544 comment 2019-12-16 19:42:18 -08:00
netbase.cpp doc: Fix some misspellings 2019-11-04 04:22:53 -05:00
netbase.h
netmessagemaker.h
noui.cpp test: Add ASSERT_DEBUG_LOG to unit test framework 2019-11-04 10:42:33 -05:00
noui.h test: Add ASSERT_DEBUG_LOG to unit test framework 2019-11-04 10:42:33 -05:00
optional.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h Use correct C++11 header for std::swap() 2019-11-29 21:23:25 +02:00
protocol.cpp
protocol.h Merge #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr 2019-12-11 17:00:27 -05:00
psbt.cpp Have a PSBTAnalysis state that indicates invalid PSBT 2019-11-19 14:54:08 -05:00
psbt.h Merge #17524: psbt: handle unspendable psbts 2019-12-10 12:12:10 -05:00
pubkey.cpp Merge #17275: pubkey: Assert CPubKey's ECCVerifyHandle precondition 2019-12-06 13:35:37 -05:00
pubkey.h Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2019-11-20 12:43:55 +01:00
random.cpp Make env data logging optional 2019-12-08 18:34:02 -08:00
random.h Move events_hasher into RNGState() 2019-12-05 09:49:11 -08:00
randomenv.cpp Put bounds on the number of CPUID leaves explored 2019-11-20 10:54:08 -08:00
randomenv.h [MOVEONLY] Move perfmon data gathering to new randomenv module 2019-11-12 14:50:44 -08:00
rest.cpp rest: Use mempool from node context instead of global 2019-12-16 10:45:22 -05:00
reverse_iterator.h
reverselock.h
scheduler.cpp Run background seeding periodically instead of unpredictably 2019-11-12 15:35:26 -08:00
scheduler.h
serialize.h
shutdown.cpp
shutdown.h
span.h
streams.h
sync.cpp refactor: Remove redundant c_str() calls in formatting 2019-10-28 13:31:33 +01:00
sync.h
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
tinyformat.h util: Update tinyformat to upstream 2019-12-06 10:02:08 +01:00
torcontrol.cpp
torcontrol.h
txdb.cpp
txdb.h
txmempool.cpp Fire TransactionRemovedFromMempool from mempool 2019-11-21 21:05:38 +01:00
txmempool.h Remove unnecessary forward declaration 2019-11-09 22:08:29 -08:00
ui_interface.cpp
ui_interface.h
uint256.cpp
uint256.h
undo.h
validation.cpp refactor: Remove unused COINBASE_FLAGS 2019-11-20 19:06:52 -05:00
validation.h Use correct C++11 header for std::swap() 2019-11-29 21:23:25 +02:00
validationinterface.cpp Fire TransactionRemovedFromMempool from mempool 2019-11-21 21:05:38 +01:00
validationinterface.h Fire TransactionRemovedFromMempool from mempool 2019-11-21 21:05:38 +01:00
version.h
versionbits.cpp
versionbits.h
versionbitsinfo.cpp
versionbitsinfo.h
walletinitinterface.h scripted-diff: Rename InitInterfaces to NodeContext 2019-10-28 10:30:51 -04:00
warnings.cpp [style] Code style fixups in GetWarnings() 2019-12-15 17:05:52 -03:00
warnings.h util: change GetWarnings parameter to bool 2019-12-15 13:24:48 -03:00