maxmustermann/dogecoin
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
dogecoin/src
History
fanquake a4a93a0bad
Merge #17906: gui: Set CConnman byte counters earlier to avoid uninitialized reads 
8313fa8e81 gui: Set CConnman byte counters earlier to avoid uninitialized reads (Russell Yanofsky)

Pull request description:

  Initialize CConnman byte counters during construction, so GetTotalBytesRecv() and GetTotalBytesSent() methods don't return garbage before Start() is called.

  Change shouldn't have any effect outside of the GUI. It just fixes a race condition during a qt test that was observed on travis: https://travis-ci.org/bitcoin/bitcoin/jobs/634989685

ACKs for top commit:
  MarcoFalke:
    ACK 8313fa8e81
  promag:
    ACK 8313fa8e81.

Tree-SHA512: 97c246da4e28e6e0b48f685b840f96746ad75c4b157a692201c6c4702db328a88ead8507d8e1b4e608aa1882513174ec60cf3977c31b7a9d76678cc9f49b45f8
2020-01-14 08:53:34 +08:00
..
bench test: Show debug log on unit test failure 2020-01-02 18:00:05 -05:00
compat scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
config
consensus scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
crypto scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
index scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
interfaces Merge #16963: wallet: Fix unique_ptr usage in boost::signals2 2020-01-08 15:58:33 +01:00
leveldb
logging scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
node scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
policy scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
primitives scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
qt Merge #16963: wallet: Fix unique_ptr usage in boost::signals2 2020-01-08 15:58:33 +01:00
rpc Merge #17781: rpc: Remove mempool global from miner 2020-01-02 17:50:56 -05:00
script Merge #16658: validation: Rename CheckInputs to CheckInputScripts 2020-01-02 11:09:00 -05:00
secp256k1
support scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
test Merge #16945: refactor: introduce CChainState::GetCoinsCacheSizeState 2020-01-13 12:42:38 +01:00
univalue
util Fix improper Doxygen inline comments 2020-01-10 16:32:40 -08:00
wallet Merge #16963: wallet: Fix unique_ptr usage in boost::signals2 2020-01-08 15:58:33 +01:00
zmq Merge #17445: zmq: Fix due to invalid argument and multiple notifiers 2020-01-08 15:20:34 +01:00
.clang-format
addrdb.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
addrdb.h Convert addrdb/addrman to new serialization 2020-01-02 11:05:36 -08:00
addrman.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
addrman.h Convert addrdb/addrman to new serialization 2020-01-02 11:05:36 -08:00
amount.h
arith_uint256.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
arith_uint256.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
attributes.h
banman.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
banman.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
base58.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
base58.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bech32.cpp
bech32.h
bitcoin-cli-res.rc
bitcoin-cli.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bitcoin-tx-res.rc
bitcoin-tx.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bitcoin-wallet-res.rc
bitcoin-wallet.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bitcoind-res.rc
bitcoind.cpp
blockencodings.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
blockencodings.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
blockfilter.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
blockfilter.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bloom.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
bloom.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chain.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chain.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chainparams.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chainparams.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chainparamsbase.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chainparamsbase.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
coins.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
compat.h
compressor.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
compressor.h
core_io.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
core_memusage.h
core_read.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
core_write.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
cuckoocache.h Use correct C++11 header for std::swap() 2019-11-29 21:23:25 +02:00
dbwrapper.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
dbwrapper.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
dummywallet.cpp Merge #16963: wallet: Fix unique_ptr usage in boost::signals2 2020-01-08 15:58:33 +01:00
flatfile.cpp
flatfile.h
fs.cpp
fs.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
hash.cpp
hash.h
httprpc.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
httprpc.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
httpserver.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
httpserver.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
indirectmap.h
init.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
init.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
key.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
key.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
key_io.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
key_io.h
limitedmap.h
logging.cpp Merge #16688: log: Add validation interface logging 2020-01-09 21:05:35 +01:00
logging.h Merge #16688: log: Add validation interface logging 2020-01-09 21:05:35 +01:00
Makefile.am build: remove double LIBBITCOIN_SERVER linking 2020-01-12 08:49:40 +08:00
Makefile.bench.include
Makefile.leveldb.include
Makefile.qt.include
Makefile.qt_locale.include Restore English translation option 2020-01-06 22:58:47 -05:00
Makefile.qttest.include
Makefile.test.include Merge #16945: refactor: introduce CChainState::GetCoinsCacheSizeState 2020-01-13 12:42:38 +01:00
Makefile.test_util.include
memusage.h
merkleblock.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
merkleblock.h
miner.cpp rpc: Remove mempool global from miner 2019-12-23 06:12:10 +07:00
miner.h rpc: Remove mempool global from miner 2019-12-23 06:12:10 +07:00
net.cpp
net.h gui: Set CConnman byte counters earlier to avoid uninitialized reads 2020-01-10 14:55:10 -05:00
net_permissions.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
net_permissions.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
net_processing.cpp Merge #17762: net: Log to net category for exceptions in ProcessMessages 2020-01-02 21:39:00 +01:00
net_processing.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
net_types.h
netaddress.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
netaddress.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
netbase.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
netbase.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
netmessagemaker.h
noui.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
noui.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
optional.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
outputtype.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
outputtype.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
pow.cpp
pow.h
prevector.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
protocol.cpp
protocol.h Merge #17474: Bugfix: GUI: Recognise NETWORK_LIMITED in formatServicesStr 2019-12-11 17:00:27 -05:00
psbt.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
psbt.h Merge #17524: psbt: handle unspendable psbts 2019-12-10 12:12:10 -05:00
pubkey.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
pubkey.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
random.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
random.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
randomenv.cpp
randomenv.h
rest.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
reverse_iterator.h
reverselock.h
scheduler.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
scheduler.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
serialize.h Introduce new serialization macros without casts 2020-01-02 11:05:27 -08:00
shutdown.cpp
shutdown.h
span.h
streams.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
sync.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
sync.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
threadinterrupt.cpp
threadinterrupt.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
threadsafety.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
timedata.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
timedata.h
tinyformat.h util: Update tinyformat to upstream 2019-12-06 10:02:08 +01:00
torcontrol.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
torcontrol.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
txdb.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
txdb.h Merge #16945: refactor: introduce CChainState::GetCoinsCacheSizeState 2020-01-13 12:42:38 +01:00
txmempool.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
txmempool.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
ui_interface.cpp Merge #16963: wallet: Fix unique_ptr usage in boost::signals2 2020-01-08 15:58:33 +01:00
ui_interface.h Merge #16963: wallet: Fix unique_ptr usage in boost::signals2 2020-01-08 15:58:33 +01:00
uint256.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
uint256.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
undo.h
validation.cpp Merge #16945: refactor: introduce CChainState::GetCoinsCacheSizeState 2020-01-13 12:42:38 +01:00
validation.h refactoring: introduce CChainState::GetCoinsCacheSizeState 2019-12-12 11:20:17 -05:00
validationinterface.cpp Merge #16688: log: Add validation interface logging 2020-01-09 21:05:35 +01:00
validationinterface.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
version.h
versionbits.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
versionbits.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
versionbitsinfo.h
walletinitinterface.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
warnings.cpp scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
warnings.h scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00