dogecoin/test/functional
MarcoFalke 64139803f1
Merge #18690: test: Check object hashes in wait_for_getdata
9f5608c289 test: check for matching object hashes in wait_for_getdata (Danny Lee)

Pull request description:

  Previously, `wait_for_getdata` only looked for the presence of a recent `"getdata"` message.  Additionally checking the object hashes inside the message should make tests involving `wait_for_getdata` more robust.

  `p2p_sendheaders.py` already overrides `wait_for_getdata` do this check; we can use the same approach consistently across all tests that call `wait_for_getdata`.

  This PR is progress towards #18614 , but closing that issue would also involve some additional changes to `wait_for_getheaders`.

ACKs for top commit:
  theStack:
    ACK 9f5608c289 🍻

Tree-SHA512: 8e7f95881c19631db014d4bb2399fea0d14686a32542f6ca3b60809744b0d684eac4e4c107c87143991f3cd0c2d4ab09d0c17486239768a9b40bee25f2e4d54a
2020-04-23 06:37:53 -04:00
..
data scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
test_framework Merge #18690: test: Check object hashes in wait_for_getdata 2020-04-23 06:37:53 -04:00
.gitignore
combine_logs.py scripted-diff: Add missed copyright headers 2020-01-04 20:18:28 +02:00
combined_log_template.html
create_cache.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
example_test.py [qa] Fix race condition in example_test.py 2019-07-25 10:32:07 -04:00
feature_abortnode.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_asmap.py init: move asmap code earlier in init process 2020-03-04 14:54:30 +01:00
feature_assumevalid.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_backwards_compatibility.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_bip68_sequence.py Merge #17004: validation: Remove REJECT code from CValidationState 2019-10-24 10:49:45 +02:00
feature_block.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_blocksdir.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_cltv.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_config_args.py Merge #17482: util: Disallow network-qualified command line options 2020-02-05 16:23:53 +01:00
feature_csv_activation.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_dbcrash.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
feature_dersig.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_fee_estimation.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_filelock.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_help.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_includeconf.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_loadblock.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_logging.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_maxuploadtarget.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_minchainwork.py
feature_notifications.py test: Check wallet name in -walletnotify script 2020-01-31 17:43:26 -05:00
feature_nulldummy.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_proxy.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
feature_pruning.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_rbf.py test: Remove unused, undocumented and misleading CScript.__add__ 2020-04-22 09:00:56 -04:00
feature_reindex.py
feature_segwit.py Merge #18384: [test] more specific feature_segwit test error messages and fixing incorrect comments 2020-04-21 13:42:21 -04:00
feature_shutdown.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_versionbits_warning.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
framework_test_script.py Add bn2vch test to functional tests 2020-03-18 13:54:01 -07:00
interface_bitcoin_cli.py test: fix intermittent race condition in interface_bitcoin_cli.py 2020-04-19 18:12:05 +02:00
interface_http.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rest.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rpc.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
interface_zmq.py zmq: Fix due to invalid argument and multiple notifiers 2019-11-11 22:22:32 +00:00
mempool_accept.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
mempool_expiry.py add: test that transactions expire from mempool 2020-02-19 10:03:48 +01:00
mempool_limit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mempool_package_onemore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
mempool_packages.py test: check custom descendant limit in mempool_packages.py 2020-02-27 00:24:33 +01:00
mempool_persist.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
mempool_reorg.py test: Increase debugging to hunt down mempool_reorg intermittent failure 2020-04-19 08:40:20 -04:00
mempool_resurrect.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
mempool_spend_coinbase.py
mining_basic.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
mining_getblocktemplate_longpoll.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mining_prioritisetransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
p2p_addr_relay.py test: Add basic addr relay test 2020-04-02 23:29:32 +08:00
p2p_blocksonly.py Disconnect peers violating blocks-only mode 2019-09-04 14:58:36 -04:00
p2p_compactblocks.py [Consensus] Bury segwit deployment 2019-08-14 15:52:52 -04:00
p2p_disconnect_ban.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_feefilter.py modify p2p_feefilter test to catch rounding error 2019-10-03 14:03:27 -04:00
p2p_filter.py test: Fix linter issue 2020-04-21 14:58:51 +03:00
p2p_fingerprint.py test: check for matching object hashes in wait_for_getdata 2020-04-22 10:46:08 -07:00
p2p_invalid_block.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_invalid_locator.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_invalid_messages.py Merge #18610: scripted-diff: test: replace command with msgtype (naming) 2020-04-19 09:18:21 -04:00
p2p_invalid_tx.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_leak.py Merge #18610: scripted-diff: test: replace command with msgtype (naming) 2020-04-19 09:18:21 -04:00
p2p_leak_tx.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_mempool.py
p2p_node_network_limited.py scripted-diff: test: Replace connect_nodes_bi with connect_nodes 2019-09-17 13:08:21 -04:00
p2p_permissions.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_segwit.py test: check for matching object hashes in wait_for_getdata 2020-04-22 10:46:08 -07:00
p2p_sendheaders.py test: check for matching object hashes in wait_for_getdata 2020-04-22 10:46:08 -07:00
p2p_timeouts.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_tx_download.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_unrequested_blocks.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
README.md Merge #17319: Tests: remove bignum module 2020-03-17 13:38:00 -04:00
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_blockchain.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_createmultisig.py Output a descriptor in createmultisig and addmultisigaddress 2020-01-30 23:55:36 -05:00
rpc_decodescript.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deprecated.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
rpc_dumptxoutset.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_estimatefee.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_fundrawtransaction.py Merge #17219: wallet: allow transaction without change if keypool is empty 2020-04-18 22:00:26 +12:00
rpc_generateblock.py rpc: Document all aliases for second arg of getblock 2020-04-16 08:45:05 -04:00
rpc_getaddressinfo_label_deprecation.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_getaddressinfo_labels_purpose_deprecation.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_getblockfilter.py rpc: Add getblockfilter RPC method. 2019-04-06 12:10:55 -07:00
rpc_getblockstats.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_getchaintips.py test: Remove unused imports 2019-04-09 12:10:35 -04:00
rpc_getdescriptorinfo.py qa: Add getdescriptorinfo functional test 2020-03-10 08:14:04 +00:00
rpc_help.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_invalidateblock.py rpc: Add generatetodescriptor 2019-10-30 10:01:32 -04:00
rpc_misc.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_net.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_preciousblock.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_psbt.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_rawtransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_scantxoutset.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_setban.py bump test timeouts so that functional tests run in valgrind 2020-01-25 15:51:35 +08:00
rpc_signmessage.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_signrawtransaction.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_txoutproof.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_uptime.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
rpc_users.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 2019-12-27 21:19:44 +01:00
test-shell.md TestShell: Return self from setup() 2019-11-05 12:55:52 +01:00
test_runner.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
tool_wallet.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_abandonconflict.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_address_types.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_avoidreuse.py test: Improve naming and logging of avoid_reuse tests 2020-04-14 15:03:14 +02:00
wallet_backup.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_balance.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_basic.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_bumpfee.py Merge #18673: scripted-diff: Sort test includes 2020-04-17 10:12:13 -04:00
wallet_coinbase_category.py
wallet_create_tx.py test: Add test for maxtxfee option 2019-07-10 11:58:46 +01:00
wallet_createwallet.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_disable.py scripted-diff: Update copyright in ./test 2019-03-02 10:58:35 -05:00
wallet_dump.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_encryption.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
wallet_fallbackfee.py
wallet_groups.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_hd.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_rescan.py test: Bump timeout in wallet_import_rescan 2020-04-17 17:09:27 -04:00
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_importmulti.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_importprunedfunds.py
wallet_keypool.py [wallet] allow transaction without change if keypool is empty 2020-02-04 11:20:25 +01:00
wallet_keypool_topup.py Tests: Use self.chain instead of 'regtest' in almost all current tests 2019-10-26 13:24:39 +02:00
wallet_labels.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_listreceivedby.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_listsinceblock.py test: listsinceblock block height checks 2020-03-24 16:44:26 +01:00
wallet_listtransactions.py rpc: Document all aliases for first arg of listtransactions 2020-04-16 08:45:33 -04:00
wallet_multiwallet.py Merge #15761: Replace -upgradewallet startup option with upgradewallet RPC 2020-04-19 07:06:42 -04:00
wallet_reorgsrestore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
wallet_resendwallettransactions.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_txn_clone.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_txn_doublespend.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_watchonly.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
wallet_zapwallettxes.py

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

mininode.py

Basic code to support P2P connectivity to a bitcoind.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: