bde7442526
The value of DEFAULT_INCREMENTAL_RELAY_FEE has never been tuned for Dogecoin since porting from Bitcoin Core 0.14. Even though the dual meaning of this parameter is suboptimal, it can still be tuned. This commit sets the value to 1/10th of DEFAULT_MIN_RELAY_TX_FEE from validation.h, which causes: 1. Mempool limiting to be performed in steps of 0.0001 DOGE/kb instead of 0.00001 DOGE/kb 2. RBF to be accepted by the mempool if the new fee is at least 0.0001 DOGE/kb higher than the previous fee known to the mempool 3. RBF to be cheaper than CPFP by a factor 10 (as the latter would require a fee of more than 0.001 DOGE/kb on a subsequent bumping transaction), to encourage mempool replacement over prioritizing through additional transactions that need to be mined. 4. Mempool limiting to be 10x faster to reset to zero than before, because for bitcoin, fee increments equaled their minimum fee, but for us this was 1/100th. mempool_tests.cpp has been reworked a bit to reflect the reality of having a lower increment than the minimum fee, as even though this already was the case, this was not tested correctly due to the static values in the unit test.
134 lines
7.3 KiB
C++
134 lines
7.3 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2016 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_POLICY_POLICY_H
|
|
#define BITCOIN_POLICY_POLICY_H
|
|
|
|
#include "consensus/consensus.h"
|
|
#include "script/interpreter.h"
|
|
#include "script/standard.h"
|
|
|
|
#include <string>
|
|
|
|
class CCoinsViewCache;
|
|
|
|
/** Recommended transaction fee by Dogecoin Core developers
|
|
*
|
|
* All fee defaults used throughout the client derive their
|
|
* value from this base default.
|
|
*/
|
|
static const CAmount RECOMMENDED_MIN_TX_FEE = COIN / 100;
|
|
|
|
/** Default for -blockmaxsize, which controls the maximum size of block the mining code will create **/
|
|
static const unsigned int DEFAULT_BLOCK_MAX_SIZE = 750000;
|
|
/** Default for -blockprioritysize, maximum space for zero/low-fee transactions **/
|
|
static const unsigned int DEFAULT_BLOCK_PRIORITY_SIZE = 27000;
|
|
/** Default for -blockmaxweight, which controls the range of block weights the mining code will create **/
|
|
static const unsigned int DEFAULT_BLOCK_MAX_WEIGHT = 3000000;
|
|
/** Default for -blockmintxfee, which sets the minimum feerate for a transaction in blocks created by mining code **/
|
|
static const unsigned int DEFAULT_BLOCK_MIN_TX_FEE = (unsigned int) RECOMMENDED_MIN_TX_FEE;
|
|
/** The maximum weight for transactions we're willing to relay/mine */
|
|
static const unsigned int MAX_STANDARD_TX_WEIGHT = 400000;
|
|
/** Maximum number of signature check operations in an IsStandard() P2SH script */
|
|
static const unsigned int MAX_P2SH_SIGOPS = 15;
|
|
/** The maximum number of sigops we're willing to relay/mine in a single tx */
|
|
static const unsigned int MAX_STANDARD_TX_SIGOPS_COST = MAX_BLOCK_SIGOPS_COST/5;
|
|
/** Default for -maxmempool, maximum megabytes of mempool memory usage */
|
|
static const unsigned int DEFAULT_MAX_MEMPOOL_SIZE = 300;
|
|
/** Default for -incrementalrelayfee, which sets the minimum feerate increase
|
|
* for mempool limiting or BIP 125 replacement
|
|
*
|
|
* Dogecoin: Increment mempool limits and accept RBF in steps of 0.0001 DOGE
|
|
* Calculation: DEFAULT_MIN_RELAY_TX_FEE = RECOMMENDED_MIN_TX_FEE / 10
|
|
* DEFAULT_INCREMENTAL_RELAY_FEE = DEFAULT_MIN_RELAY_TX_FEE / 10
|
|
*
|
|
* Rationale: This implements a smaller granularity than the wallet
|
|
* implementation for fee increments by default, leaving room for
|
|
* alternative increment strategies, yet limiting the amount of
|
|
* ineffective RBF spam we expose the network to. This also makes
|
|
* an RBF fee bump 10x cheaper than a CPFP transaction, because
|
|
* RBF leaves no on-chain waste, whereas CPFP adds another
|
|
* transaction to the chain.
|
|
*/
|
|
static const CAmount DEFAULT_INCREMENTAL_RELAY_FEE = RECOMMENDED_MIN_TX_FEE / 100;
|
|
/** Default for -bytespersigop */
|
|
static const unsigned int DEFAULT_BYTES_PER_SIGOP = 20;
|
|
/** The maximum number of witness stack items in a standard P2WSH script */
|
|
static const unsigned int MAX_STANDARD_P2WSH_STACK_ITEMS = 100;
|
|
/** The maximum size of each witness stack item in a standard P2WSH script */
|
|
static const unsigned int MAX_STANDARD_P2WSH_STACK_ITEM_SIZE = 80;
|
|
/** The maximum size of a standard witnessScript */
|
|
static const unsigned int MAX_STANDARD_P2WSH_SCRIPT_SIZE = 3600;
|
|
/** Min feerate for defining dust. Historically this has been the same as the
|
|
* minRelayTxFee, however changing the dust limit changes which transactions are
|
|
* standard and should be done with care and ideally rarely. It makes sense to
|
|
* only increase the dust limit after prior releases were already not creating
|
|
* outputs below the new threshold */
|
|
static const CAmount DUST_RELAY_TX_FEE = RECOMMENDED_MIN_TX_FEE / 1000;
|
|
/**
|
|
* Dogecoin: Default dust limit that is evaluated when considering whether a
|
|
* transaction output is required to pay additional fee for relay and inclusion
|
|
* in blocks. Overridden by -dustlimit
|
|
*/
|
|
static const CAmount DEFAULT_DUST_LIMIT = RECOMMENDED_MIN_TX_FEE;
|
|
|
|
/**
|
|
* Standard script verification flags that standard transactions will comply
|
|
* with. However scripts violating these flags may still be present in valid
|
|
* blocks and we must accept those blocks.
|
|
*/
|
|
static const unsigned int STANDARD_SCRIPT_VERIFY_FLAGS = MANDATORY_SCRIPT_VERIFY_FLAGS |
|
|
SCRIPT_VERIFY_DERSIG |
|
|
SCRIPT_VERIFY_STRICTENC |
|
|
SCRIPT_VERIFY_MINIMALDATA |
|
|
SCRIPT_VERIFY_NULLDUMMY |
|
|
SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_NOPS |
|
|
SCRIPT_VERIFY_CLEANSTACK |
|
|
SCRIPT_VERIFY_MINIMALIF |
|
|
SCRIPT_VERIFY_NULLFAIL |
|
|
SCRIPT_VERIFY_CHECKLOCKTIMEVERIFY |
|
|
SCRIPT_VERIFY_CHECKSEQUENCEVERIFY |
|
|
SCRIPT_VERIFY_LOW_S |
|
|
SCRIPT_VERIFY_WITNESS |
|
|
SCRIPT_VERIFY_DISCOURAGE_UPGRADABLE_WITNESS_PROGRAM |
|
|
SCRIPT_VERIFY_WITNESS_PUBKEYTYPE;
|
|
|
|
/** For convenience, standard but not mandatory verify flags. */
|
|
static const unsigned int STANDARD_NOT_MANDATORY_VERIFY_FLAGS = STANDARD_SCRIPT_VERIFY_FLAGS & ~MANDATORY_SCRIPT_VERIFY_FLAGS;
|
|
|
|
/** Used as the flags parameter to sequence and nLocktime checks in non-consensus code. */
|
|
static const unsigned int STANDARD_LOCKTIME_VERIFY_FLAGS = LOCKTIME_VERIFY_SEQUENCE |
|
|
LOCKTIME_MEDIAN_TIME_PAST;
|
|
|
|
bool IsStandard(const CScript& scriptPubKey, txnouttype& whichType, const bool witnessEnabled = false);
|
|
/**
|
|
* Check for standard transaction types
|
|
* @return True if all outputs (scriptPubKeys) use only standard transaction forms
|
|
*/
|
|
bool IsStandardTx(const CTransaction& tx, std::string& reason, const bool witnessEnabled = false);
|
|
/**
|
|
* Check for standard transaction types
|
|
* @param[in] mapInputs Map of previous transactions that have outputs we're spending
|
|
* @return True if all inputs (scriptSigs) use only standard transaction forms
|
|
*/
|
|
bool AreInputsStandard(const CTransaction& tx, const CCoinsViewCache& mapInputs);
|
|
/**
|
|
* Check if the transaction is over standard P2WSH resources limit:
|
|
* 3600bytes witnessScript size, 80bytes per witness stack element, 100 witness stack elements
|
|
* These limits are adequate for multi-signature up to n-of-100 using OP_CHECKSIG, OP_ADD, and OP_EQUAL,
|
|
*/
|
|
bool IsWitnessStandard(const CTransaction& tx, const CCoinsViewCache& mapInputs);
|
|
|
|
extern CFeeRate incrementalRelayFee;
|
|
extern CFeeRate dustRelayFee;
|
|
extern unsigned int nBytesPerSigOp;
|
|
extern CAmount nDustLimit;
|
|
|
|
/** Compute the virtual transaction size (weight reinterpreted as bytes). */
|
|
int64_t GetVirtualTransactionSize(int64_t nWeight, int64_t nSigOpCost);
|
|
int64_t GetVirtualTransactionSize(const CTransaction& tx, int64_t nSigOpCost = 0);
|
|
|
|
#endif // BITCOIN_POLICY_POLICY_H
|