dogecoin/src/test
fanquake 68ef9523d1
Merge #18413: script: prevent UB when computing abs value for num opcode serialize
2748e87932 script: prevent UB when computing abs value for num opcode serialize (pierrenn)

Pull request description:

  This was reported by practicalswift here #18046

  It seems that the original author of the line used a reference to glibc `abs`: https://github.com/lattera/glibc/blob/master/stdlib/abs.c

  However depending on some implementation details this can be undefined behavior for unusual values.

  A detailed explanation of the UB is provided here : https://stackoverflow.com/questions/17313579/is-there-a-safe-way-to-get-the-unsigned-absolute-value-of-a-signed-integer-with (by [Billy O'Neal](https://twitter.com/malwareminigun))

  Simple relevant godbolt example :  https://godbolt.org/z/yRwtCG

  Thanks!

ACKs for top commit:
  sipa:
    ACK 2748e87932
  MarcoFalke:
    ACK 2748e87932, only checked that the bitcoind binary does not change with clang -O2 🎓
  practicalswift:
    ACK 2748e87932

Tree-SHA512: 539a34c636c2674c66cb6e707d9d0dfdce63f59b5525610ed88da10c9a8d59d81466b111ad63b850660cef3750d732fc7755530c81a2d61f396be0707cd86dec
2020-05-02 21:24:05 +08:00
..
data Limit decimal range of numbers ParseScript accepts 2020-03-27 15:51:05 +09:00
fuzz Merge #18413: script: prevent UB when computing abs value for num opcode serialize 2020-05-02 21:24:05 +08:00
util test: Add CreateWalletFromFile test 2020-04-26 20:23:05 -04:00
addrman_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
allocator_tests.cpp
amount_tests.cpp
arith_uint256_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
base32_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
base58_tests.cpp
base64_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
bech32_tests.cpp
bip32_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockchain_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockencodings_tests.cpp
blockfilter_index_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
blockfilter_tests.cpp
bloom_tests.cpp Merge #18673: scripted-diff: Sort test includes 2020-04-17 10:12:13 -04:00
bswap_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
checkqueue_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
coins_tests.cpp Merge #18410: Docs: Improve commenting for coins.cpp|h 2020-04-22 14:23:56 +02:00
compilerbug_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
compress_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
crypto_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
cuckoocache_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
dbwrapper_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
denialofservice_tests.cpp net: Add missing cs_vNodes lock 2020-03-29 11:45:46 -04:00
descriptor_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
flatfile_tests.cpp
fs_tests.cpp
getarg_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
hash_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
interfaces_tests.cpp test: Verify findCommonAncestor always initializes outputs 2020-04-15 17:07:44 -04:00
key_io_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
key_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
limitedmap_tests.cpp
logging_tests.cpp
main.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
Makefile
mempool_tests.cpp
merkle_tests.cpp
merkleblock_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
miner_tests.cpp
multisig_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
net_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
netbase_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
pmt_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
policyestimator_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
pow_tests.cpp
prevector_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
raii_event_tests.cpp
random_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
README.md doc: Explain new test logging 2020-03-31 17:11:47 -04:00
reverselock_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
sanity_tests.cpp test: fix message for ECC_InitSanityCheck test 2020-04-30 16:57:46 +08:00
scheduler_tests.cpp test: Replace boost::mutex with std::mutex 2020-04-18 01:51:05 +03:00
script_p2sh_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
script_standard_tests.cpp
script_tests.cpp Merge #18612: script: Remove undocumented and unused operator+ 2020-04-22 14:17:01 +02:00
scriptnum10.h scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
scriptnum_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
serialize_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
settings_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
sighash_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
sigopcount_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
skiplist_tests.cpp
streams_tests.cpp
sync_tests.cpp
timedata_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
torcontrol_tests.cpp
transaction_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
txindex_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
txvalidation_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
txvalidationcache_tests.cpp Merge #18675: tests: Don't initialize PrecomputedTransactionData in txvalidationcache tests 2020-04-19 06:18:21 -04:00
uint256_tests.cpp test: Move boost/stdlib includes last 2020-04-17 06:36:04 -04:00
util_tests.cpp scripted-diff: Sort test includes 2020-04-16 13:32:36 -04:00
util_threadnames_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
validation_block_tests.cpp test: add test for witness commitment index 2020-04-29 11:20:31 +08:00
validation_chainstatemanager_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
validation_flush_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
validation_tests.cpp
validationinterface_tests.cpp Fix unregister_all_during_call cleanup 2020-04-08 10:11:46 -04:00
versionbits_tests.cpp scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00

Unit tests

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Bitcoin Core already uses Boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is set up to compile an executable called test_bitcoin that runs all of the unit tests. The main source file for the test library is found in util/setup_common.cpp.

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the unit tests manually, launch src/test/test_bitcoin. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the unit tests.

To add more unit tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the GUI unit tests manually, launch src/qt/test/test_bitcoin-qt

To add more GUI unit tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_bitcoin has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_bitcoin --log_level=all --run_test=getarg_tests -- DEBUG_LOG_OUT

log_level controls the verbosity of the test framework, which logs when a test case is entered, for example. The DEBUG_LOG_OUT after the two dashes redirects the debug log, which would normally go to a file in the test datadir (BasicTestingSetup::m_path_root), to the standard terminal output.

... or to run just the doubledash test:

test_bitcoin --run_test=getarg_tests/doubledash

Run test_bitcoin --help for the full list.

Adding test cases

To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, see uint256_tests.cpp.

Logging and debugging in unit tests

make check will write to a log file foo_tests.cpp.log and display this file on failure. For running individual tests verbosely, refer to the section above.

To write to logs from unit tests you need to use specific message methods provided by Boost. The simplest is BOOST_TEST_MESSAGE.

For debugging you can launch the test_bitcoin executable with gdbor lldb and start debugging, just like you would with any other program:

gdb src/test/test_bitcoin