dogecoin/test/functional
Wladimir J. van der Laan ccef10261e
Merge #18044: Use wtxid for transaction relay
0a4f1422cd Further improve comments around recentRejects (Suhas Daftuar)
0e20cfedb7 Disconnect peers sending wtxidrelay message after VERACK (Suhas Daftuar)
cacd85209e test: Use wtxid relay generally in functional tests (Fabian Jahr)
8d8099e97a test: Add tests for wtxid tx relay in segwit test (Fabian Jahr)
9a5392fdf6 test: Update test framework p2p protocol version to 70016 (Fabian Jahr)
dd78d1d641 Rename AddInventoryKnown() to AddKnownTx() (Suhas Daftuar)
4eb515574e Make TX_WITNESS_STRIPPED its own rejection reason (Suhas Daftuar)
97141ca442 Delay getdata requests from peers using txid-based relay (Suhas Daftuar)
46d78d47de Add p2p message "wtxidrelay" (Suhas Daftuar)
2d282e0cba ignore non-wtxidrelay compliant invs (Anthony Towns)
ac88e2eb61 Add support for tx-relay via wtxid (Suhas Daftuar)
8e68fc246d Add wtxids to recentRejects instead of txids (Suhas Daftuar)
144c385820 Add wtxids of confirmed transactions to bloom filter (Suhas Daftuar)
85c78d54af Add wtxid-index to orphan map (Suhas Daftuar)
08b39955ec Add a wtxid-index to mapRelay (Suhas Daftuar)
60f0acda71 Just pass a hash to AddInventoryKnown (Suhas Daftuar)
c7eb6b4f1f Add wtxid to mempool unbroadcast tracking (Amiti Uttarwar)
2b4b90aa8f Add a wtxid-index to the mempool (Suhas Daftuar)

Pull request description:

  Using txids (a transaction's hash, without witness) for transaction relay is problematic, post-segwit -- if a peer gives us a segwit transaction that fails policy checks, it could be because the txid associated with the transaction is definitely unacceptable to our node (regardless of the witness), or it could be that the transaction was malleated and with a different witness, the txid could be accepted to our mempool.

  We have a bloom filter of recently rejected transactions, whose purpose is to help us avoid redownloading and revalidating transactions that fail to be accepted, but because of this potential for witness malleability to interfere with relay of valid transactions, we do not use the filter for segwit transactions.  This issue is discussed at some length in #8279.  The effect of this is that whenever a segwit transaction that fails policy checks is relayed, a node would download that transaction from every peer announcing it, because it has no way presently to cache failure.  Historically this hasn't been a big problem, but if/when policy for accepting segwit transactions were to change (eg taproot, or any other change), we could expect older nodes talking to newer nodes to be wasting bandwidth because of this.

  As discussed in that issue, switching to wtxid-based relay solves this problem -- by using an identifier for a transaction that commits to all the data in our relay protocol, we can be certain if a transaction that a peer is announcing is one that we've already tried to process, or if it's something new.  This PR introduces support for wtxid-based relay with peers that support it (and remains backwards compatible with peers that use txids for relay, of course).

  Apart from code correctness, one issue to be aware of is that by downloading from old and new peers alike, we should expect there to be some bandwidth wasted, because sometimes we might download the same transaction via txid-relay as well as wtxid-relay.  The last commit in this PR implements a heuristic I want to analyze, which is to just delay relay from txid-relay peers by 2 seconds, if we have at least 1 wtxid-based peer.  I've just started running a couple nodes with this heuristic so I can measure how well it works, but I'm open to other ideas for minimizing that issue.  In the long run, I think this will be essentially a non-issue, so I don't think it's too big a concern, we just need to bite the bullet and deal with it during upgrade.

  Finally, this proposal would need a simple BIP describing the changes, which I haven't yet drafted.  However, review and testing of this code in the interim would be welcome.

  To do items:
  - [x] Write BIP explaining the spec here (1 new p2p message for negotiating wtxid-based relay, along with a new INV type)
  - [ ] Measure and evaluate a heuristic for minimizing how often a node downloads the same transaction twice, when connected to old and new nodes.

ACKs for top commit:
  naumenkogs:
    utACK 0a4f1422cd
  laanwj:
    utACK 0a4f1422cd

Tree-SHA512: d8eb8f0688cf0cbe9507bf738e143edab1f595551fdfeddc2b6734686ea26e7f156b6bfde38bad8bbbe8bec1857c7223e1687f8f018de7463dde8ecaa8f450df
2020-07-22 20:58:55 +02:00
..
data This PR adds initial support for type hints checking in python scripts. 2020-06-02 08:03:02 +02:00
test_framework Merge #18044: Use wtxid for transaction relay 2020-07-22 20:58:55 +02:00
.gitignore
combine_logs.py scripted-diff: Add missed copyright headers 2020-01-04 20:18:28 +02:00
combined_log_template.html
create_cache.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
example_test.py test: replace inv type magic numbers by constants 2020-05-07 14:34:55 +02:00
feature_abortnode.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_asmap.py init: move asmap code earlier in init process 2020-03-04 14:54:30 +01:00
feature_assumevalid.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_backwards_compatibility.py Remove previous_release.sh 2020-07-05 04:05:02 -04:00
feature_bip68_sequence.py net: Use mockable time for ping/pong, add tests 2020-06-19 07:25:36 -04:00
feature_block.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_blocksdir.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_cltv.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_config_args.py refactor: Fix unreachable code in init arg checks 2020-06-02 06:20:04 +10:00
feature_csv_activation.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_dbcrash.py test: Fix intermittent failure in feature_dbcrash 2020-05-19 18:57:09 -04:00
feature_dersig.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_fee_estimation.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_filelock.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_help.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
feature_includeconf.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_loadblock.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_logging.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_maxuploadtarget.py Merge #18638: net: Use mockable time for ping/pong, add tests 2020-07-10 16:06:28 +02:00
feature_minchainwork.py
feature_notifications.py test: Add missing sync_blocks 2020-06-16 15:05:05 -04:00
feature_nulldummy.py test: Check submitblock return values 2020-04-22 16:56:56 -04:00
feature_proxy.py
feature_pruning.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_rbf.py test: Remove unused, undocumented and misleading CScript.__add__ 2020-04-22 09:00:56 -04:00
feature_reindex.py test: Fix intermittent sync_blocks failures 2020-05-05 14:37:46 -04:00
feature_segwit.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
feature_shutdown.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_uacomment.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
feature_versionbits_warning.py
interface_bitcoin_cli.py rpc: add missing space in JSON parsing error message, update test 2020-06-02 08:50:57 +02:00
interface_http.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rest.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
interface_rpc.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
interface_zmq.py zmq: Fix due to invalid argument and multiple notifiers 2019-11-11 22:22:32 +00:00
mempool_accept.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
mempool_compatibility.py Remove previous_release.sh 2020-07-05 04:05:02 -04:00
mempool_expiry.py add: test that transactions expire from mempool 2020-02-19 10:03:48 +01:00
mempool_limit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mempool_package_onemore.py test: re-enable CLI test support by using EncodeDecimal in json.dumps() 2019-12-09 15:14:20 -05:00
mempool_packages.py test: Use wtxid relay generally in functional tests 2020-07-19 02:10:42 -04:00
mempool_persist.py [test] Manage node connections better in mempool persist test 2020-05-25 11:27:07 -07:00
mempool_reorg.py test: Remove raw-tx byte juggling in mempool_reorg 2020-04-25 19:36:02 -04:00
mempool_resurrect.py
mempool_spend_coinbase.py
mempool_unbroadcast.py [test] updates to unbroadcast test 2020-05-25 11:27:06 -07:00
mempool_updatefromblock.py test: Add mempool_updatefromblock.py 2020-04-24 18:18:34 +03:00
mining_basic.py test: Remove leftover comment in mining_basic 2020-06-08 08:10:37 -04:00
mining_getblocktemplate_longpoll.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
mining_prioritisetransaction.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
p2p_addr_relay.py net: update misbehavior logging for oversized messages 2020-06-19 14:14:16 +02:00
p2p_blockfilters.py [test] Add test for cfilters. 2020-05-26 17:38:26 -04:00
p2p_blocksonly.py test: Use wtxid relay generally in functional tests 2020-07-19 02:10:42 -04:00
p2p_compactblocks.py [tests] Only acquire lock once in p2p_compactblocks.py 2020-06-05 10:57:13 -04:00
p2p_disconnect_ban.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
p2p_dos_header_tree.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_eviction.py Add functional test for P2P eviction logic of inbound peers 2020-06-06 22:30:29 +02:00
p2p_feefilter.py test: Use wtxid relay generally in functional tests 2020-07-19 02:10:42 -04:00
p2p_filter.py [test] logging and style followups for bloomfilter tests 2020-06-16 08:23:12 -07:00
p2p_fingerprint.py test: replace inv type magic numbers by constants 2020-05-07 14:34:55 +02:00
p2p_getdata.py test: Remove global wait_until from p2p_getdata 2020-05-23 10:01:10 -04:00
p2p_ibd_txrelay.py test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until 2020-07-19 13:37:54 +02:00
p2p_invalid_block.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_invalid_locator.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_invalid_messages.py test: hoist p2p values to test framework constants 2020-06-19 14:14:35 +02:00
p2p_invalid_tx.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_leak.py test: update tests for peer discouragement 2020-07-14 14:15:01 +02:00
p2p_leak_tx.py test: replace inv type magic numbers by constants 2020-05-07 14:34:55 +02:00
p2p_nobloomfilter_messages.py [test] logging and style followups for bloomfilter tests 2020-06-16 08:23:12 -07:00
p2p_node_network_limited.py [refactor] use waiting inside disconnect_p2ps 2020-06-16 08:28:55 -07:00
p2p_permissions.py doc: Use precise permission flags where possible 2020-07-10 15:37:42 +02:00
p2p_ping.py net: Use mockable time for ping/pong, add tests 2020-06-19 07:25:36 -04:00
p2p_segwit.py test: Use wtxid relay generally in functional tests 2020-07-19 02:10:42 -04:00
p2p_sendheaders.py test: replace inv type magic numbers by constants 2020-05-07 14:34:55 +02:00
p2p_timeouts.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
p2p_tx_download.py test: Use wtxid relay generally in functional tests 2020-07-19 02:10:42 -04:00
p2p_unrequested_blocks.py doc: Use precise permission flags where possible 2020-07-10 15:37:42 +02:00
README.md This PR adds initial support for type hints checking in python scripts. 2020-06-02 08:03:02 +02:00
rpc_bind.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_blockchain.py test: Test gettxouttsetinfo hash_type option 2020-06-22 01:55:41 +02:00
rpc_createmultisig.py [tests] move generate_wif_key to wallet_util.py 2020-06-10 12:10:02 -04:00
rpc_decodescript.py
rpc_deprecated.py
rpc_deriveaddresses.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
rpc_dumptxoutset.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_estimatefee.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_fundrawtransaction.py Merge #16377: [rpc] don't automatically append inputs in walletcreatefundedpsbt 2020-06-21 20:52:34 +12:00
rpc_generateblock.py rpc: Document all aliases for second arg of getblock 2020-04-16 08:45:05 -04:00
rpc_getblockfilter.py test: move sync_blocks and sync_mempool functions to test_framework.py 2020-06-18 13:32:36 -04:00
rpc_getblockstats.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_getchaintips.py
rpc_getdescriptorinfo.py qa: Add getdescriptorinfo functional test 2020-03-10 08:14:04 +00:00
rpc_getpeerinfo_banscore_deprecation.py test: getpeerinfo banscore deprecation test 2020-07-08 13:14:50 +02:00
rpc_help.py wallet: Make RPC help compile-time static 2020-06-11 12:38:36 -04:00
rpc_invalidateblock.py rpc: Add generatetodescriptor 2019-10-30 10:01:32 -04:00
rpc_misc.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_named_arguments.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_net.py net: Avoid wasting inv traffic during IBD 2020-06-19 09:27:30 -04:00
rpc_preciousblock.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
rpc_psbt.py tests: Check that segwit inputs in psbt have both UTXO types 2020-06-24 16:32:20 -04:00
rpc_rawtransaction.py Merge #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv 2020-07-16 21:38:09 +02:00
rpc_scantxoutset.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_setban.py bump test timeouts so that functional tests run in valgrind 2020-01-25 15:51:35 +08:00
rpc_signmessage.py
rpc_signrawtransaction.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
rpc_txoutproof.py scripted-diff: Bump copyright of files changed in 2019 2019-12-30 10:42:20 +13:00
rpc_uptime.py
rpc_users.py http: Avoid crash when g_thread_http was never started 2020-05-19 10:41:44 -04:00
rpc_whitelist.py test: Change filemode of rpc_whitelist.py 2019-12-27 21:19:44 +01:00
test-shell.md TestShell: Return self from setup() 2019-11-05 12:55:52 +01:00
test_runner.py Merge #19423: test: add functional test for txrelay during and after IBD 2020-07-17 07:51:24 +02:00
tool_wallet.py walletdb: Combine VerifyDatabaseFile and VerifyEnvironment 2020-07-01 12:32:03 -04:00
wallet_abandonconflict.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
wallet_address_types.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_avoidreuse.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
wallet_backup.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_balance.py test: move sync_blocks and sync_mempool functions to test_framework.py 2020-06-18 13:32:36 -04:00
wallet_basic.py Merge #18202: refactor: consolidate sendmany and sendtoaddress code 2020-07-12 14:42:35 +12:00
wallet_bumpfee.py tests for bumpfee / estimate_modes 2020-06-24 16:01:38 +09:00
wallet_coinbase_category.py
wallet_create_tx.py
wallet_createwallet.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_descriptor.py tests: Add RPCOverloadWrapper which overloads some disabled RPCs 2020-04-23 13:59:48 -04:00
wallet_disable.py
wallet_dump.py test: Add smoke test to check that wallets are flushed by default 2020-07-09 13:07:17 +02:00
wallet_encryption.py test: Fix intermittent failure in wallet_encryption 2020-07-01 20:08:04 -04:00
wallet_fallbackfee.py [rpc] refactor: consolidate sendmany and sendtoaddress code 2020-06-19 11:17:06 +02:00
wallet_groups.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_hd.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
wallet_implicitsegwit.py tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 2019-12-06 14:40:28 +00:00
wallet_import_rescan.py test: Bump timeout in wallet_import_rescan 2020-04-17 17:09:27 -04:00
wallet_import_with_label.py Merge #17585: rpc: deprecate getaddressinfo label 2020-02-02 21:35:46 +13:00
wallet_importdescriptors.py walletdb: don't reinitialize desc cache with multiple cache entries 2020-07-03 21:15:09 -04:00
wallet_importmulti.py test: Fix intermittent failure in wallet_importmulti 2020-04-23 19:01:26 -04:00
wallet_importprunedfunds.py
wallet_keypool.py Add a --descriptors option to various tests 2020-04-23 13:59:48 -04:00
wallet_keypool_topup.py Add a --descriptors option to various tests 2020-04-23 13:59:48 -04:00
wallet_labels.py test: Check that invalid witness destinations can not be imported 2020-05-14 09:36:51 -04:00
wallet_listreceivedby.py test: remove getaddressinfo label tests 2020-01-09 17:30:58 +01:00
wallet_listsinceblock.py test: listsinceblock block height checks 2020-03-24 16:44:26 +01:00
wallet_listtransactions.py rpc: Document all aliases for first arg of listtransactions 2020-04-16 08:45:33 -04:00
wallet_multiwallet.py qa: Test concurrent wallet loading 2020-06-19 02:09:26 +01:00
wallet_reorgsrestore.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00
wallet_resendwallettransactions.py [test] Test that wallet transactions aren't rebroadcast before 12 hours 2020-05-25 11:27:06 -07:00
wallet_txn_clone.py test: remove redundant two-way disconnect_nodes calls 2020-05-07 10:32:01 -07:00
wallet_txn_doublespend.py test: remove redundant two-way disconnect_nodes calls 2020-05-07 10:32:01 -07:00
wallet_upgradewallet.py Remove previous_release.sh 2020-07-05 04:05:02 -04:00
wallet_watchonly.py tests: Use a default of supports_cli=True (instead of supports_cli=False) 2019-12-06 15:24:06 +00:00
wallet_zapwallettxes.py test: refactor functional tests to use restart_node 2020-06-22 12:58:14 +01:00

Functional tests

Writing Functional Tests

Example test

The file test/functional/example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test/functional/test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Use type hints in your code to improve code readability and to detect possible bugs earlier.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramework, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • tool for tests for tools, eg tool_wallet.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • Use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Instead of inline comments or no test documentation at all, log the comments to the test log, e.g. self.log.info('Create enough transactions to fill a block'). Logs make the test code easier to read and the test logic easier to debug.
  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x50=1250 BTC) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a bitcoind. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

Prototyping tests

The TestShell class exposes the BitcoinTestFramework functionality to interactive Python3 environments and can be used to prototype tests. This may be especially useful in a REPL environment with session logging utilities, such as IPython. The logs of such interactive sessions can later be adapted into permanent test cases.

Test framework modules

The following are useful modules for test developers. They are located in test/functional/test_framework/.

authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework.py

Base class for functional tests.

util.py

Generally useful functions.

mininode.py

Basic code to support P2P connectivity to a bitcoind.

script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

key.py

Test-only secp256k1 elliptic curve implementation

blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: