maxmustermann/dogecoin
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
dogecoin/test/functional/test_framework
History
MarcoFalke d2882a012b
Merge #18610: scripted-diff: test: replace command with msgtype (naming) 
9df32e820d scripted-diff: test: replace command with msgtype (Sebastian Falbesoner)

Pull request description:

  This is a follow-up PR to https://github.com/bitcoin/bitcoin/pull/18533, which changed the naming of `strCommand` to `msg_type` in the network processing code. The same approach is done here for the function test framework, to get rid of the wrong "command" terminology for network mesage types. (Commands are usually used in the CLI or RPC context, so using the same name in the network message context would only be confusing.)

  The commit was created through the following steps:
  1. search for all occurences of the string "command" within the folder `test/functional`
  ```git grep -i command test/functional > command_finds```
  2. manually sort out all false-positives, i.e. occurences of "command" which describe commands in the correct sense (mostly CLI or RPC related, also some with Socks5)
  3. put the remaining occurences into a scripted-diff (a quite simple one, actually) that renames "command" to "msgtype" in the concerned files.

  The name `msgtype` was intentionally chosen without the underscore `_` as classes beginning with `msg_` define concrete types of messages.

ACKs for top commit:
  MarcoFalke:
    ACK 9df32e820d . Makes sense that tests use the same naming as Bitcoin Core. See `NetMsgType` here: https://doxygen.bitcoincore.org/namespace_net_msg_type.html

Tree-SHA512: cd0ee08a382910b7f10ce583acdaf4f8a39f9ba4a22434a914415727eedd98bac538de9bf6633574d5eb86f62558bc8dcb638a3289d99b04f8481f34e7a9a0c7
2020-04-19 09:18:21 -04:00
..
__init__.py
address.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
authproxy.py test: Try once more when RPC connection fails on Windows 2020-04-12 09:04:15 -04:00
blocktools.py test: Properly serialize BIP34 coinbase height 2019-07-09 14:12:33 -04:00
coverage.py
descriptors.py Output a descriptor in createmultisig and addmultisigaddress 2020-01-30 23:55:36 -05:00
key.py Add comments to Python ECDSA implementation 2019-04-18 13:23:26 -07:00
messages.py Merge #18610: scripted-diff: test: replace command with msgtype (naming) 2020-04-19 09:18:21 -04:00
mininode.py Merge #18610: scripted-diff: test: replace command with msgtype (naming) 2020-04-19 09:18:21 -04:00
netutil.py
script.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
script_util.py test: fix "tx-size-small" errors after default address change 2019-10-14 15:03:11 +02:00
segwit_addr.py
siphash.py
socks5.py
test_framework.py test: Create cached blocks not in the future 2020-04-14 21:04:36 -04:00
test_node.py Merge #18633: test: Properly raise FailedToStartError when rpc shutdown before warmup finished (take 2) 2020-04-19 06:10:06 -04:00
test_shell.py TestShell: Return self from setup() 2019-11-05 12:55:52 +01:00
util.py scripted-diff: Bump copyright headers 2020-04-16 13:33:09 -04:00
wallet_util.py scripted-diff: Bump copyright of files changed in 2020 2020-01-15 02:18:00 +07:00