28f788e47e
7148b74dc[tests] Functional tests must explicitly set num_nodes (John Newbery)5448a1471[tests] don't override __init__() in individual tests (John Newbery)6cf094a02[tests] Avoid passing around member variables in test_framework (John Newbery)36b626867[tests] TestNode: separate add_node from start_node (John Newbery)be2a2ab6a[tests] fix - use rpc_timeout as rpc timeout (John Newbery) Pull request description: Some additional tidyups after the introduction of TestNode: - commit 1 makes TestNode use the correct rpc timeout. This should have been included in #11077 - commit 2 separates `add_node()` from `start_node()` as originally discussed here: https://github.com/bitcoin/bitcoin/pull/10556#discussion_r121161453 with @kallewoof . The test writer no longer needs to assign to `self.nodes` when starting/stopping nodes. - commit 3 adds a `set_test_params()` method, so individual tests don't need to override `__init__()` and call `super().__init__()` Tree-SHA512: 0adb030623b96675b5c29e2890ce99ccd837ed05f721d0c91b35378c5ac01b6658174aac12f1f77402e1d38b61f39b3c43b4df85c96952565dde1cda05b0db84
115 lines
5 KiB
Python
Executable file
115 lines
5 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2015-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the preciousblock RPC."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
connect_nodes_bi,
|
|
sync_chain,
|
|
sync_blocks,
|
|
)
|
|
|
|
def unidirectional_node_sync_via_rpc(node_src, node_dest):
|
|
blocks_to_copy = []
|
|
blockhash = node_src.getbestblockhash()
|
|
while True:
|
|
try:
|
|
assert(len(node_dest.getblock(blockhash, False)) > 0)
|
|
break
|
|
except:
|
|
blocks_to_copy.append(blockhash)
|
|
blockhash = node_src.getblockheader(blockhash, True)['previousblockhash']
|
|
blocks_to_copy.reverse()
|
|
for blockhash in blocks_to_copy:
|
|
blockdata = node_src.getblock(blockhash, False)
|
|
assert(node_dest.submitblock(blockdata) in (None, 'inconclusive'))
|
|
|
|
def node_sync_via_rpc(nodes):
|
|
for node_src in nodes:
|
|
for node_dest in nodes:
|
|
if node_src is node_dest:
|
|
continue
|
|
unidirectional_node_sync_via_rpc(node_src, node_dest)
|
|
|
|
class PreciousTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
def setup_network(self):
|
|
self.setup_nodes()
|
|
|
|
def run_test(self):
|
|
self.log.info("Ensure submitblock can in principle reorg to a competing chain")
|
|
self.nodes[0].generate(1)
|
|
assert_equal(self.nodes[0].getblockcount(), 1)
|
|
hashZ = self.nodes[1].generate(2)[-1]
|
|
assert_equal(self.nodes[1].getblockcount(), 2)
|
|
node_sync_via_rpc(self.nodes[0:3])
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashZ)
|
|
|
|
self.log.info("Mine blocks A-B-C on Node 0")
|
|
hashC = self.nodes[0].generate(3)[-1]
|
|
assert_equal(self.nodes[0].getblockcount(), 5)
|
|
self.log.info("Mine competing blocks E-F-G on Node 1")
|
|
hashG = self.nodes[1].generate(3)[-1]
|
|
assert_equal(self.nodes[1].getblockcount(), 5)
|
|
assert(hashC != hashG)
|
|
self.log.info("Connect nodes and check no reorg occurs")
|
|
# Submit competing blocks via RPC so any reorg should occur before we proceed (no way to wait on inaction for p2p sync)
|
|
node_sync_via_rpc(self.nodes[0:2])
|
|
connect_nodes_bi(self.nodes,0,1)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block G")
|
|
self.nodes[0].preciousblock(hashG)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block C again")
|
|
self.nodes[0].preciousblock(hashC)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashC)
|
|
self.log.info("Make Node1 prefer block C")
|
|
self.nodes[1].preciousblock(hashC)
|
|
sync_chain(self.nodes[0:2]) # wait because node 1 may not have downloaded hashC
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashC)
|
|
self.log.info("Make Node1 prefer block G again")
|
|
self.nodes[1].preciousblock(hashG)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block G again")
|
|
self.nodes[0].preciousblock(hashG)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashG)
|
|
self.log.info("Make Node1 prefer block C again")
|
|
self.nodes[1].preciousblock(hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashC)
|
|
self.log.info("Mine another block (E-F-G-)H on Node 0 and reorg Node 1")
|
|
self.nodes[0].generate(1)
|
|
assert_equal(self.nodes[0].getblockcount(), 6)
|
|
sync_blocks(self.nodes[0:2])
|
|
hashH = self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
self.log.info("Node1 should not be able to prefer block C anymore")
|
|
self.nodes[1].preciousblock(hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
self.log.info("Mine competing blocks I-J-K-L on Node 2")
|
|
self.nodes[2].generate(4)
|
|
assert_equal(self.nodes[2].getblockcount(), 6)
|
|
hashL = self.nodes[2].getbestblockhash()
|
|
self.log.info("Connect nodes and check no reorg occurs")
|
|
node_sync_via_rpc(self.nodes[1:3])
|
|
connect_nodes_bi(self.nodes,1,2)
|
|
connect_nodes_bi(self.nodes,0,2)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashH)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
assert_equal(self.nodes[2].getbestblockhash(), hashL)
|
|
self.log.info("Make Node1 prefer block L")
|
|
self.nodes[1].preciousblock(hashL)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashL)
|
|
self.log.info("Make Node2 prefer block H")
|
|
self.nodes[2].preciousblock(hashH)
|
|
assert_equal(self.nodes[2].getbestblockhash(), hashH)
|
|
|
|
if __name__ == '__main__':
|
|
PreciousTest().main()
|