f09bc7ec98
c1dde3a949No longer shutdown after encrypting the wallet (Andrew Chow)d7637c5a3fAfter encrypting the wallet, reload the database environment (Andrew Chow)5d296ac810Add function to close all Db's and reload the databae environment (Andrew Chow)a769461d5eMove BerkeleyEnvironment deletion from internal method to callsite (Andrew Chow) Pull request description: This is the replacement for #11678 which implements @ryanofsky's [suggestion](https://github.com/bitcoin/bitcoin/pull/11678#pullrequestreview-76464511). Shutting down the software was to prevent the BDB environment from writing unencrypted private keys to disk in the database log files, as was noted [here](https://bitcointalk.org/index.php?topic=51474.msg616068#msg616068). This PR replaces the shutdown behavior with a CDBEnv flush, close, and reopen which achieves the same effect: everything is cleanly flushed and closed, the log files are removed, and then the environment reopened to continue normal operation. To ensure that no unencrypted private keys are in the log files after encrypting the wallet, I wrote [this script](https://gist.github.com/achow101/7f7143e6c3d3fdc034d3470e72823e9d) to pull private keys from the original wallet file and searches for these keys in the log files (note that you will have to change your file paths to make it work on your own machine). As for concerns about private keys being written to slack space or being kept in memory, these behaviors no longer exist after the original wallet encryption PR and the shutting down solution from 2011. cc @ryanofsky Tree-SHA512: 34b894283b0677a873d06dee46dff8424dec85a2973009ac9b84bcf3d22d05f227c494168c395219d9aee3178e420cf70d4b3eeacc9785aa86b6015d25758e75
84 lines
3.5 KiB
Python
Executable file
84 lines
3.5 KiB
Python
Executable file
#!/usr/bin/env python3
|
|
# Copyright (c) 2016-2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test Wallet encryption"""
|
|
|
|
import time
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
assert_greater_than,
|
|
assert_greater_than_or_equal,
|
|
)
|
|
|
|
class WalletEncryptionTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
passphrase = "WalletPassphrase"
|
|
passphrase2 = "SecondWalletPassphrase"
|
|
|
|
# Make sure the wallet isn't encrypted first
|
|
address = self.nodes[0].getnewaddress()
|
|
privkey = self.nodes[0].dumpprivkey(address)
|
|
assert_equal(privkey[:1], "c")
|
|
assert_equal(len(privkey), 52)
|
|
|
|
# Encrypt the wallet
|
|
self.nodes[0].encryptwallet(passphrase)
|
|
|
|
# Test that the wallet is encrypted
|
|
assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)
|
|
|
|
# Check that walletpassphrase works
|
|
self.nodes[0].walletpassphrase(passphrase, 2)
|
|
assert_equal(privkey, self.nodes[0].dumpprivkey(address))
|
|
|
|
# Check that the timeout is right
|
|
time.sleep(2)
|
|
assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)
|
|
|
|
# Test wrong passphrase
|
|
assert_raises_rpc_error(-14, "wallet passphrase entered was incorrect", self.nodes[0].walletpassphrase, passphrase + "wrong", 10)
|
|
|
|
# Test walletlock
|
|
self.nodes[0].walletpassphrase(passphrase, 84600)
|
|
assert_equal(privkey, self.nodes[0].dumpprivkey(address))
|
|
self.nodes[0].walletlock()
|
|
assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)
|
|
|
|
# Test passphrase changes
|
|
self.nodes[0].walletpassphrasechange(passphrase, passphrase2)
|
|
assert_raises_rpc_error(-14, "wallet passphrase entered was incorrect", self.nodes[0].walletpassphrase, passphrase, 10)
|
|
self.nodes[0].walletpassphrase(passphrase2, 10)
|
|
assert_equal(privkey, self.nodes[0].dumpprivkey(address))
|
|
self.nodes[0].walletlock()
|
|
|
|
# Test timeout bounds
|
|
assert_raises_rpc_error(-8, "Timeout cannot be negative.", self.nodes[0].walletpassphrase, passphrase2, -10)
|
|
# Check the timeout
|
|
# Check a time less than the limit
|
|
MAX_VALUE = 100000000
|
|
expected_time = int(time.time()) + MAX_VALUE - 600
|
|
self.nodes[0].walletpassphrase(passphrase2, MAX_VALUE - 600)
|
|
actual_time = self.nodes[0].getwalletinfo()['unlocked_until']
|
|
assert_greater_than_or_equal(actual_time, expected_time)
|
|
assert_greater_than(expected_time + 5, actual_time) # 5 second buffer
|
|
# Check a time greater than the limit
|
|
expected_time = int(time.time()) + MAX_VALUE - 1
|
|
self.nodes[0].walletpassphrase(passphrase2, MAX_VALUE + 1000)
|
|
actual_time = self.nodes[0].getwalletinfo()['unlocked_until']
|
|
assert_greater_than_or_equal(actual_time, expected_time)
|
|
assert_greater_than(expected_time + 5, actual_time) # 5 second buffer
|
|
|
|
if __name__ == '__main__':
|
|
WalletEncryptionTest().main()
|