From d617260e8285316ac30167d5907844d300149445 Mon Sep 17 00:00:00 2001 From: Rainer Sigwald Date: Mon, 30 Sep 2019 17:23:26 -0500 Subject: [PATCH] Remove resx-in-subfolder known issue (#3471) * Remove resx-in-subfolder known issue This was resolved before RTW by microsoft/msbuild#4702. * Mark preview issue as resolved --- release-notes/3.0/3.0-known-issues.md | 6 ------ release-notes/3.0/preview/3.0.0-preview-known-issues.md | 4 +++- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/release-notes/3.0/3.0-known-issues.md b/release-notes/3.0/3.0-known-issues.md index 48a8a9ce..0967c97e 100644 --- a/release-notes/3.0/3.0-known-issues.md +++ b/release-notes/3.0/3.0-known-issues.md @@ -42,12 +42,6 @@ This document lists known issues for **.NET Core 3.0 GA and beyond releases** wh ``` -- **Builds fail with `MSB3041` when a `.resx` file is in a subfolder [microsoft/msbuild#4695](https://github.com/microsoft/msbuild/issues/4695)** - - MSBuild incorrectly constructs paths to `DependentUpon` source files related to `.resx` files that aren't at the project root. There is a workaround: - - Explicitly set `DependentUpon` metadata for resource files ([example for Entity Framework migrations](https://github.com/aspnet/EntityFramework6/issues/1225#issuecomment-528571274)). - ### Preview 5 - **Visual style in WinForms app not showing correctly when publishing with PublishReadyToRun=true** diff --git a/release-notes/3.0/preview/3.0.0-preview-known-issues.md b/release-notes/3.0/preview/3.0.0-preview-known-issues.md index 0b6b34f9..bb24744c 100644 --- a/release-notes/3.0/preview/3.0.0-preview-known-issues.md +++ b/release-notes/3.0/preview/3.0.0-preview-known-issues.md @@ -19,7 +19,7 @@ This document lists known issues for **.NET Core 3.0 Preview releases** which ma ### Preview 9 -- **Misnamed or colliding non-resx resources ([microsoft/msbuild#4740](https://github.com/microsoft/msbuild/issues/4740))** +- **[RESOLVED] Misnamed or colliding non-resx resources ([microsoft/msbuild#4740](https://github.com/microsoft/msbuild/issues/4740))** Projects that specify non-resx `EmbeddedResource`s may have the resources embedded under an incorrect name (causing code that uses the correct name to fail at runtime). If two or more files are embedded in this way, `CS1508: The resource identifier ... has already been used in this assembly` may be issued at build time. @@ -31,6 +31,8 @@ This document lists known issues for **.NET Core 3.0 Preview releases** which ma false ``` + + Resolved in the final `3.0.100` SDK. - **Builds fail with `MSB3041` when a `.resx` file is in a subfolder [microsoft/msbuild#4695](https://github.com/microsoft/msbuild/issues/4695)**