- This change aims to reduce the feedback time when resolving failed
tests for a Merge Request
- The setup jobs will detect the previous test files associated with
failed jobs in the test stage of the previous pipeline
- The test stage jobs will execute a rerun based on those detected
test files
- This change aims to reduce the feedback time when resolving failed
tests for a Merge Request
- The setup jobs will detect the previous test files associated with
failed jobs in the test stage of the previous pipeline
- The test stage jobs will execute a rerun based on those detected
test files
The main sticking point was `config/README.md`, which went into a lot of
detail about each instance. It was quite easy to make a copy and paste
error, as some instances had default URLs and others didn't, some had
fallback instances and others didn't, etc.
This changes a number of things:
1. `config/README.md` now has a table for the Redis instances with a
single list of instructions that apply to all instances.
2. There are now specs to ensure that each Redis instance has a default
URL set when no Redis config at all is present.
3. Instances that use a fallback instance for config will automatically
use the default URL of their fallback instance. They should not
define their own default URL.
4. The `.gitignore` file does not need to be updated for each new Redis
instance.
5. The example config files are now gone as `request.yml.example` should
be sufficient.
This instance is not used yet, but will soon be used for rate limiting
via Rack::Attack and Gitlab::ApplicationRateLimiter. Having this
configuration option in place will allow us to build on that, and also
create merge requests to support this option in Omnibus and our Helm
charts.
- This adds a configuration file for Lefthook which is more flexible
and powerful than Overcommit.
- The only downside is that if gather the diff between `origin/master`
and `HEAD` so if you didn't fetch `origin/master` for a long time,
the checks might be done on more files than the one that you updated.
- Also, that means you need a origin remote.
Signed-off-by: Rémy Coutable <remy@rymai.me>
- Configure rspec with Crystalball using custom CoverageLinesStrategy
for compatibility with SimpleCov on Ruby >= 2.5
- Running rspec with `CRYSTALBALL=true` generates crystalball data
in `crystalball/*.yml` containing files covered by each rspec example
In this commit we add a small functionality to generate the sitemap
for the `gitlab-org` group just in the .com environment.
The idea behind this is to analyze whether a broader sitemap
would improve the search crawling results.
Remove db/schema_migration files from .gitignore for old migrations that
exist on legacy installations but no longer have a corresponding
migration in the codebase. Due to changes in how the schema_migration
files are created, these files no longer need to be ignored.
This ensures only gitlab-kas can make requests to the internal API,
which is necessary as sensitive info is returned in response.
Update instances where we explicitly want to use the top-level
::Clusters module
asdf-vm uses a different file to other managers, this adds
.tool-versions to the ignore list, which is a file needed to manage the
Ruby version locally to this project.
This job runs in gitlab MR pipelines when
the pipeline is a pipeline for merged result.
It runs as if foss, without ee/ directory.
It detects ruby foss files changed and runs matching
rspec test files to detect any EE dependency
that might exist in FOSS.
`ee/lib/tasks/gitlab/license.rake` tries to load
`Settings.source.dirname + 'Gitlab.gitlab-license'` which expands to
`config/Gitlab.gitlab-license` for a default GDK installation.
This file should be ignored so developers can put their license files
and not worry about commiting the file.
Running Overcommit outside of the context of a Gemfile can lead to
conflicts when requiring gems. Using a dedicated Gemfile instead of the
default one avoids loading all the app's gems before running Overcommit.
Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add documentation for public methods
* Remove pointless duplicated method call
* Be more specific about ignored file
* Improvements to equality tests
Requested by reviewer
Also adds necessary page objects and element selectors
and stablizes existing group_saml specs
Also adds /qa/.rakeTasks generated for Ruby mine to gitignore
