From 1722d0cc12552aa58723216e2338a19ce36d5fe5 Mon Sep 17 00:00:00 2001 From: Haoyu Qiu Date: Wed, 29 Sep 2021 13:52:40 +0800 Subject: [PATCH] Fix LineEdit undo crash Make sure all related member variables are initialized before creating the first undo state. (cherry picked from commit eab1e228c8a2e6e49bb02bdde2d4511ca72e5e2e) --- scene/gui/line_edit.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scene/gui/line_edit.cpp b/scene/gui/line_edit.cpp index 20fbac27ea..a5c9f675ba 100644 --- a/scene/gui/line_edit.cpp +++ b/scene/gui/line_edit.cpp @@ -1919,9 +1919,6 @@ void LineEdit::_bind_methods() { } LineEdit::LineEdit() { - - undo_stack_pos = NULL; - _create_undo_state(); align = ALIGN_LEFT; cached_width = 0; cached_placeholder_width = 0; @@ -1939,6 +1936,9 @@ LineEdit::LineEdit() { shortcut_keys_enabled = true; selecting_enabled = true; + undo_stack_pos = nullptr; + _create_undo_state(); + deselect(); set_focus_mode(FOCUS_ALL); set_default_cursor_shape(CURSOR_IBEAM);