From 18a73153812d4f9be82ec30eafdb8961c625c97b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Fri, 18 Aug 2017 22:29:15 +0200 Subject: [PATCH] Rename localization method to `tr` again Partial revert of #10380 based on contributor ~~bullying~~ feedback. --- core/object.cpp | 8 ++++---- core/object.h | 4 ++-- doc/base/classes.xml | 22 +++++++++++----------- scene/gui/button.cpp | 4 ++-- scene/gui/dialogs.cpp | 2 +- scene/gui/file_dialog.cpp | 2 +- scene/gui/label.cpp | 4 ++-- scene/gui/line_edit.cpp | 2 +- scene/gui/popup_menu.cpp | 18 +++++++++--------- scene/gui/tab_container.cpp | 4 ++-- 10 files changed, 35 insertions(+), 35 deletions(-) diff --git a/core/object.cpp b/core/object.cpp index 3cfd74a448..06c2603b74 100644 --- a/core/object.cpp +++ b/core/object.cpp @@ -1560,7 +1560,7 @@ void Object::initialize_class() { initialized = true; } -StringName Object::localize(const StringName &p_message) const { +StringName Object::tr(const StringName &p_message) const { if (!_can_translate || !TranslationServer::get_singleton()) return p_message; @@ -1707,11 +1707,11 @@ void Object::_bind_methods() { ClassDB::bind_method(D_METHOD("set_block_signals", "enable"), &Object::set_block_signals); ClassDB::bind_method(D_METHOD("is_blocking_signals"), &Object::is_blocking_signals); - ClassDB::bind_method(D_METHOD("set_message_localization", "enable"), &Object::set_message_localization); - ClassDB::bind_method(D_METHOD("can_translate_messages"), &Object::can_translate_messages); ClassDB::bind_method(D_METHOD("property_list_changed_notify"), &Object::property_list_changed_notify); - ClassDB::bind_method(D_METHOD("localize", "message"), &Object::localize); + ClassDB::bind_method(D_METHOD("set_message_translation", "enable"), &Object::set_message_translation); + ClassDB::bind_method(D_METHOD("can_translate_messages"), &Object::can_translate_messages); + ClassDB::bind_method(D_METHOD("tr", "message"), &Object::tr); ClassDB::bind_method(D_METHOD("is_queued_for_deletion"), &Object::is_queued_for_deletion); diff --git a/core/object.h b/core/object.h index b694876505..8a858b5b00 100644 --- a/core/object.h +++ b/core/object.h @@ -679,12 +679,12 @@ public: virtual void get_argument_options(const StringName &p_function, int p_idx, List *r_options) const; - StringName localize(const StringName &p_message) const; //translate message (internationalization) + StringName tr(const StringName &p_message) const; // translate message (internationalization) bool _is_queued_for_deletion; // set to true by SceneTree::queue_delete() bool is_queued_for_deletion() const; - _FORCE_INLINE_ void set_message_localization(bool p_enable) { _can_translate = p_enable; } + _FORCE_INLINE_ void set_message_translation(bool p_enable) { _can_translate = p_enable; } _FORCE_INLINE_ bool can_translate_messages() const { return _can_translate; } #ifdef TOOLS_ENABLED diff --git a/doc/base/classes.xml b/doc/base/classes.xml index 418739aa3d..f21fa2c7c0 100644 --- a/doc/base/classes.xml +++ b/doc/base/classes.xml @@ -28259,15 +28259,6 @@ - - - - - - - Localize (translate) a message. Only works if message localization is enabled (which it is by default). See [method set_message_localization]. - - @@ -28297,11 +28288,11 @@ If set to true, signal emission is blocked. - + - Define whether this object can localize strings (with calls to [code]localize[/code]). Default is true. + Define whether this object can translate strings (with calls to [method tr]). Default is true. @@ -28320,6 +28311,15 @@ Set a script into the object, scripts extend the object functionality. + + + + + + + Translate a message. Only works if message translation is enabled (which it is by default). See [method set_message_translation]. + + diff --git a/scene/gui/button.cpp b/scene/gui/button.cpp index e2c9f5ecb4..5036e4f7f6 100644 --- a/scene/gui/button.cpp +++ b/scene/gui/button.cpp @@ -59,7 +59,7 @@ void Button::_notification(int p_what) { if (p_what == NOTIFICATION_TRANSLATION_CHANGED) { - xl_text = localize(text); + xl_text = tr(text); minimum_size_changed(); update(); } @@ -172,7 +172,7 @@ void Button::set_text(const String &p_text) { if (text == p_text) return; text = p_text; - xl_text = localize(p_text); + xl_text = tr(p_text); update(); _change_notify("text"); minimum_size_changed(); diff --git a/scene/gui/dialogs.cpp b/scene/gui/dialogs.cpp index d5872d92ec..ef8b0adfa9 100644 --- a/scene/gui/dialogs.cpp +++ b/scene/gui/dialogs.cpp @@ -271,7 +271,7 @@ int WindowDialog::_drag_hit_test(const Point2 &pos) const { void WindowDialog::set_title(const String &p_title) { - title = localize(p_title); + title = tr(p_title); update(); } String WindowDialog::get_title() const { diff --git a/scene/gui/file_dialog.cpp b/scene/gui/file_dialog.cpp index 197683b825..b3530c2971 100644 --- a/scene/gui/file_dialog.cpp +++ b/scene/gui/file_dialog.cpp @@ -464,7 +464,7 @@ void FileDialog::update_filters() { String flt = filters[i].get_slice(";", 0).strip_edges(); String desc = filters[i].get_slice(";", 1).strip_edges(); if (desc.length()) - filter->add_item(String(localize(desc)) + " ( " + flt + " )"); + filter->add_item(String(tr(desc)) + " ( " + flt + " )"); else filter->add_item("( " + flt + " )"); } diff --git a/scene/gui/label.cpp b/scene/gui/label.cpp index 758aafd115..b2afca8766 100644 --- a/scene/gui/label.cpp +++ b/scene/gui/label.cpp @@ -63,7 +63,7 @@ void Label::_notification(int p_what) { if (p_what == NOTIFICATION_TRANSLATION_CHANGED) { - String new_text = localize(text); + String new_text = tr(text); if (new_text == xl_text) return; //nothing new xl_text = new_text; @@ -526,7 +526,7 @@ void Label::set_text(const String &p_string) { if (text == p_string) return; text = p_string; - xl_text = localize(p_string); + xl_text = tr(p_string); word_cache_dirty = true; if (percent_visible < 1) visible_chars = get_total_character_count() * percent_visible; diff --git a/scene/gui/line_edit.cpp b/scene/gui/line_edit.cpp index 2dc60b3dcb..e91f8add31 100644 --- a/scene/gui/line_edit.cpp +++ b/scene/gui/line_edit.cpp @@ -991,7 +991,7 @@ String LineEdit::get_text() const { void LineEdit::set_placeholder(String p_text) { - placeholder = localize(p_text); + placeholder = tr(p_text); update(); } diff --git a/scene/gui/popup_menu.cpp b/scene/gui/popup_menu.cpp index a3c06a7b17..1ba936c4e9 100644 --- a/scene/gui/popup_menu.cpp +++ b/scene/gui/popup_menu.cpp @@ -96,7 +96,7 @@ Size2 PopupMenu::get_minimum_size() const { size.width += check_w + hseparation; } - String text = items[i].shortcut.is_valid() ? String(localize(items[i].shortcut->get_name())) : items[i].xl_text; + String text = items[i].shortcut.is_valid() ? String(tr(items[i].shortcut->get_name())) : items[i].xl_text; size.width += font->get_string_size(text).width; if (i > 0) size.height += vseparation; @@ -395,7 +395,7 @@ void PopupMenu::_notification(int p_what) { case NOTIFICATION_TRANSLATION_CHANGED: { for (int i = 0; i < items.size(); i++) { - items[i].xl_text = localize(items[i].text); + items[i].xl_text = tr(items[i].text); } minimum_size_changed(); @@ -475,7 +475,7 @@ void PopupMenu::_notification(int p_what) { } item_ofs.y += font->get_ascent(); - String text = items[i].shortcut.is_valid() ? String(localize(items[i].shortcut->get_name())) : items[i].xl_text; + String text = items[i].shortcut.is_valid() ? String(tr(items[i].shortcut->get_name())) : items[i].xl_text; if (!items[i].separator) { font->draw(ci, item_ofs + Point2(0, Math::floor((h - font_h) / 2.0)), text, items[i].disabled ? font_color_disabled : (i == mouse_over ? font_color_hover : font_color)); @@ -513,7 +513,7 @@ void PopupMenu::add_icon_item(const Ref &p_icon, const String &p_label, Item item; item.icon = p_icon; item.text = p_label; - item.xl_text = localize(p_label); + item.xl_text = tr(p_label); item.accel = p_accel; item.ID = p_ID; items.push_back(item); @@ -523,7 +523,7 @@ void PopupMenu::add_item(const String &p_label, int p_ID, uint32_t p_accel) { Item item; item.text = p_label; - item.xl_text = localize(p_label); + item.xl_text = tr(p_label); item.accel = p_accel; item.ID = p_ID; items.push_back(item); @@ -534,7 +534,7 @@ void PopupMenu::add_submenu_item(const String &p_label, const String &p_submenu, Item item; item.text = p_label; - item.xl_text = localize(p_label); + item.xl_text = tr(p_label); item.ID = p_ID; item.submenu = p_submenu; items.push_back(item); @@ -546,7 +546,7 @@ void PopupMenu::add_icon_check_item(const Ref &p_icon, const String &p_ Item item; item.icon = p_icon; item.text = p_label; - item.xl_text = localize(p_label); + item.xl_text = tr(p_label); item.accel = p_accel; item.ID = p_ID; item.checkable = true; @@ -557,7 +557,7 @@ void PopupMenu::add_check_item(const String &p_label, int p_ID, uint32_t p_accel Item item; item.text = p_label; - item.xl_text = localize(p_label); + item.xl_text = tr(p_label); item.accel = p_accel; item.ID = p_ID; item.checkable = true; @@ -628,7 +628,7 @@ void PopupMenu::set_item_text(int p_idx, const String &p_text) { ERR_FAIL_INDEX(p_idx, items.size()); items[p_idx].text = p_text; - items[p_idx].xl_text = localize(p_text); + items[p_idx].xl_text = tr(p_text); update(); } diff --git a/scene/gui/tab_container.cpp b/scene/gui/tab_container.cpp index 520de951d5..d32b899de7 100644 --- a/scene/gui/tab_container.cpp +++ b/scene/gui/tab_container.cpp @@ -231,7 +231,7 @@ void TabContainer::_notification(int p_what) { // Draw the tab contents. Control *control = tabs[i + first_tab_cache]->cast_to(); - String text = control->has_meta("_tab_name") ? String(localize(String(control->get_meta("_tab_name")))) : String(control->get_name()); + String text = control->has_meta("_tab_name") ? String(tr(String(control->get_meta("_tab_name")))) : String(control->get_name()); int x_content = tab_rect.position.x + tab_style->get_margin(MARGIN_LEFT); int top_margin = tab_style->get_margin(MARGIN_TOP); @@ -299,7 +299,7 @@ int TabContainer::_get_tab_width(int p_index) const { // Get the width of the text displayed on the tab. Ref font = get_font("font"); - String text = control->has_meta("_tab_name") ? String(localize(String(control->get_meta("_tab_name")))) : String(control->get_name()); + String text = control->has_meta("_tab_name") ? String(tr(String(control->get_meta("_tab_name")))) : String(control->get_name()); int width = font->get_string_size(text).width; // Add space for a tab icon.