From 5d96124af6fee0ae99ccbb0cb5f05b4550dccdb4 Mon Sep 17 00:00:00 2001 From: Mark Riedesel Date: Sat, 16 Oct 2021 14:21:46 -0400 Subject: [PATCH] Add check to SurfaceTool.generate_lod(); ensure target index count between 0 and source index count. Fixes #53876 --- scene/resources/surface_tool.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scene/resources/surface_tool.cpp b/scene/resources/surface_tool.cpp index a8cd872408..455af8a40c 100644 --- a/scene/resources/surface_tool.cpp +++ b/scene/resources/surface_tool.cpp @@ -1174,9 +1174,11 @@ Vector SurfaceTool::generate_lod(float p_threshold, int p_target_index_coun Vector lod; ERR_FAIL_COND_V(simplify_func == nullptr, lod); + ERR_FAIL_COND_V(p_target_index_count < 0, lod); ERR_FAIL_COND_V(vertex_array.size() == 0, lod); ERR_FAIL_COND_V(index_array.size() == 0, lod); ERR_FAIL_COND_V(index_array.size() % 3 != 0, lod); + ERR_FAIL_COND_V(index_array.size() < (unsigned int)p_target_index_count, lod); lod.resize(index_array.size()); LocalVector vertices; //uses floats