From 7f2814c6cf58d66c3cf6637e8328839d390ec6a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Cambr=C3=A9?= Date: Wed, 10 Nov 2021 20:53:28 +0100 Subject: [PATCH] Propery selecotor cahnge UI and scope variable Update VisualScriptPropertySelector user interface. Issues Icons not showing --- .../visual_script/visual_script_editor.cpp | 2 +- .../visual_script_property_selector.cpp | 760 +++++++++++++++--- .../visual_script_property_selector.h | 117 ++- 3 files changed, 767 insertions(+), 112 deletions(-) diff --git a/modules/visual_script/visual_script_editor.cpp b/modules/visual_script/visual_script_editor.cpp index c74d6f9a4a..8e24d53959 100644 --- a/modules/visual_script/visual_script_editor.cpp +++ b/modules/visual_script/visual_script_editor.cpp @@ -1926,7 +1926,7 @@ void VisualScriptEditor::_generic_search(String p_base_type, Vector2 pos, bool n port_action_pos = graph->get_viewport()->get_mouse_position() - graph->get_global_position(); } - new_connect_node_select->select_from_visual_script(p_base_type, false, false); // neither connecting nor reset text + new_connect_node_select->select_from_script(script, "", false, false); // neither connecting nor reset text // Ensure that the dialog fits inside the graph. Size2 bounds = graph->get_global_position() + graph->get_size() - new_connect_node_select->get_size(); diff --git a/modules/visual_script/visual_script_property_selector.cpp b/modules/visual_script/visual_script_property_selector.cpp index d8b88d6cd3..2435749f4f 100644 --- a/modules/visual_script/visual_script_property_selector.cpp +++ b/modules/visual_script/visual_script_property_selector.cpp @@ -41,6 +41,7 @@ #include "modules/visual_script/visual_script_nodes.h" #include "scene/main/node.h" #include "scene/main/window.h" +#include void VisualScriptPropertySelector::_text_changed(const String &p_newtext) { _update_search(); @@ -55,20 +56,20 @@ void VisualScriptPropertySelector::_sbox_input(const Ref &p_ie) { case KEY_DOWN: case KEY_PAGEUP: case KEY_PAGEDOWN: { - search_options->gui_input(k); + results_tree->gui_input(k); search_box->accept_event(); - TreeItem *root = search_options->get_root(); + TreeItem *root = results_tree->get_root(); if (!root->get_first_child()) { break; } - TreeItem *current = search_options->get_selected(); + TreeItem *current = results_tree->get_selected(); - TreeItem *item = search_options->get_next_selected(root); + TreeItem *item = results_tree->get_next_selected(root); while (item) { item->deselect(0); - item = search_options->get_next_selected(item); + item = results_tree->get_next_selected(item); } current->select(0); @@ -80,65 +81,135 @@ void VisualScriptPropertySelector::_sbox_input(const Ref &p_ie) { } } +void VisualScriptPropertySelector::_update_icons() { + search_box->set_right_icon(vbox->get_theme_icon(SNAME("Search"), SNAME("EditorIcons"))); + search_box->set_clear_button_enabled(true); + search_box->add_theme_icon_override("right_icon", vbox->get_theme_icon(SNAME("Search"), SNAME("EditorIcons"))); + case_sensitive_button->set_icon(vbox->get_theme_icon(SNAME("MatchCase"), SNAME("EditorIcons"))); + hierarchy_button->set_icon(vbox->get_theme_icon(SNAME("ClassList"), SNAME("EditorIcons"))); + + if (is_visible()) { + _update_search(); + } +} + void VisualScriptPropertySelector::_update_search() { + int search_flags = filter_combo->get_selected_id(); + int scope_flags = scope_combo->get_selected_id(); + + if (case_sensitive_button->is_pressed()) { + search_flags |= SEARCH_CASE_SENSITIVE; + } + if (hierarchy_button->is_pressed()) { + search_flags |= SEARCH_SHOW_HIERARCHY; + } + + // const String search_text = search_box->get_text().replace(" ", "_"); !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + const String term = search_box->get_text(); + // ADJUSTS Scope depending on keywords here. + + //search = Ref(memnew(Runner(results_tree, results_tree, term, search_flags))); + search = Ref(memnew(Runner(results_tree, results_tree, term, search_flags, scope_flags))); + set_process(true); + //_update_search_old(); +} + +void VisualScriptPropertySelector::_update_search_old() { set_title(TTR("Search VisualScript")); - search_options->clear(); + results_tree->clear(); help_bit->set_text(""); - TreeItem *root = search_options->create_item(); - bool found = false; + TreeItem *root = results_tree->create_item(); + + // Allow using spaces in place of underscores in the search string (makes the search more fault-tolerant). + const String search_text = search_box->get_text().replace(" ", "_"); + StringName base = base_type; List base_list; + + if (!script.is_null()) { + base_list.push_back(script->get_path()); + } + + // ClassDB::get_inheriters_from_class(); !!!!!!!!! + // // To get all inheritors / successors + // To get unfilterd all classes list check + // // bool EditorHelpSearch::Runner::_phase_match_classes_init() { + // // iterator_doc = EditorHelp::get_doc_data()->class_list.front(); while (base) { base_list.push_back(base); - base = ClassDB::get_parent_class_nocheck(base); + base = ClassDB::get_parent_class(base); } + TreeItem *category = nullptr; + + bool found = false; + + Ref type_icons[Variant::VARIANT_MAX] = { + vbox->get_theme_icon(SNAME("Variant"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("bool"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("int"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("float"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("String"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Vector2"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Vector2i"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Rect2"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Rect2i"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Vector3"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Vector3i"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Transform2D"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Plane"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Quaternion"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("AABB"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Basis"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Transform3D"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Color"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("StringName"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("NodePath"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("RID"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("MiniObject"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Callable"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Signal"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Dictionary"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedByteArray"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedInt32Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedInt64Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedFloat32Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedFloat64Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedStringArray"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedVector2Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedVector3Array"), SNAME("EditorIcons")), + vbox->get_theme_icon(SNAME("PackedColorArray"), SNAME("EditorIcons")) + }; for (const StringName &E : base_list) { List methods; List props; - TreeItem *category = nullptr; - Ref type_icons[Variant::VARIANT_MAX] = { - vbc->get_theme_icon(SNAME("Variant"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("bool"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("int"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("float"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("String"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Vector2"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Vector2i"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Rect2"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Rect2i"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Vector3"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Vector3i"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Transform2D"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Plane"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Quaternion"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("AABB"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Basis"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Transform3D"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Color"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("StringName"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("NodePath"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("RID"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("MiniObject"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Callable"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Signal"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Dictionary"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedByteArray"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedInt32Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedInt64Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedFloat32Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedFloat64Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedStringArray"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedVector2Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedVector3Array"), SNAME("EditorIcons")), - vbc->get_theme_icon(SNAME("PackedColorArray"), SNAME("EditorIcons")) - }; + if (instance) { + print_error("select from instance needs to tested or removed"); // Debugging !! remove line befor squashing PR ! + instance->get_property_list(&props, true); + instance->get_method_list(&methods); + } else if (type != Variant::NIL) { + Variant v; + Callable::CallError ce; + Variant::construct(type, v, nullptr, 0, ce); + v.get_property_list(&props); + v.get_method_list(&methods); + } else if (ClassDB::class_exists(E)) { + ClassDB::get_method_list(E, &methods, true, true); + ClassDB::get_property_list(E, &props, true); + } else { + Object *obj = ObjectDB::get_instance(script->get_instance_id()); + if (Object::cast_to