Commit graph

264 commits

Author SHA1 Message Date
Anubhab Ghosh
4972ef801a Add clear menu entries for extending and replacing scripts 2019-10-23 01:57:17 +05:30
Bojidar Marinov
cfc779ccf0
Fix "Make Scene Root" deleting previous root whenever focusing another scene
Hopefully fixes #24484 and fixes #27222.
2019-09-28 15:29:09 +03:00
Rémi Verschelde
8868fd2d28
Merge pull request #31971 from aole/placeholder-confirmation-dialog-for-editable-children
Placeholder confirmation dialog for editable children
2019-09-27 22:02:15 +02:00
Bhupendra Aole
cb528e31d9 Placeholder dialog for editable children
Fire placeholder confirmation dialog box when editable children option is already checked.
Fixes #28863
2019-09-27 13:49:55 -04:00
Rémi Verschelde
de03ee94cc
Merge pull request #32296 from BenjaminRiley/save-original-scene-after-save-as-branch
'Save Branch as Scene' also saves original scene
2019-09-25 10:07:39 +02:00
Benjamin Riley
2115bced93 'Save Branch as Scene' adds to undo history
When saving a branch as a scene, can now undo replacing the original branch with the new branch scene. 'Save Branch as Scene' previously would not mark the original scene as changed, and therefore no prompt would appear if the scene was closed immediately after saving the branch.

The new branch scene is not deleted when undo-ing.
2019-09-25 17:08:08 +10:00
Rémi Verschelde
2f52d73c21
Merge pull request #31925 from bojidar-bg/31855-overriden-properties-docs
Add overriden properties to the documentation
2019-09-24 11:53:43 +02:00
Tomasz Chabora
48ca6ec657 Perform reparent if position changes 2019-09-22 12:44:59 +02:00
Rémi Verschelde
769a9c521a
Merge pull request #32094 from Calinou/improve-delete-node-confirmation-2
Improve the node deletion confirmation message
2019-09-20 23:17:29 +02:00
Michael Alexsander Silva Dias
e5d9c7dcb0 Fix some errors while reparenting nodes in the Scene dock 2019-09-14 21:07:55 -03:00
Hugo Locurcio
fd1b5cc39f
Improve the node deletion confirmation message
- Add "the root node" in the beginning if the selected node
  is the current scene's root
- Add "and its children" at the end of the message if the node
  has at least one child and is not an instanced scene
2019-09-11 23:29:34 +02:00
Bojidar Marinov
6c4407bae4
Add overriden properties to the documentation
Fixes #31855
2019-09-04 15:21:40 +03:00
Hugo Locurcio
284548c4b7
Improve the node deletion confirmation message
The confirmation message now displays the number of nodes to delete,
or the node's name if only one node is selected.
2019-09-03 23:14:59 +02:00
thimenesup
79a4930501
Expose SceneTreeDock::get_tree_editor()
This can be useful for plugins that rely on some signals emitted by it, Like my Networked Scene Editor plugin https://github.com/thimenesup/GodotNetworkedSceneEditor
2019-08-20 18:06:21 +02:00
Braden Bodily
71d71d55b5 Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'core/' and 'editor/'
Condensed some if and ERR statements. Added dots to end of error messages

Couldn't figure out EXPLAINC. These files gave me trouble: core/error_macros.h, core/io/file_access_buffered_fa.h (where is it?),
core/os/memory.cpp,
drivers/png/png_driver_common.cpp,
drivers/xaudio2/audio_driver_xaudio2.cpp (where is it?)
2019-08-17 12:33:15 +02:00
Tomasz Chabora
9fbba73dd5 Improve node Change Type option 2019-08-09 16:31:31 +02:00
qarmin
aab8da25ad Fix some code found by Coverity Scan and PVS Studio 2019-07-23 09:14:31 +02:00
Rémi Verschelde
3aeca70659
Merge pull request #30697 from bojidar-bg/6067-pale-customtype-script
Make custom types more subtle and more useful
2019-07-20 11:49:52 +02:00
Bojidar Marinov
4f72178868
Make custom types more subtle and more useful
Implements #6067 (aaronfranke's idea)
Fixes #26980
2019-07-19 22:33:58 +03:00
Julian Murgia
249fdd9f80 Adds contextual item in scene tree dock to wrap selection in a new node
Fixes #20187
2019-07-19 16:46:13 +02:00
hbina085
e9c1e5aa7c Fix crash when changing Node type
Prevent the application from crashing by simply checking if current "selection" is not null before accessing it.
Fixes #30493
2019-07-15 09:17:14 -04:00
Kanabenki
6eb6895db8 Sort selected nodes in scene tree before duplication 2019-07-06 14:51:24 +02:00
Rémi Verschelde
a9ad1e6692
Merge pull request #30321 from KoBeWi/underdup
Smarter node placement after duplicating
2019-07-05 09:56:31 +02:00
Rémi Verschelde
26cff6ff92
Merge pull request #30316 from sparkart/master
Reparent selection without flattening
2019-07-05 09:56:06 +02:00
LikeLakers2
d2e915623a SceneTreeDock will reset the ScriptCreateDialog's inheritance base type 2019-07-04 16:36:24 -04:00
Tomasz Chabora
0cd9a65aa4 Smarter node placement after duplicating 2019-07-04 18:16:19 +02:00
Emmanuel Barroga
839c3bd1bf Resolves Issue #30271 Reparent selection without flattening
When reparenting a multi-selection via drag and drop, the hierarchy was flattened. This change resolves that issue.
2019-07-04 06:41:21 -07:00
Rémi Verschelde
e8b483ce21
Merge pull request #19936 from Xrayez/collapse-button
Expand/collapse nodes recursively in scene tree dock
2019-07-02 10:02:24 +02:00
Rémi Verschelde
0268a4869d
Merge pull request #30196 from LikeLakers2/scenetreedock-script-creation-bugfix
SceneTreeDock will now only attach scripts to the selected node if the ScriptCreateDialog was opened from the SceneTreeDock
2019-07-01 21:13:46 +02:00
qarmin
3c154eb93b Remove unnecessary code and add some error explanations 2019-07-01 12:59:42 +02:00
LikeLakers2
410054db38 SceneTreeDock will now only attach scripts to the selected node if the ScriptCreateDialog was opened from the SceneTreeDock 2019-06-29 23:19:45 -04:00
Rémi Verschelde
ddba2e7b47
Merge pull request #26748 from raphael10241024/instance
Fix editor crash when saving a scene containing an inherited scene instance.
2019-06-19 16:28:15 +02:00
Cameron Reikes
63c2d1bce1 Hide remote scene tree when adding new scene
- Don't show create_root_dialog if remote scenetree visible
 - Hide create_root_dialog on showing of remote scenetree
Fixes #29288
2019-05-30 23:56:08 -07:00
Rémi Verschelde
500fe89600
Merge pull request #28349 from KoBeWi/sprite_editor_mistake_eraser
Add undo for Sprite Editor
2019-05-28 18:39:14 +02:00
Rémi Verschelde
d4811e6897
Merge pull request #28862 from KoBeWi/editable_clones
Keep editable children on node duplicate
2019-05-28 18:38:46 +02:00
Rémi Verschelde
b71254a861
Merge pull request #28392 from KoBeWi/reparent_alt
Allow to keep local transform when reparenting in editor
2019-05-28 17:31:27 +02:00
Tomasz Chabora
7e9e023e5f Keep editable children on node duplicate 2019-05-28 16:53:24 +02:00
Rémi Verschelde
6273e4d76d
Merge pull request #26487 from matzebond/master
Auto-expand current node type when changing node type
2019-05-28 12:52:21 +02:00
Rémi Verschelde
47f00925dc
Merge pull request #28454 from homer666/popup-centered-maxsize
Add `popup_centered_clamped()` method to Popup
2019-05-28 11:36:41 +02:00
Matthias Schmitt
6b7c8ef327 Auto-expand current node type when replace node 2019-05-24 00:13:41 +02:00
Michael Alexsander Silva Dias
587986f654 Properly update script button when undoing a script addition
Fixes #28870.
2019-05-13 22:58:41 -03:00
Michael Alexsander Silva Dias
699140000c Revert "Merge pull request #28715 from YeldhamDev/inherent_scene_close_empty"
This reverts commit 0f8356d439, reversing
changes made to 7b7a664a97.
2019-05-08 00:46:40 -03:00
Michael Alexsander Silva Dias
648cc7c0f5 Make editor close empty scene when creating an inherited one
Fixes #28654.
2019-05-06 02:01:01 -03:00
Rémi Verschelde
9591e587fe
Merge pull request #26022 from lupoDharkael/create-script
Add class tree selection to script inheritance selection
2019-04-30 13:43:53 +02:00
homer666
80e9e93e27 Add Popup::popup_centered_clamped method
- Also replace redundant duplicate code in editor dialogs with calls to popup_centered_clamped()
2019-04-30 05:35:43 +10:00
Tomasz Chabora
9dba47a743 Allow to keep local transform when reparenting 2019-04-29 19:24:12 +02:00
Tomasz Chabora
a93ff8d210 Add undo for Sprite Editor 2019-04-23 21:10:44 +02:00
Rémi Verschelde
04efa59868
Merge pull request #28292 from homer666/merge-from-scene-stuff
Minor "Merge From Scene" improvements
2019-04-23 12:08:55 +02:00
Rémi Verschelde
a342131eba
Merge pull request #27673 from qarmin/small_fixes
Small fixes, mostly duplicated code
2019-04-22 12:00:34 +02:00
homer666
36f955e4f3 Minor "Merge From Scene" improvements 2019-04-22 12:01:20 +10:00
Andrii Doroshenko (Xrayez)
824f68483f Add ability to expand/collapse nodes recursively in scene tree dock
To expand or collapse the node recursively (all children), hold `Shift`
button and click on the node's folding arrow.

The popup menu option `Expand/Collapse All" checks whether any node
is expanded or collapsed first and performs the opposite operation. That
means if any children node is collapsed, it will first expand all nodes
at selected node.

Co-authored-by: Rikhardur Bjarni Einarsson (MunWolf) badulf96@gmail.com
2019-04-21 13:50:30 +03:00
JFonS
42043a22e8 Add grouping to 3D editor 2019-04-17 18:24:28 +02:00
Rémi Verschelde
0d87535dd7
Merge pull request #28011 from KoBeWi/rmb_housework
Small cleanup to SceneTree dock context menu
2019-04-15 11:46:01 +02:00
Rémi Verschelde
adb41c8bee
Merge pull request #26678 from YeldhamDev/hide_addscript_multiselected
Hide "Add Script" button in Scene dock when multiple nodes are selected
2019-04-15 11:42:09 +02:00
Tomasz Chabora
d532a3f710 Small cleanup to SceneTree context menu 2019-04-14 14:04:04 +02:00
Michael Alexsander Silva Dias
27e500d4b3 Hide "Add Script" button in Scene dock when multiple nodes are selected 2019-04-13 11:05:10 -03:00
Gio Aleman
f707266b52 Fixed scene tree bug when scripts are disabled 2019-04-12 11:44:45 -04:00
Tomasz Chabora
9432e06e05 Focus SceneTree dock after creating new node 2019-04-10 17:01:42 +02:00
Juan Linietsky
a20235aeb0 Add ability to edit editor feature profiles
Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-08 19:18:51 -03:00
qarmin
856a8226a5 Small fixes, mostly dupicated code 2019-04-08 11:03:37 +02:00
Rémi Verschelde
612a109b81
Merge pull request #27228 from Kanabenki/preserve-binds-change-node
Preserve extra arguments for connected signals when changing node type
2019-04-02 11:30:45 +02:00
Rémi Verschelde
3c797248d0
Merge pull request #26970 from KoBeWi/custom_node_is_now_other_node
Changed 'Custom Node' to 'Other Node' to be less confusing
2019-04-01 10:13:27 +02:00
Kanabenki
a1e7febbb3 Keep binds for connected signals when changing node type 2019-03-19 10:21:52 +01:00
yakun.zhang
e25a50d690 add check for inherted nodes when instance 2019-03-18 19:40:36 +08:00
Rémi Verschelde
c1fae20400
Merge pull request #26706 from YeldhamDev/multinode_scriptclear_fix
Fix clearing scripts while multiple nodes are selected
2019-03-16 11:09:40 -07:00
Tomasz Chabora
c1ce5b87b4 Changed 'Custom Node' to 'Other Node' to be less confusing 2019-03-12 16:12:14 +01:00
George Marques
25f9aee005
Allow class_name scripts to have nested inheritance 2019-03-09 00:47:27 -03:00
Michael Alexsander Silva Dias
d3042d162d Fix clearing scripts while multiple nodes are selected 2019-03-06 09:58:47 -03:00
Tomasz Chabora
63a2475f0f Allow to attach script when there's no 'selected node', but selection exists 2019-03-05 16:28:39 +01:00
Michael Alexsander Silva Dias
3ef8238c1c Make translatable some undo/redo operations in the editor 2019-02-21 16:41:01 -03:00
marxin
8d51618949 Add -Wshadow=local to warnings and fix reported issues.
Fixes #25316.
2019-02-20 19:44:12 +01:00
lupoDharkael
76560c8afa Add class tree selection to script inheritance selection 2019-02-18 19:16:09 +01:00
Juan Linietsky
cd45f05f7e Forbid making root on inherited scenes, closes #24484 2019-01-22 13:49:03 -03:00
Juan Linietsky
e0336996ce Add some checks to avoid disaster when making a node the scene root. Fixes #24484 2019-01-17 15:26:38 -03:00
Juan Linietsky
6f884cc884 Use SceneTreeDock to replace particles node properly, fixes #24162 2019-01-14 13:41:54 -03:00
Chaosus
be2bc4dab8 Improved script attachment/removal a bit 2019-01-02 16:56:11 +03:00
Rémi Verschelde
b16c309f82 Update copyright statements to 2019
Happy new year to the wonderful Godot community!
2019-01-01 12:58:10 +01:00
volzhs
8f4e842b47 Hide "Attach Script" if node has one 2018-10-29 22:25:52 +09:00
Rémi Verschelde
0a80ceaf02
Merge pull request #23288 from willnationsdev/restore-clear-script
Restore ClearScript btn w/ ExtendScript RMB link
2018-10-29 12:16:55 +01:00
groud
5536e7a8d4 Fixes the editor layout 2018-10-26 12:44:49 +02:00
Will Nations
b4e7299b72 Restore ClearScript btn w/ ExtendScript RMB link 2018-10-25 13:33:16 -05:00
Rémi Verschelde
8e391c1e22
Merge pull request #23071 from bfhobbes/use_quickopen_for_instance_child
Use EditorQuickOpen dialog instead of EditorFileDialog when instancing a child scene.
2018-10-25 15:10:26 +02:00
Silvano Cerza
7167394876 Fixed user being unable to delete root Node if is an inherited Scene
User wasn't able to delete the root Node because it was being treated as
a foreign Node since it was an inherited Scene
2018-10-24 11:27:41 +02:00
Will Nations
42300b2769 Add icon_script_extend & update the icon @runtime 2018-10-19 09:04:07 -05:00
Andrew McDonald
66503465db Use EditorQuickOpen dialog instead of EditorFileDialog when instancing a child scene.
Addresses the bulk of #5180
2018-10-16 22:19:51 -07:00
DualMatrix
eac36a0651 Fixed setting node as root showing error and making invisible children visible.
Fixed setting node as root showing error and making invisible children visible.
2018-10-16 14:17:16 +02:00
Rémi Verschelde
3e9740ac93 Fix more "may be used initialized" warnings from GCC 7
Fixes the following GCC 7 warnings:
```
core/cowdata.h:269:47: warning: 'alloc_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/error_macros.h:163:26: warning: 'nearest_point' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1579:5: warning: 'colormap_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1582:12: warning: 'size_height' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1590:23: warning: 'size_width' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/image.cpp:1599:29: warning: 'pixel_size' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/math/face3.cpp:207:15: warning: 'tri_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
core/math/face3.cpp:209:15: warning: 'tri_min' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_scene_gles3.cpp:665:22: warning: 'best_used_frame' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_storage_gles3.cpp:865:27: warning: 'blit_target' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/rasterizer_storage_gles3.cpp:980:29: warning: 'blit_target' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::frag_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::id' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/gles3/shader_gles3.h:122:9: warning: '<anonymous>.ShaderGLES3::Version::vert_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/plugins/script_editor_plugin.cpp:1980:31: warning: 'se' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/scene_tree_dock.cpp:840:30: warning: 'new_node' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'a1' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'lll' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4259:9: warning: 'lul' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4260:9: warning: 'a2' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4261:9: warning: 'a3' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4265:3: warning: 'enable_lin' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4294:3: warning: 'enable_ang' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4311:34: warning: 'll' may be used uninitialized in this function [-Wmaybe-uninitialized]
editor/spatial_editor_gizmos.cpp:4311:34: warning: 'ul' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1655:47: warning: 'cone_dirs' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/3d/voxel_light_baker.cpp:1656:73: warning: 'cone_weights' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/gui/texture_progress.cpp:181:6: warning: 'cp' may be used uninitialized in this function [-Wmaybe-uninitialized]
scene/gui/texture_progress.cpp:181:6: warning: 'cq' may be used uninitialized in this function [-Wmaybe-uninitialized]
servers/physics/shape_sw.cpp:1056:19: warning: 'support_max' may be used uninitialized in this function [-Wmaybe-uninitialized]
```
2018-10-04 18:54:20 +02:00
swarnimarun
97ffdf74c3 Fixing create spatial root button 2018-10-04 06:06:58 +05:30
groud
980aa276e3 Add a shortcut to the documentation in the scene tree RMB menu 2018-10-03 11:25:18 +02:00
Rémi Verschelde
648b21228e
Merge pull request #22009 from DualMatrix/warning
Added warning when disabling editable_instance
2018-10-02 09:50:40 +02:00
Rémi Verschelde
53fbd93409
Merge pull request #22593 from akien-mga/fix-warnings
Fix various warnings raised by Clang 7
2018-10-02 00:01:31 +02:00
Rémi Verschelde
22c3995a04
Merge pull request #22576 from DualMatrix/multi_edit_exit
Fixed inspector not going back to single-node when deselecting an item.
2018-10-01 23:44:27 +02:00
Rémi Verschelde
413f078125
Merge pull request #22584 from DualMatrix/editor_path_no_update
Fixed name of deleted node not dissapearing from inspector dock.
2018-10-01 23:43:58 +02:00
Rémi Verschelde
b1b625f4f5 Fix various Clang 7 warnings about unused stuff
Namely:
[-Wunneeded-internal-declaration]
[-Wunused-comparison]
[-Wunused-const-variable]
[-Wunused-function]
[-Wunused-private-fields]

Fixes the following Clang 7 warnings:
```
editor/plugins/script_editor_plugin.cpp:1417:20: warning: function '_find_node_with_script' is not needed and will not be emitted [-Wunneeded-internal-declaration]
editor/scene_tree_dock.cpp:1859:14: warning: function '_find_last_visible' is not needed and will not be emitted [-Wunneeded-internal-declaration]

modules/gdscript/gdscript_parser.cpp:7838:19: warning: equality comparison result unused [-Wunused-comparison]

scene/resources/mesh.cpp:549:35: warning: unused variable '_array_types' [-Wunused-const-variable]
scene/resources/mesh.cpp:563:18: warning: unused variable '_format_translate' [-Wunused-const-variable]

drivers/gles3/rasterizer_scene_gles3.cpp:54:28: warning: unused function 'store_transform2d' [-Wunused-function]

core/io/file_access_network.h:50:6: warning: private field 'ml' is not used [-Wunused-private-field]
core/io/file_access_zip.h:93:14: warning: private field 'archive' is not used [-Wunused-private-field]
core/io/resource_format_binary.h:122:6: warning: private field 'bin_meta_idx' is not used [-Wunused-private-field]
core/message_queue.h:47:9: warning: private field 'mutex' is not used [-Wunused-private-field]
main/tests/test_gui.cpp:63:11: warning: private field 'control' is not used [-Wunused-private-field]
modules/gdscript/gdscript_parser.h:558:7: warning: private field 'completion_static' is not used [-Wunused-private-field]
platform/x11/os_x11.h:148:11: warning: private field 'ip_unix' is not used [-Wunused-private-field]
platform/x11/os_x11.h:180:7: warning: private field 'net_wm_icon' is not used [-Wunused-private-field]
platform/x11/os_x11.h:189:6: warning: private field 'audio_driver_index' is not used [-Wunused-private-field]
platform/x11/os_x11.h:190:15: warning: private field 'capture_idle' is not used [-Wunused-private-field]
servers/physics/body_pair_sw.h:79:6: warning: private field 'cc' is not used [-Wunused-private-field]
servers/visual/visual_server_raster.h:62:7: warning: private field 'draw_extra_frame' is not used [-Wunused-private-field]
```
2018-10-01 17:32:12 +02:00
DualMatrix
ec463b036a Fixed inspector not going back to single-node when deselecting an item.
Fixed inspector not going back to single-node when deselecting an item.
2018-10-01 12:26:32 +02:00
DualMatrix
3ef241623e Fixed name of deleted node not dissapearing from inspector dock.
Fixed name of deleted node not dissapearing from inspector dock.
2018-10-01 12:15:22 +02:00
DualMatrix
6f96db4732 Fixed setting node as root deleting all non-children of that node.
Fixed setting node as root deleting all non-children of that node.
2018-09-30 00:04:18 +02:00
JFonS
a100b320c2 Change viewport type after using create root menu
Change viewport type (2D/3D) according to the type of node just created
from the "Create Root Node" menu.
2018-09-20 10:44:58 +02:00
DualMatrix
edd93b7608 Fixed favorite nodes list not being saved
Fixed favorite nodes list not being saved
2018-09-19 00:30:01 +02:00
DualMatrix
0d09f80e43 Added warning when disabling editable_instance
Added warning when disabling editable_instance to prevent data loss.
2018-09-17 15:18:03 +02:00