maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
kibana/.github/CODEOWNERS

378 lines
19 KiB
Plaintext
Raw Normal View History

introducing CODEOWNERS to Kibana (#22830)
2018-09-14 20:46:03 +02:00
# GitHub CODEOWNERS definition
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
# Identify which groups will be pinged by changes to different parts of the codebase.
# For more info, see https://help.github.com/articles/about-codeowners/
introducing CODEOWNERS to Kibana (#22830)
2018-09-14 20:46:03 +02:00
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
# The #CC# prefix delineates Code Coverage,
# used for the 'team' designator within Kibana Stats
New visualization editor Lens (#36437) * [lens] Initial Commit (#35627) * [visualization editor] Initial Commit * [lens] Add more complete initial state * [lens] Fix type issues * [lens] Remove feature control * [lens] Bring back feature control and add tests * [lens] Update plugin structure and naming per comments * replace any usage by safe casting * [lens] Respond to review comments * [lens] Remove unused EditorFrameState type * [lens] Initial state for IndexPatternDatasource (#36052) * [lens] Add first tests to indexpattern data source * Respond to review comments * Fix type definitions * [lens] Editor frame initializes datasources and visualizations (#36060) * [lens] Editor frame initializes datasources and visualizations * Respond to review comments * Fix build issues * Fix state management issue * [lens][draft] Lens/drag drop (#36268) Add basic drag / drop component to Lens * remove local package (#36456) * [lens] Native renderer (#36165) * Add nativerenderer component * Use native renderer in app and editor frame * [Lens] No explicit any (#36515) * [Lens] Implement basic editor frame state handling (#36443) * [lens] Load index patterns and render in data panel (#36463) * [lens] Editor frame initializes datasources and visualizations * Respond to review comments * Fix build issues * remove local package * [lens] Load index patterns into data source * Redo types for Index Pattern Datasource * Fix one more type * Respond to review comments * [draft] Lens/line chart renderer (#36827) Expression logic for the Lens xy chart. * [lens] Index pattern data panel (initial) (#37015) * [lens] Index pattern switcher * Respond to review comments * [Lens] Editor state 2 (#36513) * [lens] Dimension panel that generates columns (#37117) * [lens] Dimension panel that generates columns * Update from review comments * [lens] Generate esdocs queries from index pattern (#37361) * [lens] Generate esdocs queries from index pattern * Remove unused code * Update yarn.lock from yarn kbn bootstrap * [Lens] Add basic Lens xy chart suggestions (#37030) Basic xy chart suggestions * [Lens] Expression rendering (#37648) * [Lens] Expression handling (#37876) * [Lens] Lens/xy config panel (#37391) Basic xy chart configuration panel * [Lens] Xy expression building (#37967) * [Lens] Initialize visualization with datasource api (#38142) * [lens] Dimension panel lets users select operations and fields individually (#37573) * [lens] Dimension panel lets users select operations and fields individually * Split files and add tests * Fix dimension labeling and add clear button * Support more aggregations, aggregation nesting, rollups, and clearing * Fix esaggs expression * Increase top-level test coverage of dimension panel * Update from review comments * [Lens] Rename columns (#38278) * [Lens] Lens/index pattern drag drop (#37711) * Basic xy chart suggestions * Re-apply XY config panel after force merge * Initial integration of lens drag and drop * Tweak naming, remove irellevant comment * Tweaks per Wylie's feedback * Add xy chart internationalization Tweak types per Joe's feedback * Update xy chart i18n implementation * Fix i18n id * Add drop tests to the lens index pattern * improve tests * [lens] Only allow aggregated dimensions (#38820) * [lens] Only allow aggregated dimensions * [lens] Index pattern suggest on drop * Fully remove value * Revert "[lens] Index pattern suggest on drop" This reverts commit 604c6ed68ca394441ddafa662bdfc5f421de300c. * Fix type errors * [lens] Suggest on drop (#38848) * [lens] Index pattern suggest on drop * Add test for suggestion without date field * fix merge * [Lens] Parameter configurations and new dimension config flow (#38863) * fix eslint failure * [lens] Fix build by updating saved objects and i18n (#39391) * [lens] Update location of saved objects code * Update internatationalization * Remove added file * [lens] Fix arguments to esaggs using booleans (#39462) * [lens] Datatable visualization plugin (#39390) * [lens] Datatable visualization plugin * Fix merge issues and add tests * Update from review * Fix file locations * [lens] Use first suggestion when switching visualizations (#39377) * [lens] Label each Y axis with its operation label (#39461) * [lens] Label each Y axis with its operation label * Remove comment * Add link to chart issue * [Lens] Suggestion preview rendering (#39576) * [Lens] Popover configs (#39565) * [Lens] Basic layouting (#39587) * remove datasource public API in suggestions (#39772) * [Lens] Basic save / load (#39257) Add basic routing, save, and load to Lens * [lens] Fix lint error * [lens] Use node scripts/eslint.js --fix to fix errors * [lens] Include link to lens from Visualize (#40542) * [lens] Support stacking in xy visualization (#40546) * [lens] Support stacking in xy visualization * Use chart type switcher for stacked and horizontal xy charts * Clean up remaining isStacked code * Fix type error * [Lens] Add xy split series support (#39726) * Add split series to lens xy chart * [lens] Lens Filter Ratio (#40196) * WIP filter ratio * Fix test issues * Pass dependencies through plugin like new platform * Pass props into filter ratio popover editor * Provide mocks to filter_ratio popover test * Add another test * Clean up to prepare for review * Clean up unnecessary changes * Respond to review comments * Fix tests * [Lens] Terms order direction (#39884) * fix types * [Lens] Data panel styling and optimizations (#40787) Style the data panel (mostly Joe Reuter's doing). Optimize a bunch of the Lens stack. * [Lens] Optimize dimension panel flow (#41114) * [Lens] re-introduce no-explicit-any (#41454) * [Lens] No results marker (#41450) * [lens] Support layers for visualizing results of multiple queries (#41290) * [lens] WIP add support for layers * [lens] WIP switch to nested tables * Get basic layering to work * Load multiple tables and render in one chart * Fix priority ordering * Reduce quantity of linting errors * Ensure that new xy layer state has a split column * Make the "add" y / split the trailing accessor * Various fixes for datasource public API and implementation * Unify datasource deletion and accessor removal * Fix broken scss * Fix xy visualization TypeScript errors? * Build basic suggestions * Restore save/load and fix typescript bugs * simplify init routine * fix save tests * fix persistence tests * fix state management tests * Ensure the data table is aligned to the top * Add layer support to Lens datatable * Give xy chart a default layer initially * Allow deletion of layers in xy charts * xy: Make split accessor singular Remove commented code blocks * Change expression type for lens_merge_tables * Fix XY chart rendering expression * Fix type errors relating to `layerId` in table suggestions * Pass around tables for suggestions with associated layerIds * fix tests in workspace panel * fix editor_frame tests * Fix xy tests, skip inapplicable tests that will be implemented in a separate PR * add some tests for multiple datasources and layers * Suggest that split series comes before X axis in XY chart * Get datatable suggestion working * Adjust how xy axis labels are computed * Datasource suggestions should handle layers and have tests * Fix linting in XY chart and remove commented code * Update snapshots from earlier change * Fix linting errors * More cleanup * Remove commented code * Test the multi-column editor * XY Visualization does not need to track datasourceId * Fix various comments * Remove unused xy prop Add datasource header to datatable config * Use operation labels for XY chart * Adding and removing layers is reflected in the datasource * rewrote datasource state init * clean up editor_frame frame api implementation * clean up editor frame * [Lens] Embeddable (#41361) * [lens] Move XY chart config into popover and fix layering (#41927) * [lens] Move XY chart config into popover and fix layering * Fix tests * Update style * Change wrapping of layer settings popover * [Lens] Fix bugs in date_histogram and filter ratio (#42046) * [Lens] Performance improvements (#41784) * fix type error * switch default size of terms operation to 3 (#42334) * [lens] Improve suggestions for split series (#42052) * [lens] Add chart switcher (#42093) * solve merge conflicts * fix test case * [Lens] Allow only current visualization on field drop in workspace (#42344) * [Lens] Remove indexpattern id on column (#42429) * [lens] Implement app-level filtering and time picker (#42031) * [lens] Implement app-level filtering and time picker * More integration with filter bar * Clean up test code and type errors * Add frame level tests for syncing with app * Add test coverage for app logic * Simplify state management from app down * Fix import errors * Clarify whether properties are ids or titles for index pattern * pass new saved object by ref * add dirty state checking * Fix tests * [Lens] Add some tests around document handling in dimension panel (#42670) * [Lens] Terms operation boolean support (#42817) * [lens] Minor UX/UI improvements in Lens (#42852) * Make dimension popover toggle when clicking button * Without suggestions hide suggestion panel * Add missing translations (#42921) * [Lens] Config panel design (#42980) * Fix up design of config panel Does not include config popover * Remove a couple of non-null assertions (#43013) * Remove a couple of non-null assertions * Remove orphaned import * [Lens] Switch indexpattern manually (#42599) * [Lens] Update frame to put suggestions at the bottom (#42997) * fix type errors * switch indexpattern on layer if there is only a single empty one (#43079) * [Lens] Suggest reduced versions of current data table (#42537) * [Lens] Field formatter support (#38874) * Fix bugs * [Lens] Add bucket nesting editor to indexpattern (#42869) * [Lens] Remove unnecessary fields and indexing from mappings (#43285) * [Lens] Xy scale type (#42142) * [lens] Allow updater function to be used for updating state (#43373) * [Lens] Lens metric visualization (#39364) * Fix axis rotation (#43792) * [Lens] Auto date histogram (#43775) * Add auto date histogram * Improve documentation and cleanup * Add tests * Change test name * [Lens] Fix query bar integration (#43865) * [Lens] Clean up operations code (#43784) * [Lens] Functional tests (#44279) Foundational layer for lens functional tests. Lens-specific page objects are not in this PR. * [Lens] Add Lens visualizations to Visualize list (#43398) * [Lens] Suggestion improvements (#43688) * [lens] Calculate existence of fields in datasource (#44422) * [lens] Calculate existence of fields in datasource * Fix route registration * Add page object and use existence in functional test * Simplify layout of filters for index pattern * Respond to review feedback * Update class names * Use new URL constant * Fix usage of base path * Fix lint errors * [Lens ] Preview metric (#43755) * format filter ratio as percentage (#44625) * [Lens] Remove datasource suggestion id (#44495) * [Lens] Make breadcrumbs look and feel like Visualize (#44258) * [lens] Fix breakage from app-arch movements (#44720) * [lens] Fix type error in test from merge * [lens] Fix registration of embeddable (#45171) * [Lens] Functional tests (#44814) Basic functional tests for Lens, by no means comprehensive. This is more of a smokescreen test of some normal use cases. * [lens] Add Lens to CODEOWNERS (#45296) * [lens] Fix visualization alias registration * [lens] Fix usage of EUI after typescript upgrade (#45404) * [lens] Fix usage of EUI after typescript upgrade * Use local fix instead of workaround * [lens] Fix usage of expressions plugin (#45544) * [lens] Fix usage of expressions plugin * Use updated exports from #45538 * Fix imports and mocha tests * Use relative instead of absolute path to fix tests * [lens] More cleanup from QueryBar changes in master (#45687) * [lens] Fix build and use new platform from entry points (#45834) * [lens] Fix build and use new platform from entry points * Fix params for existence route
2019-09-17 20:57:53 +02:00
# App
Explore underlying data (#68496) * feat: 🎸 stub discover_enhanced plugin * feat: 🎸 improve view in discover action * feat: 🎸 add URL generator to "View in Discover" action * feat: 🎸 implement navigation and getHref in view raw logs actio * fix: 🐛 disable action in "edit" mode * refactor: 💡 renamce context menu view in discover action * feat: 🎸 rename action to "explore data" * fix: 🐛 correctly generate action path * feat: 🎸 add internationalization to "explore action" * fix: 🐛 correctly parse generated Discover URL path * test: 💍 setup basic functional tests * refactor: 💡 modularize url generation logic * feat: 🎸 export CommonlyUsed type * test: 💍 add test subjects to panel custom time range modal * test: 💍 add index patterna and time range functional tests * refactor: 💡 rename action file * refactor: 💡 use URL generator from Discover plugin's contract * test: 💍 add "Explore raw data" action unit tests * fix: 🐛 import share plugin to check if it is enabled * Update x-pack/plugins/discover_enhanced/public/actions/view_in_discover/explore_data_context_menu_action.ts Co-authored-by: Matthias Wilhelm <ankertal@gmail.com> * chore: 🤖 add discover_enhanced to KibanaApp codeowners * test: 💍 improve "Explore underlying data" functional tests * test: 💍 improve <a> link assertion Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
2020-06-17 10:31:16 +02:00
/x-pack/plugins/discover_enhanced/ @elastic/kibana-app
Move Lens frontend to Kibana Platform (#62965) * Move Lens frontend to Kibana platform * Fix line breaks * Fix jest tests * Fix remaining test * Remove old Lens plugin entry * Fix i18n prefix * Add config schema * Address review
2020-04-15 12:22:37 +02:00
/x-pack/plugins/lens/ @elastic/kibana-app
Fix CODEOWNERS and sass lint paths (#63552)
2020-04-15 17:52:21 +02:00
/x-pack/plugins/graph/ @elastic/kibana-app
chore: move advanced_settings and management plugins to App team codeowners (#78285)
2020-09-23 16:23:36 +02:00
/src/plugins/advanced_settings/ @elastic/kibana-app
Add charts plugin to codeowners file (#77907)
2020-09-18 19:02:26 +02:00
/src/plugins/charts/ @elastic/kibana-app
Move ownerships of home, dev tools and discover (#62612) * move ownership * fix es-ui ownership
2020-04-06 18:36:22 +02:00
/src/plugins/discover/ @elastic/kibana-app
chore: move advanced_settings and management plugins to App team codeowners (#78285)
2020-09-23 16:23:36 +02:00
/src/plugins/management/ @elastic/kibana-app
Adjust kibana app owning files (#65064)
2020-05-04 13:45:39 +02:00
/src/plugins/kibana_legacy/ @elastic/kibana-app
Move legacy plugins to appropriate teams (#79078) * Move legacy plugins to appropriate teams * More cleanup
2020-10-02 13:39:38 +02:00
/src/plugins/timelion/ @elastic/kibana-app
Adjust kibana app owning files (#65064)
2020-05-04 13:45:39 +02:00
/src/plugins/vis_default_editor/ @elastic/kibana-app
/src/plugins/vis_type_metric/ @elastic/kibana-app
/src/plugins/vis_type_table/ @elastic/kibana-app
/src/plugins/vis_type_tagcloud/ @elastic/kibana-app
/src/plugins/vis_type_timelion/ @elastic/kibana-app
/src/plugins/vis_type_timeseries/ @elastic/kibana-app
/src/plugins/vis_type_vega/ @elastic/kibana-app
/src/plugins/vis_type_vislib/ @elastic/kibana-app
/src/plugins/vis_type_xy/ @elastic/kibana-app
/src/plugins/visualize/ @elastic/kibana-app
Trying to fix CODEOWNERS again, where was a non-existent team prior (#83236)
2020-11-12 01:16:04 +01:00
/src/plugins/visualizations/ @elastic/kibana-app
Expand Tinymath grammar, including named arguments (#89795) * Expand Tinymath grammar, including named arguments * Add tsconfig project * Fix tests * Allow named arguments with numeric types * Remove dashes from named argument validation * Fix license header Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-09 16:46:07 +01:00
/packages/kbn-tinymath/ @elastic/kibana-app
Move ownerships of home, dev tools and discover (#62612) * move ownership * fix es-ui ownership
2020-04-06 18:36:22 +02:00
Remove missing files and folders from CODEOWNERS file (#82060) * Remove folders that don't exist anymore * Fix owner for security solution * add ml folders * Remove missing folders added after merge * Remove missing folder
2020-11-11 00:26:58 +01:00
# Application Services
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
/examples/bfetch_explorer/ @elastic/kibana-app-services
/examples/dashboard_embeddable_examples/ @elastic/kibana-app-services
/examples/demo_search/ @elastic/kibana-app-services
/examples/developer_examples/ @elastic/kibana-app-services
/examples/embeddable_examples/ @elastic/kibana-app-services
/examples/embeddable_explorer/ @elastic/kibana-app-services
/examples/state_containers_examples/ @elastic/kibana-app-services
/examples/ui_action_examples/ @elastic/kibana-app-services
/examples/ui_actions_explorer/ @elastic/kibana-app-services
/examples/url_generators_examples/ @elastic/kibana-app-services
/examples/url_generators_explorer/ @elastic/kibana-app-services
/packages/elastic-datemath/ @elastic/kibana-app-services
/packages/kbn-interpreter/ @elastic/kibana-app-services
/src/plugins/bfetch/ @elastic/kibana-app-services
/src/plugins/data/ @elastic/kibana-app-services
/src/plugins/embeddable/ @elastic/kibana-app-services
/src/plugins/expressions/ @elastic/kibana-app-services
/src/plugins/inspector/ @elastic/kibana-app-services
/src/plugins/kibana_react/ @elastic/kibana-app-services
Team:Presentation Code Owners and automation changes (#82343) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-03 17:32:47 +01:00
/src/plugins/kibana_react/public/code_editor @elastic/kibana-presentation
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
/src/plugins/kibana_utils/ @elastic/kibana-app-services
/src/plugins/navigation/ @elastic/kibana-app-services
/src/plugins/share/ @elastic/kibana-app-services
/src/plugins/ui_actions/ @elastic/kibana-app-services
update codeowners (#95249)
2021-03-24 04:52:44 +01:00
/src/plugins/index_pattern_field_editor @elastic/kibana-app-services
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
/x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-services
/x-pack/plugins/data_enhanced/ @elastic/kibana-app-services
/x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-services
/x-pack/plugins/ui_actions_enhanced/ @elastic/kibana-app-services
add missed codeowners (#89714) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-04 17:13:20 +01:00
/x-pack/plugins/runtime_fields @elastic/kibana-app-services
[Search Sessions] Rename search sessions functional tests. Remove wip mention (#95330)
2021-03-26 18:08:46 +01:00
/x-pack/test/search_sessions_integration/ @elastic/kibana-app-services
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
#CC# /src/plugins/bfetch/ @elastic/kibana-app-services
#CC# /src/plugins/index_pattern_management/ @elastic/kibana-app-services
#CC# /src/plugins/inspector/ @elastic/kibana-app-services
#CC# /src/plugins/share/ @elastic/kibana-app-services
#CC# /x-pack/plugins/drilldowns/ @elastic/kibana-app-services
#CC# /packages/kbn-interpreter/ @elastic/kibana-app-services
State containers 📦 (#38758) * feat: 🎸 add initial createStore() implementation * test: 💍 test observable $state interface * style: 💄 apply prettier * chore: 🤖 upgrade react-redux lib * refactor: 💡 rename $state -> state$ * feat: 🎸 add initial React context and connect implementation * feat: 🎸 improve connect()() HOC TypeScript typings * feat: 🎸 export store methods * feat: 🎸 implement store mutations * chore: 🤖 add TODO list * refactor: 💡 rename .mutations -> .createMutations * feat: 🎸 use name Redux actions for mutations * fix: 🐛 fix TypeScript errors * feat: 🎸 store mutations inside store object * style: 💄 run Prettier on test file * refactor: 💡 rename mutation -> mutator * chore: 🤖 set :AppArch team as code owners of kibana_utils * chore: 🤖 update x-pack package.json react-redux dependencies * chore: 🤖 run yarn kbn bootstrap * chore: 🤖 revert back react-redux package upgrade * refactor: 💡 rename remaining mutation -> mutator * feat: 🎸 implement first set of React hooks * chore: 🤖 revert back react-redux upgrade * refactor: 💡 use useState() inside <Consumer> * feat: 🎸 implement useSelector() React hook * docs: ✏️ add store creation docs * docs: ✏️ add mutators documentation * docs: ✏️ add getter and Redux docs * docs: ✏️ add react reference * docs: ✏️ typo * docs: typo Co-Authored-By: Stacey Gammon <gammon@elastic.co> * docs: typo Co-Authored-By: Stacey Gammon <gammon@elastic.co> * docs: remove private link
2019-06-14 16:00:32 +02:00
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
# APM
[APM] Update path to APM app after move to NP (#65034)
2020-05-05 18:22:47 +02:00
/x-pack/plugins/apm/ @elastic/apm-ui
Update CODEOWNERS (#47029)
2019-10-01 15:59:16 +02:00
/x-pack/test/functional/apps/apm/ @elastic/apm-ui
Add APM API tests dir to CODEOWNERS (#89573)
2021-01-30 10:49:59 +01:00
/x-pack/test/apm_api_integration/ @elastic/apm-ui
Add @elastic/apm-ui as code owner of APM NP plugin (#55674)
2020-01-23 13:44:55 +01:00
/src/plugins/apm_oss/ @elastic/apm-ui
Update CODEOWNERS with new APM people (#84120)
2020-11-24 10:27:24 +01:00
/src/apm.js @elastic/kibana-core @vigneshshanmugam
/packages/kbn-apm-config-loader/ @elastic/kibana-core @vigneshshanmugam
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
#CC# /src/plugins/apm_oss/ @elastic/apm-ui
#CC# /x-pack/plugins/observability/ @elastic/apm-ui
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
[Uptime] increase flaky alert retry time (#91455)
2021-02-16 18:53:33 +01:00
# Uptime
/x-pack/plugins/uptime @elastic/uptime
[Exploratory view] Use index patterns for formatting (#96280)
2021-04-08 07:16:23 +02:00
/x-pack/plugins/observability/public/components/shared/exploratory_view @elastic/uptime
[Uptime] increase flaky alert retry time (#91455)
2021-02-16 18:53:33 +01:00
/x-pack/test/functional_with_es_ssl/apps/uptime @elastic/uptime
/x-pack/test/functional/apps/uptime @elastic/uptime
/x-pack/test/api_integration/apis/uptime @elastic/uptime
# Client Side Monitoring / Uptime (lives in APM directories but owned by Uptime)
[CSM] Enable csm e2e tests (#77336)
2020-09-15 18:26:05 +02:00
/x-pack/plugins/apm/e2e/cypress/support/step_definitions/csm @elastic/uptime
[CSM] Url search (#77516) Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-23 12:51:39 +02:00
/x-pack/plugins/apm/e2e/cypress/integration/csm_dashboard.feature @elastic/uptime
Add CSM app to CODEOWNERS (#76793)
2020-09-04 18:37:17 +02:00
/x-pack/plugins/apm/public/application/csmApp.tsx @elastic/uptime
/x-pack/plugins/apm/public/components/app/RumDashboard @elastic/uptime
/x-pack/plugins/apm/server/lib/rum_client @elastic/uptime
/x-pack/plugins/apm/server/routes/rum_client.ts @elastic/uptime
[CSM] Url search (#77516) Co-authored-by: Justin Kambic <justin.kambic@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-23 12:51:39 +02:00
/x-pack/plugins/apm/server/projections/rum_page_load_transactions.ts @elastic/uptime
Add APM API tests dir to CODEOWNERS (#89573)
2021-01-30 10:49:59 +01:00
/x-pack/test/apm_api_integration/tests/csm/ @elastic/uptime
Add CSM app to CODEOWNERS (#76793)
2020-09-04 18:37:17 +02:00
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
Team:Presentation Code Owners and automation changes (#82343) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-03 17:32:47 +01:00
# Presentation
/src/plugins/dashboard/ @elastic/kibana-presentation
/src/plugins/input_control_vis/ @elastic/kibana-presentation
/src/plugins/vis_type_markdown/ @elastic/kibana-presentation
[Time to Visualize] Add Discrete Library Option to Save Modal (#94589) * save modal UI and Redirect and save to library Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
2021-03-18 18:40:02 +01:00
/src/plugins/presentation_util/ @elastic/kibana-presentation
[Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (#89612)
2021-02-09 00:21:06 +01:00
/test/functional/apps/dashboard/ @elastic/kibana-presentation
Team:Presentation Code Owners and automation changes (#82343) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-03 17:32:47 +01:00
/x-pack/plugins/canvas/ @elastic/kibana-presentation
/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-presentation
/x-pack/test/functional/apps/canvas/ @elastic/kibana-presentation
#CC# /src/plugins/kibana_react/public/code_editor/ @elastic/kibana-presentation
#CC# /x-pack/plugins/dashboard_mode @elastic/kibana-presentation
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
Cleanup (#71849) * chore: 🤖 update codeowners file * refactor: 💡 rename whitelist -> allow-list in data plugin * Update .github/CODEOWNERS Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-15 22:42:38 +02:00
Create observability CODEOWNERS reference (#57109) * Create observability CODEOWNERS reference * Update elastic/epm to elastic/ingest per Jen's request :) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-11 16:27:35 +01:00
# Observability UIs
/x-pack/plugins/infra/ @elastic/logs-metrics-ui
Update code owners for Fleet (#89715) Rename ingest-management to fleet.
2021-01-29 19:21:53 +01:00
/x-pack/plugins/fleet/ @elastic/fleet
Changes observability plugin codeowner (#70439) The observability plugin is now code-owned by a new observability-ui GH team to avoid pinging 4 separate teams for mandatory reviews when that plugin changes.
2020-07-01 16:04:21 +02:00
/x-pack/plugins/observability/ @elastic/observability-ui
[Monitoring] NP Migration complete client cutover (#62908) * Final phase before the complete cutover * NP migration * lint fix * More NP stuff * Moved Stack Monitoring client plugin outside legacy and fixed all tests * ... * Removed unused files * Fix for main links * Fixed more tests * Fixed redirect when clicking on SM icon again * Code review feedback * Addressed code review feedback * Fixed return value
2020-04-30 21:59:35 +02:00
/x-pack/plugins/monitoring/ @elastic/stack-monitoring-ui
Adds infra plugin to CODEOWNERS (#36634)
2019-05-17 19:18:01 +02:00
[ML] Add ml-ui team to CODEOWNERS. (#29810)
2019-02-01 12:18:12 +01:00
# Machine Learning
[ML] Updated ML and transform CODEOWNERS for NP. (#59286) Updates CODEOWNERS to include NP plugin paths for the ML and transform plugin.
2020-03-04 13:02:43 +01:00
/x-pack/plugins/ml/ @elastic/ml-ui
Update CODEOWNERS for ml-ui (#95773)
2021-03-30 13:40:31 +02:00
/x-pack/test/accessibility/apps/ml.ts @elastic/ml-ui
/x-pack/test/accessibility/apps/ml_embeddables_in_dashboard.ts @elastic/ml-ui
/x-pack/test/api_integration/apis/ml/ @elastic/ml-ui
/x-pack/test/api_integration_basic/apis/ml/ @elastic/ml-ui
Remove missing files and folders from CODEOWNERS file (#82060) * Remove folders that don't exist anymore * Fix owner for security solution * add ml folders * Remove missing folders added after merge * Remove missing folder
2020-11-11 00:26:58 +01:00
/x-pack/test/functional/apps/ml/ @elastic/ml-ui
Update CODEOWNERS for ml-ui (#95773)
2021-03-30 13:40:31 +02:00
/x-pack/test/functional/es_archives/ml/ @elastic/ml-ui
Remove missing files and folders from CODEOWNERS file (#82060) * Remove folders that don't exist anymore * Fix owner for security solution * add ml folders * Remove missing folders added after merge * Remove missing folder
2020-11-11 00:26:58 +01:00
/x-pack/test/functional/services/ml/ @elastic/ml-ui
Update CODEOWNERS for ml-ui (#95773)
2021-03-30 13:40:31 +02:00
/x-pack/test/functional_basic/apps/ml/ @elastic/ml-ui
/x-pack/test/functional_with_es_ssl/apps/ml/ @elastic/ml-ui
Remove ES-UI as code owner of Transform app. (#62556)
2020-04-06 18:49:23 +02:00
# ML team owns and maintains the transform plugin despite it living in the Elasticsearch management section.
/x-pack/plugins/transform/ @elastic/ml-ui
[ML] Transforms: Adds a11y tests for Transform plugin (#93197)
2021-03-03 12:41:44 +01:00
/x-pack/test/accessibility/apps/transform.ts @elastic/ml-ui
Update CODEOWNERS for ml-ui (#95773)
2021-03-30 13:40:31 +02:00
/x-pack/test/api_integration/apis/transform/ @elastic/ml-ui
Remove missing files and folders from CODEOWNERS file (#82060) * Remove folders that don't exist anymore * Fix owner for security solution * add ml folders * Remove missing folders added after merge * Remove missing folder
2020-11-11 00:26:58 +01:00
/x-pack/test/api_integration_basic/apis/transform/ @elastic/ml-ui
Update CODEOWNERS for ml-ui (#95773)
2021-03-30 13:40:31 +02:00
/x-pack/test/functional/apps/transform/ @elastic/ml-ui
/x-pack/test/functional/services/transform/ @elastic/ml-ui
Remove missing files and folders from CODEOWNERS file (#82060) * Remove folders that don't exist anymore * Fix owner for security solution * add ml folders * Remove missing folders added after merge * Remove missing folder
2020-11-11 00:26:58 +01:00
/x-pack/test/functional_basic/apps/transform/ @elastic/ml-ui
[ML] Add ml-ui team to CODEOWNERS. (#29810)
2019-02-01 12:18:12 +01:00
[Maps] register @elastic/kibana-gis to maps code (#53487)
2019-12-19 19:23:20 +01:00
# Maps
Add maps plugin to code-coverage (#83949) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-23 17:51:48 +01:00
#CC# /x-pack/plugins/maps/ @elastic/kibana-gis
[Maps] register @elastic/kibana-gis to maps code (#53487)
2019-12-19 19:23:20 +01:00
/x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis
/x-pack/test/functional/apps/maps/ @elastic/kibana-gis
/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
/x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis
[Maps] Add geo alerts dirs to codeowners (#98076) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-22 23:40:44 +02:00
/x-pack/plugins/stack_alerts/server/alert_types/geo_containment @elastic/kibana-gis
/x-pack/plugins/stack_alerts/public/alert_types/geo_containment @elastic/kibana-gis
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
#CC# /src/plugins/maps_legacy/ @elastic/kibana-gis
#CC# /x-pack/plugins/file_upload @elastic/kibana-gis
[Maps] fix code-owners (#84265)
2020-11-24 20:36:57 +01:00
/src/plugins/tile_map/ @elastic/kibana-gis
/src/plugins/region_map/ @elastic/kibana-gis
[Maps] Add package to codeowners (#100786)
2021-05-27 17:25:28 +02:00
/packages/kbn-mapbox-gl @elastic/kibana-gis
[Maps] register @elastic/kibana-gis to maps code (#53487)
2019-12-19 19:23:20 +01:00
Update CODEOWNERS with the paths under kibana operations team supervision (#26374) * feat(NA): update CODEOWNERS with the code under kibana operations team supervision. * chore(NA): add suport_node_env to operations codeowners. * refact(NA): change declaration order.
2019-05-10 00:43:58 +02:00
# Operations
/src/dev/ @elastic/kibana-operations
/src/setup_node_env/ @elastic/kibana-operations
add codeowner declarations for operations packages
2019-10-21 21:58:37 +02:00
/packages/*eslint*/ @elastic/kibana-operations
/packages/*babel*/ @elastic/kibana-operations
/packages/kbn-dev-utils*/ @elastic/kibana-operations
/packages/kbn-es/ @elastic/kibana-operations
build immutable bundles for new platform plugins (#53976) * build immutable bundles for new platform plugins * only inspect workers if configured to do so * [navigation] use an index.scss file * add yarn.lock symlink * set pluginScanDirs in test so fixtures stay consistent * cleanup helpers a little * fix type error * support KBN_OPTIMIZER_MAX_WORKERS for limiting workers via env * test support for KBN_OPTIMIZER_MAX_WORKERS * expand the available memory for workers when only running one or two * add docs about KBN_OPTIMIZER_MAX_WORKERS environment variable * fix README link * update kbn/pm dist * implement bundle caching/reuse * update kbn/pm dist * don't check for cache if --no-cache is passed * update renovate config * standardize on index.scss, move console styles over * add support for --no-cache to cli * include worker config vars in optimizer version * ignore concatenated modules * update integration test * add safari to browserslist to avoid user-agent warnings in dev * update docs, clean up optimizer message/misc naming * always handle initialized messages, don't ignore states that are attached to specific events * reword caching docs, add environment var to disable caching * tweak logging and don't use optimizer.useBundleCache as that's disabled in dev * handle change notifications * batch changes for 1 second * rename CompilerState type to CompilerMsg * getChanges() no longer needs to assign changes to dirs * remove unused deps * split up run_worker.ts and share cacheKey generation logic * add a couple docs * update tests and remove unused imports * specify files when creating bundle cache key * remove one more unused import * match existing dev cli output more closely * update kbn/pm dist * set KBN_NP_PLUGINS_BUILT to avoid warning in CI * avoid extending global window type * add note to keep pluginScanDirs in sync * pass browserslistEnv in workerConfig so it is used for cache key * load commons.bundle.js in parallel too * emit initialized+success states if all bundles are cached * load bootstraps as quickly as possible * skip flaky suite * bump * update jest snapshots * remove hashing from cache key generation * remove unnecessary non-null assertion * improve docs and break up Optimizer#run() * remove unused import * refactor kbn/optimizer to break up observable logic, implement more helpful cache invalidation logic with logging * fix tests * add initializing phase * avoid rxjs observable constructor * remove unnecessary rxjs helper, add tests for bundle cache * update consumers of optimizer * update readme with new call style * replace "new platform" with "kibana platform" * fix a couple more renames * add support for several plain-text file formats * fix naming of OptimizerMsg => OptimizerUpdate, use "store" naming too * one more OptimizerMsg update * ensure bundles are not cached when cache config is false * test for initializing states and bundle cache events * remove unnecessary timeout change * Remove unnecessary helpers * Add tests for BundleCache class * Add tests for Bundle class * test summarizeEvent$ * missing paths are no longer listed in mtimes map * add tests for optimizer/cache_keys * Add some extra docs * Remove labeled loop * add integration test for kbn-optimizer watcher components * querystring-browser removed * tweak logging a smidge, improve info and final message * remove unused imports * remove duplication of getModuleCount() method * move type annotation that validates things * clear up the build completion message Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-13 03:42:42 +01:00
/packages/kbn-optimizer/ @elastic/kibana-operations
add codeowner declarations for operations packages
2019-10-21 21:58:37 +02:00
/packages/kbn-pm/ @elastic/kibana-operations
/packages/kbn-test/ @elastic/kibana-operations
share specific instances of some ui packages (#54079) * share specific instances of some ui packages * remove unnecessary eslint changes, every package will define deps anyway * remove mentions of moment webpackShims in eslint resolver * remove use of lodash * list angular as dep for x-pack * add operations as codeowner of shared-deps pkg
2020-01-10 23:22:18 +01:00
/packages/kbn-ui-shared-deps/ @elastic/kibana-operations
[kbn/es-archiver] move to a package (#72318) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-22 17:02:39 +02:00
/packages/kbn-es-archiver/ @elastic/kibana-operations
Adds @kbn/utils package (#76518) Moves common utility functions to obtain the repository root, paths (config/data), and Kibana package.json to a @kbn/utils package. Moving these existing functions allows them to be used in production, in other packages because of Kibana. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2020-09-15 19:34:39 +02:00
/packages/kbn-utils/ @elastic/kibana-operations
Remove core->cli dependency (#95145) * extract http_tools to package * fix readme * start moving stuff * cleaning up `isDevCliParent` * choose bootstrap script * fix bootstrap script logic * fix watch paths logic * import REPO_ROOT from correct package * create the @kbn/crypto package * update core's `dev` config * only export bootstrap function * extract sslConfig to http-tools package * fix core types * fix optimizer tests * fix cli_dev_mode tests * fix basePath proxy tests * update generated doc * fix unit tests * create @kbn/dev-cli-mode package * remove useless comment * self-review NITS * update CODEOWNERS file * add devOnly flag * use variable for DEV_MODE_PATH * review comments * fix logger/log adapter * fix log calls in base path proxy server * address some review comments * rename @kbn/http-tools to @kbn/server-http-tools * more review comments * move test to correct file * add comment on getBootstrapScript * fix lint * lint * add cli-dev-mode to eslint dev packages * review comments * update yarn.lock * Revert "[ci] skip building ts refs when not necessary (#95739)" This reverts commit e46a74f7
2021-03-30 13:39:32 +02:00
/packages/kbn-cli-dev-mode/ @elastic/kibana-operations
Move src/legacy/server/keystore to src/cli (#83483) Currently keystore parsing is in the legacy http server folder. Keystore references end in src/cli so instead of migrating to core/server the I opted for the closest fit in the CLI folder. Closes #52107
2020-11-17 16:19:46 +01:00
/src/cli/keystore/ @elastic/kibana-operations
Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (#66746)
2020-05-15 19:09:39 +02:00
/.ci/es-snapshots/ @elastic/kibana-operations
[CI] Automated backports via GitHub Actions - initial MVP (#90669)
2021-02-08 22:08:23 +01:00
/.github/workflows/ @elastic/kibana-operations
Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (#66746)
2020-05-15 19:09:39 +02:00
/vars/ @elastic/kibana-operations
chore(NA): push important bazel config files under operations team code owners (#90610) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-08 16:17:35 +01:00
/.bazelignore @elastic/kibana-operations
/.bazeliskversion @elastic/kibana-operations
/.bazelrc @elastic/kibana-operations
/.bazelrc.common @elastic/kibana-operations
/.bazelversion @elastic/kibana-operations
/WORKSPACE.bazel @elastic/kibana-operations
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
#CC# /packages/kbn-expect/ @elastic/kibana-operations
Update CODEOWNERS with the paths under kibana operations team supervision (#26374) * feat(NA): update CODEOWNERS with the code under kibana operations team supervision. * chore(NA): add suport_node_env to operations codeowners. * refact(NA): change declaration order.
2019-05-10 00:43:58 +02:00
Ingest code coverage (#62336)
2020-05-13 23:09:42 +02:00
# Quality Assurance
/src/dev/code_coverage @elastic/kibana-qa
[QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (#69348) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-01 01:00:45 +02:00
/vars/*Coverage.groovy @elastic/kibana-qa
FTR: move basic services under common folder (#66563) * [CODEOWNERS] set kibana-qa to own test/functional/services * [functional/services] move low-level services to common folder * update codeowners * update imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-15 18:28:28 +02:00
/test/functional/services/common @elastic/kibana-qa
/test/functional/services/lib @elastic/kibana-qa
/test/functional/services/remote @elastic/kibana-qa
Ingest code coverage (#62336)
2020-05-13 23:09:42 +02:00
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
# Core
/src/core/ @elastic/kibana-core
/src/plugins/saved_objects_tagging_oss @elastic/kibana-core
/config/kibana.yml @elastic/kibana-core
add codeowners for xpack.banners (#99630)
2021-05-10 19:05:33 +02:00
/x-pack/plugins/banners/ @elastic/kibana-core
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
/x-pack/plugins/features/ @elastic/kibana-core
/x-pack/plugins/licensing/ @elastic/kibana-core
/x-pack/plugins/global_search/ @elastic/kibana-core
/x-pack/plugins/cloud/ @elastic/kibana-core
/x-pack/plugins/saved_objects_tagging/ @elastic/kibana-core
/x-pack/test/saved_objects_field_count/ @elastic/kibana-core
/x-pack/test/saved_object_tagging/ @elastic/kibana-core
/packages/kbn-config-schema/ @elastic/kibana-core
/packages/kbn-std/ @elastic/kibana-core
increase stdout max listeners for legacy logging (#84497) * increase stdout max listeners for legacy logging * add missing packages to CODEOWNERS
2020-11-30 15:32:59 +01:00
/packages/kbn-config/ @elastic/kibana-core
/packages/kbn-logging/ @elastic/kibana-core
/packages/kbn-legacy-logging/ @elastic/kibana-core
Remove core->cli dependency (#95145) * extract http_tools to package * fix readme * start moving stuff * cleaning up `isDevCliParent` * choose bootstrap script * fix bootstrap script logic * fix watch paths logic * import REPO_ROOT from correct package * create the @kbn/crypto package * update core's `dev` config * only export bootstrap function * extract sslConfig to http-tools package * fix core types * fix optimizer tests * fix cli_dev_mode tests * fix basePath proxy tests * update generated doc * fix unit tests * create @kbn/dev-cli-mode package * remove useless comment * self-review NITS * update CODEOWNERS file * add devOnly flag * use variable for DEV_MODE_PATH * review comments * fix logger/log adapter * fix log calls in base path proxy server * address some review comments * rename @kbn/http-tools to @kbn/server-http-tools * more review comments * move test to correct file * add comment on getBootstrapScript * fix lint * lint * add cli-dev-mode to eslint dev packages * review comments * update yarn.lock * Revert "[ci] skip building ts refs when not necessary (#95739)" This reverts commit e46a74f7
2021-03-30 13:39:32 +02:00
/packages/kbn-crypto/ @elastic/kibana-core
/packages/kbn-http-tools/ @elastic/kibana-core
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
/src/plugins/saved_objects_management/ @elastic/kibana-core
/src/dev/run_check_published_api_changes.ts @elastic/kibana-core
removing kibana-core-ui from codeowners (#88111)
2021-01-16 04:31:44 +01:00
/src/plugins/home/public @elastic/kibana-core
/src/plugins/home/server/*.ts @elastic/kibana-core
/src/plugins/home/server/services/ @elastic/kibana-core
/src/plugins/kibana_overview/ @elastic/kibana-core
/x-pack/plugins/global_search_bar/ @elastic/kibana-core
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
#CC# /src/core/server/csp/ @elastic/kibana-core
#CC# /src/plugins/legacy_export/ @elastic/kibana-core
add missed codeowners (#89714) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-04 17:13:20 +01:00
#CC# /src/plugins/xpack_legacy/ @elastic/kibana-core
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
#CC# /src/plugins/saved_objects/ @elastic/kibana-core
#CC# /x-pack/plugins/cloud/ @elastic/kibana-core
#CC# /x-pack/plugins/features/ @elastic/kibana-core
#CC# /x-pack/plugins/global_search/ @elastic/kibana-core
removing kibana-core-ui from codeowners (#88111)
2021-01-16 04:31:44 +01:00
#CC# /src/plugins/newsfeed @elastic/kibana-core
#CC# /src/plugins/home/public @elastic/kibana-core
#CC# /src/plugins/home/server/services/ @elastic/kibana-core
#CC# /src/plugins/home/ @elastic/kibana-core
#CC# /x-pack/plugins/global_search_providers/ @elastic/kibana-core
Add platform team as core codeowner (#32904)
2019-03-11 17:21:36 +01:00
Changes code ownership from kibana-telemetry to kibana-core (#84281)
2020-11-25 00:32:46 +01:00
# Kibana Telemetry
/packages/kbn-analytics/ @elastic/kibana-core
/packages/kbn-telemetry-tools/ @elastic/kibana-core
/src/plugins/kibana_usage_collection/ @elastic/kibana-core
/src/plugins/newsfeed/ @elastic/kibana-core
/src/plugins/telemetry/ @elastic/kibana-core
/src/plugins/telemetry_collection_manager/ @elastic/kibana-core
/src/plugins/telemetry_management_section/ @elastic/kibana-core
/src/plugins/usage_collection/ @elastic/kibana-core
/x-pack/plugins/telemetry_collection_xpack/ @elastic/kibana-core
/.telemetryrc.json @elastic/kibana-core
/x-pack/.telemetryrc.json @elastic/kibana-core
[chore] Remove the infra team from CODEOWNERS (#94740)
2021-03-16 21:00:12 +01:00
/src/plugins/telemetry/schema/ @elastic/kibana-core @elastic/kibana-telemetry
/x-pack/plugins/telemetry_collection_xpack/schema/ @elastic/kibana-core @elastic/kibana-telemetry
Changes code ownership from kibana-telemetry to kibana-core (#84281)
2020-11-25 00:32:46 +01:00
# Kibana Localization
/src/dev/i18n/ @elastic/kibana-localization @elastic/kibana-core
/src/core/public/i18n/ @elastic/kibana-localization @elastic/kibana-core
/packages/kbn-i18n/ @elastic/kibana-localization @elastic/kibana-core
#CC# /x-pack/plugins/translations/ @elastic/kibana-localization @elastic/kibana-core
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
# Security
Updating code-owners to use new core/app-services team names (#83731) * Updating code-owners to use new core/app-services team names * And the comment as well
2020-11-18 23:26:25 +01:00
/src/core/server/csp/ @elastic/kibana-security @elastic/kibana-core
Warn users when security is not configured (#78545) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 01:47:17 +02:00
/src/plugins/security_oss/ @elastic/kibana-security
Cleanup Security plugin imports (#93056)
2021-03-02 14:42:01 +01:00
/src/plugins/spaces_oss/ @elastic/kibana-security
Warn users when security is not configured (#78545) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 01:47:17 +02:00
/test/security_functional/ @elastic/kibana-security
Adding NP spaces plugin to CODEOWNERS (#49963)
2019-11-01 20:37:38 +01:00
/x-pack/plugins/spaces/ @elastic/kibana-security
Migrate Encrypted Saved Objects plugin to the new platform. (#49890)
2019-11-01 22:32:12 +01:00
/x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security
Add ownership of new platform security plugin to security team. (#41748)
2019-07-23 13:40:33 +02:00
/x-pack/plugins/security/ @elastic/kibana-security
Reenabling the privileges test, and removing the includeActions test (#48027) * Reenabling the privileges test, and skipping the one that includes actions * Making the security team the codeowner
2019-10-12 00:02:53 +02:00
/x-pack/test/api_integration/apis/security/ @elastic/kibana-security
Hide management sections based on cluster/index privileges (#67791) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-14 15:30:47 +02:00
/x-pack/test/ui_capabilities/ @elastic/kibana-security
Implement Server-Side sessions (#68117)
2020-08-18 08:38:23 +02:00
/x-pack/test/encrypted_saved_objects_api_integration/ @elastic/kibana-security
/x-pack/test/functional/apps/security/ @elastic/kibana-security
/x-pack/test/security_api_integration/ @elastic/kibana-security
/x-pack/test/security_functional/ @elastic/kibana-security
/x-pack/test/spaces_api_integration/ @elastic/kibana-security
Speed up spaces tests by letting v2 migrations do less work (#91829) * Don't mess with v2 migration's index * Speed up spaces tests by letting v2 migrations do less work * Add disabled mapping for spaces so that plugin can be disabled * Add security as codeowners of xpack saved object api integration suite
2021-02-22 14:44:41 +01:00
/x-pack/test/saved_object_api_integration/ @elastic/kibana-security
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
#CC# /x-pack/plugins/security/ @elastic/kibana-security
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
fixing CODEOWNERS file (#52919)
2019-12-12 19:41:10 +01:00
# Kibana Alerting Services
Rename alerts plugin to alerting (#92898) * Rename alerts plugin to alerting * Deprecate old config values * Few more renames * Update plugin list * Rename xpack.alerts -> xpack.alerting * Fix some ESLint rules * Fix typecheck * Fix some test failures * Some more renames * Fix ESLint * Fix some test failures * Fix failing jest test * Undo exclusive test * Fix APM deps * Fix docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-05 19:59:34 +01:00
/x-pack/plugins/alerting/ @elastic/kibana-alerting-services
Include actions new platform plugin for codeowners (#57252)
2020-02-11 21:41:32 +01:00
/x-pack/plugins/actions/ @elastic/kibana-alerting-services
Adds event log for actions and alerting (#45081) initial code for event log see issue https://github.com/elastic/kibana/issues/45083
2020-01-22 00:00:08 +01:00
/x-pack/plugins/event_log/ @elastic/kibana-alerting-services
Fix codeowners for alerting services team (#53889) * Fix codeowners * Fix localization and telemetry folders as well * Fix task manager path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-16 00:06:24 +01:00
/x-pack/plugins/task_manager/ @elastic/kibana-alerting-services
/x-pack/test/alerting_api_integration/ @elastic/kibana-alerting-services
/x-pack/test/plugin_api_integration/test_suites/task_manager/ @elastic/kibana-alerting-services
Alerting plugin migrate to Kibana platform (#57635) * Moved alerting plugin to new platform * Fixed type checks * Fixed failing tests * Fixed functional tests * Fixed plugin context initialization * small typo * Fixed type checks * Fixed create alert schema * Moved alerting files to Kibana platform folder * Fixed duration validation * Fixed find page size * Fixed type check * Fixed due to comments * Fixed merge issues * Added missing * Fixed alerting functional tests * Fixed tests * Fixed update schema validation * Added throttle update * Fixed failing tests * test * fixed setup alerting dependencies for siem and monitoring plugins * Fixed siem setup dependancies
2020-02-18 18:05:56 +01:00
/x-pack/plugins/triggers_actions_ui/ @elastic/kibana-alerting-services
Create UI for alerting and actions plugin (#48959) * Refactored reducers type definitions * Fixed dependancy objects * Fixed action add * Fixed logging app icon * Added action types params fields * Added fields for check and re-notify alert * Add tags to alert list * Adjusted threshold expression with validation, added visualization * Move delete button to the left and hide when no selection * Rename action list title column to name * fixed request * Removed watcher labels * Design cleanup * Added expression default values * Added visualization for index threshold alert * Rename Actions tab to Connectors * Rename "create action" to "create connector" * Remove actions column name * Add count per action type * Hide checkboxes when user can't delete * Add title to home, rename Alerting UI breadcrumb (remove UI part) * Added correct binding for interval and throttle * Added tags support for create Alert UI * Added server error display in UI on save alert * Added connectors for action forms * Update button styles * Switch inputs to compressed forms * Fixed some fields for add alert form * Fixed updating action by index * Fixed filter for index/fields api requests * Remove the test alert type that was in the init function * Fixed action type icon on add connector form and did small refactoring on action forms; added action validation * Rename alerting UI plugin to triggers and actions UI (or something else) #50305 * Implemented action connector edit UI * Add bulk actions to alerts list * Update home title spacing * Fixed editing secrets action property * Changing behaviour of bulk actions and disable buttons during request * Refactored plugin definition with appdependency interface * Moved add dependencies to the separate file * Enable visualization if only hasExpressionErrors passed * Fixed add action twice on click card * Fix actions column in alert list * Fixed action canSave capability * Renamed Actions to ActionConnectors in appropriate UI files * Renamed alertTypeParams to params in UI code * Add filter for tags * Cleanup previous commit * Fix alert type filter * Refactored edit form to use ActionTableItem * Renamed ActionTableItem to ActionConnectorTableItem * Fixed missing button key error for alerts list filter * Renamed translation labels for connectors * Enable UI plugin by default * Rename buildin to builtin * Fix some type checks * Add API tests * Split API file into smaller files * Rename plugin id * Remove dependency on actions plugin (should be optional dep in NP) * Fix some translation ids * Revert "Rename plugin id" This reverts commit f6daeb3d5ea8c281fa3ce7393015ce5684cbd25a. * Rename method for loading connectors * Added functional tests base * Fix functional test type filter * Add test alert type for now * Initial connectors functional tests * Rename description to name * Use unique connector names to allow re-running tests * Assert on more things * Update alert/action menu items. Flyout width. Add index.scss file * Added action connector list unit tests * Add bulk delete functional test * Move tests to SSL functional environment * Fix tests * Added unit tests for actionTypeRegistry and alertTypeRegistry * Fixed update connector with only properties * Added some functional tests for alerts with TODOs * connectors list page cleanup * empty state cleanup * Added connector edit flyout unit test * Fix functional tests * text cleanup * zindex fix for index threshold trigger * Expand the functional tests, add assertions * Fixed edit connector from the Name column, and removed pencil button * Remove tags filter, use search bar instead * Finalize functional tests * Support filtering alerts by action type * Rename plugin name for translations * Rename default breadcrumb title to alerts and actions * Added unit tests for connectors empty prompt, fixed api tests * Added unit test for select action type menu for create connector; Fixed update selected connector for edit form * Added unit test for edit connector flyout * Added alerts list unit tests * Added connector form unit tests * Added connector reducer unit tests * Fixed some failing unit tests * Fixed alerts list unit tests * Set alert tab default if it is available * Added doc_title and get_time_units unit tests * Added some test fixes * Fixed index threshold expression to display only index and fields * Added email building action unit tests * Added unit tests for builtin action types * Remove test alert type * Move create alert UI behind feature flag 'createAlertUiEnabled' * Fix functional tests * Update codeowners * Update codeowners for tests * Revert watcher changes * Fix type check failure * Fix unit test failures * Fixed typecheck failures * Fixed language check errors * Did some text/type fixes * Fixed typecheck * Fixed unit tests warning * Fix failing functional tests * Fix registry tests to have cleaner diff when it fails * Make DEFAULT_SECTION a Section type * Remove unused constructor * Make app dependency error string same line * Remove unused error pages * Set interface to alerts context * Fix action_connector_form.tsx label * Fix label in connector_add_flyout.tsx * Fix label in alert_add.tsx * Move alert_types to builtin_alert_types * Move some threshold constants into threshold folder * Move api.ts within threshold folder * Removed duplication logic from action type and alert type registry list * Fixed email action type test and adjusted validation to support arrays ony * Added missing connector fields for email action type * Fixed building action types issues due to comments * Refactored with more new platform structure; fixed some comments from review * Capitalize Actions in 'Alerts and Actions' labels * Skip flaky tests * Fix failing functional test * Fixed failing unit tests, added new deps * Fixed type checks * Fixed language check failing * Fix broken functional tests * Refactored actionConnectors and alerting context * Removed doc title service * added get time options type definitions * removed obsolete code * Made generic registry type for actionTypes and alert types * Fixed some enum types * fixed type check CI * Convert EuiSearchBar to normal text field * Fix typo * Fix conditional rendering * Fix bug where selection doesn't reset * Fix broken functional test, wait for ENTER key to search alerts * Make app section hide from menu when user doesn't have access * Fixed connector name validation (error due to renaming from description) * Removed obsolete useEffect * Removed unused ShareRouter * Fixed key validation error * Mobed wrongly wrapped objects * Removed useEffect from connectors form * Replaced error forms with eui controls props * Added delete confirmation dialog for connectors list * Fixed build errors * Fixed failing test * Skip flaky tests * Added null check for app context - render components tree only if it isn't null * Fixed type check eror * Did changes on the UX and text/labels commnets * Fixed failing tests * Fixed error handling * Refactored Webhook form http headers due to the mockup * Fixed build * Fix labels issue * Fix spacing and form row alignment * Fixed failing type check * put ownfocus on popover in actions list * fix spacing and flex * fix color on conectors list * clean up webhook headers form * fix logic check for headers * Made changes due to review comments * Fixed delete connector test * Fixed all flaky test for delete connectors 53956 * Fixed type check due to NP changes * Disable plugin by default * Added configuration props for functional tests to enable triggers and actions ui * removed timeout from test * added enable triggers and actions to functional/config.js * fix the build * Changed ci group and disabled plugin * changed config setting to root * Changed disable approach * Experiment with index managment * Set back configuration settings for triggers and actions * Enable plugins * Set index management to disabled to see the failing issue * Revert experimental back for index_managment * Fixed type check Co-authored-by: Mike Côté <mikecote@users.noreply.github.com> Co-authored-by: dave.snider@gmail.com <dave.snider@gmail.com> Co-authored-by: DeFazio <michael.defazio@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Peter Schretlen <peter.schretlen@gmail.com>
2020-01-14 01:16:20 +01:00
/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/ @elastic/kibana-alerting-services
/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/ @elastic/kibana-alerting-services
Add alerting as codeowners to related documentation folder (#82777) * Add alerting as codeowners to related docs folders * Move up Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-09 20:43:44 +01:00
/docs/user/alerting/ @elastic/kibana-alerting-services
[Docs][Alerting] Changed overall alerting documentation structure (#95004) * [Docs][Alerting] Changed overall alerting documentation structure * fixed image link * moved alerting and connectors under the graph in the menu list * moved management docs to alerting and connectors * fixed image link * fixed connector menu position * fixed mappings * fixed mappings * fixed links * fixed levels * move manage connectors before action types * adjust connectors management * adjust connectors management * split domain specific and stack rules * fixed rule types links * added connectors ui images * fixed image links * fixed image links * fixed image links * test * fixed image links * fixed broken links * fixed broken links * fixed email links * fixed email links * fixed email links * fixed links * added images to connectors docs * Update docs/user/alerting/rule-management.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Update docs/user/alerting/stack-rules.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * fixed due to comments * fixed due to comments * fixed create connector * moved connectors to stack management section * removed bazel files * fixed managing-alerts-and-actions links * Revert "fixed managing-alerts-and-actions links" This reverts commit 0ed228b09053f9dda084d83aa8ed4174b3c2cd88. * fixed code owners Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-04-20 00:54:54 +02:00
/docs/management/connectors/ @elastic/kibana-alerting-services
removing kibana-core-ui from codeowners (#88111)
2021-01-16 04:31:44 +01:00
#CC# /x-pack/plugins/stack_alerts @elastic/kibana-alerting-services
Adds stack-services example entries to CODEOWNERS (#41241)
2019-07-17 02:56:14 +02:00
New Enterprise Search Kibana plugin (#66922) * Initial App Search in Kibana plugin work - Initializes a new platform plugin that ships out of the box w/ x-pack - Contains a very basic front-end that shows AS engines, error states, or a Setup Guide - Contains a very basic server that remotely calls the AS internal engines API and returns results * Update URL casing to match Kibana best practices - URL casing appears to be snake_casing, but kibana.json casing appears to be camelCase * Register App Search plugin in Home Feature Catalogue * Add custom App Search in Kibana logo - I haven't had much success in surfacing a SVG file via a server-side endpoint/URL, but then I realized EuiIcon supports passing in a ReactElement directly. Woo! * Fix appSearch.host config setting to be optional - instead of crashing folks on load * Rename plugin to Enterprise Search - per product decision, URL should be enterprise_search/app_search and Workplace Search should also eventually live here - reorganize folder structure in anticipation for another workplace_search plugin/codebase living alongside app_search - rename app.tsx/main.tsx to a standard top-level index.tsx (which will contain top-level routes/state) - rename AS->ES files/vars where applicable - TODO: React Router * Set up React Router URL structure * Convert showSetupGuide action/flag to a React Router link - remove showSetupGuide flag - add a new shared helper component for combining EuiButton/EuiLink with React Router behavior (https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51) * Implement Kibana Chrome breadcrumbs - create shared helper (WS will presumably also want this) for generating EUI breadcrumb objects with React Router links+click behavior - create React component that calls chrome.setBreadcrumbs on page mount - clean up type definitions - move app-wide props to IAppSearchProps and update most pages/views to simply import it instead of calling their own definitions * Added server unit tests (#2) * Added unit test for server * PR Feedback * Refactor top-level Kibana props to a global context state - rather them passing them around verbosely as props, the components that need them should be able to call the useContext hook + Remove IAppSearchProps in favor of IKibanaContext + Also rename `appSearchUrl` to `enterpriseSearchUrl`, since this context will contained shared/Kibana-wide values/actions useful to both AS and WS * Added unit tests for public (#4) * application.test.ts * Added Unit Test for EngineOverviewHeader * Added Unit Test for generate_breadcrumbs * Added Unit Test for set_breadcrumb.tsx * Added a unit test for link_events - Also changed link_events.tsx to link_events.ts since it's just TS, no React - Modified letBrowserHandleEvent so it will still return a false boolean when target is blank * Betterize these tests Co-Authored-By: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Add UI telemetry tracking to AS in Kibana (#5) * Set up Telemetry usageCollection, savedObjects, route, & shared helper - The Kibana UsageCollection plugin handles collecting our telemetry UI data (views, clicks, errors, etc.) and pushing it to elastic's telemetry servers - That data is stored in incremented in Kibana's savedObjects lib/plugin (as well as mapped) - When an end-user hits a certain view or action, the shared helper will ping the app search telemetry route which increments the savedObject store * Update client-side views/links to new shared telemetry helper * Write tests for new telemetry files * Implement remaining unit tests (#7) * Write tests for React Router+EUI helper components * Update generate_breadcrumbs test - add test suite for generateBreadcrumb() itself (in order to cover a missing branch) - minor lint fixes - remove unnecessary import from set_breadcrumbs test * Write test for get_username util + update test to return a more consistent falsey value (null) * Add test for SetupGuide * [Refactor] Pull out various Kibana context mocks into separate files - I'm creating a reusable useContext mock for shallow()ed enzyme components + add more documentation comments + examples * Write tests for empty state components + test new usecontext shallow mock * Empty state components: Add extra getUserName branch test * Write test for app search index/routes * Write tests for engine overview table + fix bonus bug * Write Engine Overview tests + Update EngineOverview logic to account for issues found during tests :) - Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s) - hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno) * Refactor EngineOverviewHeader test to use shallow + to full coverage - missed adding this test during telemetry work - switching to shallow and beforeAll reduces the test time from 5s to 4s! * [Refactor] Pull out React Router history mocks into a test util helper + minor refactors/updates * Add small tests to increase branch coverage - mostly testing fallbacks or removing fallbacks in favor of strict type interface - these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable * Address larger tech debt/TODOs (#8) * Fix optional chaining TODO - turns out my local Prettier wasn't up to date, completely my bad * Fix constants TODO - adds a common folder/architecture for others to use in the future * Remove TODO for eslint-disable-line and specify lint rule being skipped - hopefully that's OK for review, I can't think of any other way to sanely do this without re-architecting the entire file or DDoSing our API * Add server-side logging to route dependencies + add basic example of error catching/logging to Telemetry route + [extra] refactor mockResponseFactory name to something slightly easier to read * Move more Engines Overview API logic/logging to server-side - handle data validation in the server-side - wrap server-side API in a try/catch to account for fetch issues - more correctly return 2xx/4xx statuses and more correctly deal with those responses in the front-end - Add server info/error/debug logs (addresses TODO) - Update tests + minor refactors/cleanup - remove expectResponseToBe200With helper (since we're now returning multiple response types) and instead make mockResponse var name more readable - one-line header auth - update tests with example error logs - update schema validation for `type` to be an enum of `indexed`/`meta` (more accurately reflecting API) * Per telemetry team feedback, rename usageCollection telemetry mapping name to simpler 'app_search' - since their mapping already nests under 'kibana.plugins' - note: I left the savedObjects name with the '_telemetry' suffix, as there very well may be a use case for top-level generic 'app_search' saved objects * Update Setup Guide installation instructions (#9) Co-authored-by: Chris Cressman <chris@chriscressman.com> * [Refactor] DRY out route test helper * [Refactor] Rename public/test_utils to public/__mocks__ - to better follow/use jest setups and for .mock.ts suffixes * Add platinum licensing check to Meta Engines table/call (#11) * Licensing plugin setup * Add LicensingContext setup * Update EngineOverview to not hit meta engines API on platinum license * Add Jest test helpers for future shallow/context use * Update plugin to use new Kibana nav + URL update (#12) * Update new nav categories to add Enterprise Search + update plugin to use new category - per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability - Run `node scripts/check_published_api_changes.js --accept` since this new category affects public API * [URL UPDATE] Change '/app/enterprise_search/app_search' to '/app/app_search' - This needs to be done because App Search and Workplace search *have* to be registered as separate plugins to have 2 distinct nav links - Currently Kibana doesn't support nested app names (see: https://github.com/elastic/kibana/issues/59190) but potentially will in the future - To support this change, we need to update applications/index.tsx to NOT handle '/app/enterprise_search' level routing, but instead accept an async imported app component (e.g. AppSearch, WorkplaceSearch). - AppSearch should now treat its router as root '/' instead of '/app_search' - (Addl) Per Josh Dover's recommendation, switch to `<Router history={params.history}>` from `<BrowserRouter basename={params.appBasePath}>` since they're deprecating appBasePath * Update breadcrumbs helper to account for new URLs - Remove path for Enterprise Search breadcrumb, since '/app/enterprise_search' will not link anywhere meaningful for the foreseeable future, so the Enterprise Search root should not go anywhere - Update App Search helper to go to root path, per new React Router setup Test changes: - Mock custom basepath for App Search tests - Swap enterpriseSearchBreadcrumbs and appSearchBreadcrumbs test order (since the latter overrides the default mock) * Add create_first_engine_button telemetry tracking to EmptyState * Switch plugin URLs back to /app/enterprise_search/app_search Now that https://github.com/elastic/kibana/pull/66455 has been merged in :tada: * Add i18n formatted messages / translations (#13) * Add i18n provider and formatted/i18n translated messages * Update tests to account for new I18nProvider context + FormattedMessage components - Add new mountWithContext helper that provides all contexts+providers used in top-level app - Add new shallowWithIntl helper for shallow() components that dive into FormattedMessage * Format i18n dates and numbers + update some mock tests to not throw react-intl invalid date messages * Update EngineOverviewHeader to disable button on prop * Address review feedback (#14) * Fix Prettier linting issues * Escape App Search API endpoint URLs - per PR feedback - querystring should automatically encodeURIComponent / escape query param strings * Update server plugin.ts to use getStartServices() rather than storing local references from start() - Per feedback: https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications - Note: savedObjects.registerType needs to be outside of getStartServices, or an error is thrown - Side update to registerTelemetryUsageCollector to simplify args - Update/fix tests to account for changes * E2E testing (#6) * Wired up basics for E2E testing * Added version with App Search * Updated naming * Switched configuration around * Added concept of 'fixtures' * Figured out how to log in as the enterprise_search user * Refactored to use an App Search service * Added some real tests * Added a README * Cleanup * More cleanup * Error handling + README updatre * Removed unnecessary files * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_table.tsx Co-authored-by: Constance <constancecchen@users.noreply.github.com> * PR feedback - updated README * Additional lint fixes Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Add README and CODEOWNERS (#15) * Add plugin README and CODEOWNERS * Fix Typescript errors (#16) * Fix public mocks * Fix empty states types * Fix engine table component errors * Fix engine overview component errors * Fix setup guide component errors - SetBreadcrumbs will be fixed in a separate commit * Fix App Search index errors * Fix engine overview header component errors * Fix applications context index errors * Fix kibana breadcrumb helper errors * Fix license helper errors * :exclamation: Refactor React Router EUI link/button helpers - in order to fix typescript errors - this changes the component logic significantly to a react render prop, so that the Link and Button components can have different types - however, end behavior should still remain the same * Fix telemetry helper errors * Minor unused var cleanup in plugin files * Fix telemetry collector/savedobjects errors * Fix MockRouter type errors and add IRouteDependencies export - routes will use IRouteDependencies in the next few commits * Fix engines route errors * Fix telemetry route errors * Remove any type from source code - thanks to Scotty for the inspiration * Add eslint rules for Enterprise Search plugin - Add checks for type any, but only on non-test files - Disable react-hooks/exhaustive-deps, since we're already disabling it in a few files and other plugins also have it turned off * Cover uncovered lines in engines_table and telemetry tests * Fixed TS warnings in E2E tests (#17) * Feedback: Convert static CSS values to EUI variables where possible * Feedback: Flatten nested CSS where possible - Prefer setting CSS class overrides on individual EUI components, not on a top-level page + Change CSS class casing from kebab-case to camelCase to better match EUI/Kibana + Remove unnecessary .euiPageContentHeader margin-bottom override by changing the panelPaddingSize of euiPageContent + Decrease engine overview table padding on mobile * Refactor out components shared with Workplace Search (#18) * Move getUserName helper to shared - in preparation for Workplace Search plugin also using this helper * Move Setup Guide layout to a shared component * Setup Guide: add extra props for standard/native auth links Note: It's possible this commit may be unnecessary if we can publish shared Enterprise Search security mode docs * Update copy per feedback from copy team * Address various telemetry issues - saved objects: removing indexing per #43673 - add schema and generate json per #64942 - move definitions over to collectors since saved objects is mostly empty at this point, and schema throws an error when it imports an obj instead of being defined inline - istanbul ignore saved_objects file since it doesn't have anything meaningful to test but was affecting code coverage * Disable plugin access if a normal user does not have access to App Search (#19) * Set up new server security dependency and configs * Set up access capabilities * Set up checkAccess helper/caller * Remove NoUserState component from the public UI - Since this is now being handled by checkAccess / normal users should never see the plugin at all if they don't have an account/access, the component is no longer needed * Update server routes to account for new changes - Remove login redirect catch from routes, since the access helper should now handle that for most users by disabling the plugin (superusers will see a generic cannot connect/error screen) - Refactor out new config values to a shared mock * Refactor Enterprise Search http call to hit/return new internal API endpoint + pull out the http call to a separate library for upcoming public URL work (so that other files can call it directly as well) * [Discussion] Increase timeout but add another warning timeout for slow servers - per recommendation/convo with Brandon * Register feature control * Remove no_as_account from UI telemetry - since we're no longer tracking that in the UI * Address PR feedback - isSuperUser check * Public URL support for Elastic Cloud (#21) * Add server-side public URL route - Per feedback from Kibana platform team, it's not possible to pass info from server/ to public/ without a HTTP call :[ * Update MockRouter for routes without any payload/params * Add client-side helper for calling the new public URL API + API seems to return a URL a trailing slash, which we need to omit * Update public/plugin.ts to check and set a public URL - relies on this.hasCheckedPublicUrl to only make the call once per page load instead of on every page nav * Fix failing feature control tests - Split up scenario cases as needed - Add plugin as an exception alongside ML & Monitoring * Address PR feedback - version: kibana - copy edits - Sass vars - code cleanup * Casing feedback: change all plugin registration IDs from snake_case to camelCase - note: current remainng snake_case exceptions are telemetry keys - file names and api endpoints are snake_case per conventions * Misc security feedback - remove set - remove unnecessary capabilities registration - telemetry namespace agnostic * Security feedback: add warn logging to telemetry collector see https://github.com/elastic/kibana/pull/66922#discussion_r451215760 - add if statement - pass log dependency around (this is kinda medium, should maybe refactor) - update tests - move test file comment to the right file (was meant for telemetry route file) * Address feedback from Pierre - Remove unnecessary ServerConfigType - Remove unnecessary uiCapabilities - Move registerTelemetryRoute / SavedObjectsServiceStart workaround - Remove unnecessary license optional chaining * PR feedback Address type/typos * Fix telemetry API call returning 415 on Chrome - I can't even?? I swear charset=utf-8 fixed the same error a few weeks ago * Fix failing tests * Update Enterprise Search functional tests (without host) to run on CI - Fix incorrect navigateToApp slug (hadn't realized this was a URL, not an ID) - Update without_host_configured tests to run without API key - Update README * Address PR feedback from Pierre - remove unnecessary authz? - remove unnecessary content-type json headers - add loggingSystemMock.collect(mockLogger).error assertion - reconstrcut new MockRouter on beforeEach for better sandboxing - fix incorrect describe()s -should be it() - pull out reusable mockDependencies helper (renamed/extended from mockConfig) for tests that don't particularly use config/log but still want to pass type definitions - Fix comment copy Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com> Co-authored-by: Chris Cressman <chris@chriscressman.com> Co-authored-by: scottybollinger <scotty.bollinger@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 22:10:31 +02:00
# Enterprise Search
Split up and clarify Enterprise Search codeowners (#76580) @elastic/enterprise-search-frontend is a shared team of both app-search-frontend and workplace-search-frontend, but combining it into one group means only 1 reviewer is required (as opposed to 1 per team).
2020-09-02 23:53:58 +02:00
# Shared
Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (#84713)
2020-12-01 23:59:27 +01:00
/x-pack/plugins/enterprise_search/* @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/common/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/public/* @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/public/applications/* @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/public/applications/enterprise_search/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/public/applications/shared/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/public/applications/__mocks__/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/* @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/lib/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/__mocks__/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/collectors/enterprise_search/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/collectors/lib/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/routes/enterprise_search/ @elastic/enterprise-search-frontend
/x-pack/plugins/enterprise_search/server/saved_objects/enterprise_search/ @elastic/enterprise-search-frontend
Split up and clarify Enterprise Search codeowners (#76580) @elastic/enterprise-search-frontend is a shared team of both app-search-frontend and workplace-search-frontend, but combining it into one group means only 1 reviewer is required (as opposed to 1 per team).
2020-09-02 23:53:58 +02:00
/x-pack/test/functional_enterprise_search/ @elastic/enterprise-search-frontend
Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (#84713)
2020-12-01 23:59:27 +01:00
# App Search
/x-pack/plugins/enterprise_search/public/applications/app_search/ @elastic/app-search-frontend
/x-pack/plugins/enterprise_search/server/routes/app_search/ @elastic/app-search-frontend
/x-pack/plugins/enterprise_search/server/collectors/app_search/ @elastic/app-search-frontend
/x-pack/plugins/enterprise_search/server/saved_objects/app_search/ @elastic/app-search-frontend
# Workplace Search
/x-pack/plugins/enterprise_search/public/applications/workplace_search/ @elastic/workplace-search-frontend
/x-pack/plugins/enterprise_search/server/routes/workplace_search/ @elastic/workplace-search-frontend
/x-pack/plugins/enterprise_search/server/collectors/workplace_search/ @elastic/workplace-search-frontend
/x-pack/plugins/enterprise_search/server/saved_objects/workplace_search/ @elastic/workplace-search-frontend
New Enterprise Search Kibana plugin (#66922) * Initial App Search in Kibana plugin work - Initializes a new platform plugin that ships out of the box w/ x-pack - Contains a very basic front-end that shows AS engines, error states, or a Setup Guide - Contains a very basic server that remotely calls the AS internal engines API and returns results * Update URL casing to match Kibana best practices - URL casing appears to be snake_casing, but kibana.json casing appears to be camelCase * Register App Search plugin in Home Feature Catalogue * Add custom App Search in Kibana logo - I haven't had much success in surfacing a SVG file via a server-side endpoint/URL, but then I realized EuiIcon supports passing in a ReactElement directly. Woo! * Fix appSearch.host config setting to be optional - instead of crashing folks on load * Rename plugin to Enterprise Search - per product decision, URL should be enterprise_search/app_search and Workplace Search should also eventually live here - reorganize folder structure in anticipation for another workplace_search plugin/codebase living alongside app_search - rename app.tsx/main.tsx to a standard top-level index.tsx (which will contain top-level routes/state) - rename AS->ES files/vars where applicable - TODO: React Router * Set up React Router URL structure * Convert showSetupGuide action/flag to a React Router link - remove showSetupGuide flag - add a new shared helper component for combining EuiButton/EuiLink with React Router behavior (https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51) * Implement Kibana Chrome breadcrumbs - create shared helper (WS will presumably also want this) for generating EUI breadcrumb objects with React Router links+click behavior - create React component that calls chrome.setBreadcrumbs on page mount - clean up type definitions - move app-wide props to IAppSearchProps and update most pages/views to simply import it instead of calling their own definitions * Added server unit tests (#2) * Added unit test for server * PR Feedback * Refactor top-level Kibana props to a global context state - rather them passing them around verbosely as props, the components that need them should be able to call the useContext hook + Remove IAppSearchProps in favor of IKibanaContext + Also rename `appSearchUrl` to `enterpriseSearchUrl`, since this context will contained shared/Kibana-wide values/actions useful to both AS and WS * Added unit tests for public (#4) * application.test.ts * Added Unit Test for EngineOverviewHeader * Added Unit Test for generate_breadcrumbs * Added Unit Test for set_breadcrumb.tsx * Added a unit test for link_events - Also changed link_events.tsx to link_events.ts since it's just TS, no React - Modified letBrowserHandleEvent so it will still return a false boolean when target is blank * Betterize these tests Co-Authored-By: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Add UI telemetry tracking to AS in Kibana (#5) * Set up Telemetry usageCollection, savedObjects, route, & shared helper - The Kibana UsageCollection plugin handles collecting our telemetry UI data (views, clicks, errors, etc.) and pushing it to elastic's telemetry servers - That data is stored in incremented in Kibana's savedObjects lib/plugin (as well as mapped) - When an end-user hits a certain view or action, the shared helper will ping the app search telemetry route which increments the savedObject store * Update client-side views/links to new shared telemetry helper * Write tests for new telemetry files * Implement remaining unit tests (#7) * Write tests for React Router+EUI helper components * Update generate_breadcrumbs test - add test suite for generateBreadcrumb() itself (in order to cover a missing branch) - minor lint fixes - remove unnecessary import from set_breadcrumbs test * Write test for get_username util + update test to return a more consistent falsey value (null) * Add test for SetupGuide * [Refactor] Pull out various Kibana context mocks into separate files - I'm creating a reusable useContext mock for shallow()ed enzyme components + add more documentation comments + examples * Write tests for empty state components + test new usecontext shallow mock * Empty state components: Add extra getUserName branch test * Write test for app search index/routes * Write tests for engine overview table + fix bonus bug * Write Engine Overview tests + Update EngineOverview logic to account for issues found during tests :) - Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s) - hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno) * Refactor EngineOverviewHeader test to use shallow + to full coverage - missed adding this test during telemetry work - switching to shallow and beforeAll reduces the test time from 5s to 4s! * [Refactor] Pull out React Router history mocks into a test util helper + minor refactors/updates * Add small tests to increase branch coverage - mostly testing fallbacks or removing fallbacks in favor of strict type interface - these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable * Address larger tech debt/TODOs (#8) * Fix optional chaining TODO - turns out my local Prettier wasn't up to date, completely my bad * Fix constants TODO - adds a common folder/architecture for others to use in the future * Remove TODO for eslint-disable-line and specify lint rule being skipped - hopefully that's OK for review, I can't think of any other way to sanely do this without re-architecting the entire file or DDoSing our API * Add server-side logging to route dependencies + add basic example of error catching/logging to Telemetry route + [extra] refactor mockResponseFactory name to something slightly easier to read * Move more Engines Overview API logic/logging to server-side - handle data validation in the server-side - wrap server-side API in a try/catch to account for fetch issues - more correctly return 2xx/4xx statuses and more correctly deal with those responses in the front-end - Add server info/error/debug logs (addresses TODO) - Update tests + minor refactors/cleanup - remove expectResponseToBe200With helper (since we're now returning multiple response types) and instead make mockResponse var name more readable - one-line header auth - update tests with example error logs - update schema validation for `type` to be an enum of `indexed`/`meta` (more accurately reflecting API) * Per telemetry team feedback, rename usageCollection telemetry mapping name to simpler 'app_search' - since their mapping already nests under 'kibana.plugins' - note: I left the savedObjects name with the '_telemetry' suffix, as there very well may be a use case for top-level generic 'app_search' saved objects * Update Setup Guide installation instructions (#9) Co-authored-by: Chris Cressman <chris@chriscressman.com> * [Refactor] DRY out route test helper * [Refactor] Rename public/test_utils to public/__mocks__ - to better follow/use jest setups and for .mock.ts suffixes * Add platinum licensing check to Meta Engines table/call (#11) * Licensing plugin setup * Add LicensingContext setup * Update EngineOverview to not hit meta engines API on platinum license * Add Jest test helpers for future shallow/context use * Update plugin to use new Kibana nav + URL update (#12) * Update new nav categories to add Enterprise Search + update plugin to use new category - per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability - Run `node scripts/check_published_api_changes.js --accept` since this new category affects public API * [URL UPDATE] Change '/app/enterprise_search/app_search' to '/app/app_search' - This needs to be done because App Search and Workplace search *have* to be registered as separate plugins to have 2 distinct nav links - Currently Kibana doesn't support nested app names (see: https://github.com/elastic/kibana/issues/59190) but potentially will in the future - To support this change, we need to update applications/index.tsx to NOT handle '/app/enterprise_search' level routing, but instead accept an async imported app component (e.g. AppSearch, WorkplaceSearch). - AppSearch should now treat its router as root '/' instead of '/app_search' - (Addl) Per Josh Dover's recommendation, switch to `<Router history={params.history}>` from `<BrowserRouter basename={params.appBasePath}>` since they're deprecating appBasePath * Update breadcrumbs helper to account for new URLs - Remove path for Enterprise Search breadcrumb, since '/app/enterprise_search' will not link anywhere meaningful for the foreseeable future, so the Enterprise Search root should not go anywhere - Update App Search helper to go to root path, per new React Router setup Test changes: - Mock custom basepath for App Search tests - Swap enterpriseSearchBreadcrumbs and appSearchBreadcrumbs test order (since the latter overrides the default mock) * Add create_first_engine_button telemetry tracking to EmptyState * Switch plugin URLs back to /app/enterprise_search/app_search Now that https://github.com/elastic/kibana/pull/66455 has been merged in :tada: * Add i18n formatted messages / translations (#13) * Add i18n provider and formatted/i18n translated messages * Update tests to account for new I18nProvider context + FormattedMessage components - Add new mountWithContext helper that provides all contexts+providers used in top-level app - Add new shallowWithIntl helper for shallow() components that dive into FormattedMessage * Format i18n dates and numbers + update some mock tests to not throw react-intl invalid date messages * Update EngineOverviewHeader to disable button on prop * Address review feedback (#14) * Fix Prettier linting issues * Escape App Search API endpoint URLs - per PR feedback - querystring should automatically encodeURIComponent / escape query param strings * Update server plugin.ts to use getStartServices() rather than storing local references from start() - Per feedback: https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications - Note: savedObjects.registerType needs to be outside of getStartServices, or an error is thrown - Side update to registerTelemetryUsageCollector to simplify args - Update/fix tests to account for changes * E2E testing (#6) * Wired up basics for E2E testing * Added version with App Search * Updated naming * Switched configuration around * Added concept of 'fixtures' * Figured out how to log in as the enterprise_search user * Refactored to use an App Search service * Added some real tests * Added a README * Cleanup * More cleanup * Error handling + README updatre * Removed unnecessary files * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_table.tsx Co-authored-by: Constance <constancecchen@users.noreply.github.com> * PR feedback - updated README * Additional lint fixes Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Add README and CODEOWNERS (#15) * Add plugin README and CODEOWNERS * Fix Typescript errors (#16) * Fix public mocks * Fix empty states types * Fix engine table component errors * Fix engine overview component errors * Fix setup guide component errors - SetBreadcrumbs will be fixed in a separate commit * Fix App Search index errors * Fix engine overview header component errors * Fix applications context index errors * Fix kibana breadcrumb helper errors * Fix license helper errors * :exclamation: Refactor React Router EUI link/button helpers - in order to fix typescript errors - this changes the component logic significantly to a react render prop, so that the Link and Button components can have different types - however, end behavior should still remain the same * Fix telemetry helper errors * Minor unused var cleanup in plugin files * Fix telemetry collector/savedobjects errors * Fix MockRouter type errors and add IRouteDependencies export - routes will use IRouteDependencies in the next few commits * Fix engines route errors * Fix telemetry route errors * Remove any type from source code - thanks to Scotty for the inspiration * Add eslint rules for Enterprise Search plugin - Add checks for type any, but only on non-test files - Disable react-hooks/exhaustive-deps, since we're already disabling it in a few files and other plugins also have it turned off * Cover uncovered lines in engines_table and telemetry tests * Fixed TS warnings in E2E tests (#17) * Feedback: Convert static CSS values to EUI variables where possible * Feedback: Flatten nested CSS where possible - Prefer setting CSS class overrides on individual EUI components, not on a top-level page + Change CSS class casing from kebab-case to camelCase to better match EUI/Kibana + Remove unnecessary .euiPageContentHeader margin-bottom override by changing the panelPaddingSize of euiPageContent + Decrease engine overview table padding on mobile * Refactor out components shared with Workplace Search (#18) * Move getUserName helper to shared - in preparation for Workplace Search plugin also using this helper * Move Setup Guide layout to a shared component * Setup Guide: add extra props for standard/native auth links Note: It's possible this commit may be unnecessary if we can publish shared Enterprise Search security mode docs * Update copy per feedback from copy team * Address various telemetry issues - saved objects: removing indexing per #43673 - add schema and generate json per #64942 - move definitions over to collectors since saved objects is mostly empty at this point, and schema throws an error when it imports an obj instead of being defined inline - istanbul ignore saved_objects file since it doesn't have anything meaningful to test but was affecting code coverage * Disable plugin access if a normal user does not have access to App Search (#19) * Set up new server security dependency and configs * Set up access capabilities * Set up checkAccess helper/caller * Remove NoUserState component from the public UI - Since this is now being handled by checkAccess / normal users should never see the plugin at all if they don't have an account/access, the component is no longer needed * Update server routes to account for new changes - Remove login redirect catch from routes, since the access helper should now handle that for most users by disabling the plugin (superusers will see a generic cannot connect/error screen) - Refactor out new config values to a shared mock * Refactor Enterprise Search http call to hit/return new internal API endpoint + pull out the http call to a separate library for upcoming public URL work (so that other files can call it directly as well) * [Discussion] Increase timeout but add another warning timeout for slow servers - per recommendation/convo with Brandon * Register feature control * Remove no_as_account from UI telemetry - since we're no longer tracking that in the UI * Address PR feedback - isSuperUser check * Public URL support for Elastic Cloud (#21) * Add server-side public URL route - Per feedback from Kibana platform team, it's not possible to pass info from server/ to public/ without a HTTP call :[ * Update MockRouter for routes without any payload/params * Add client-side helper for calling the new public URL API + API seems to return a URL a trailing slash, which we need to omit * Update public/plugin.ts to check and set a public URL - relies on this.hasCheckedPublicUrl to only make the call once per page load instead of on every page nav * Fix failing feature control tests - Split up scenario cases as needed - Add plugin as an exception alongside ML & Monitoring * Address PR feedback - version: kibana - copy edits - Sass vars - code cleanup * Casing feedback: change all plugin registration IDs from snake_case to camelCase - note: current remainng snake_case exceptions are telemetry keys - file names and api endpoints are snake_case per conventions * Misc security feedback - remove set - remove unnecessary capabilities registration - telemetry namespace agnostic * Security feedback: add warn logging to telemetry collector see https://github.com/elastic/kibana/pull/66922#discussion_r451215760 - add if statement - pass log dependency around (this is kinda medium, should maybe refactor) - update tests - move test file comment to the right file (was meant for telemetry route file) * Address feedback from Pierre - Remove unnecessary ServerConfigType - Remove unnecessary uiCapabilities - Move registerTelemetryRoute / SavedObjectsServiceStart workaround - Remove unnecessary license optional chaining * PR feedback Address type/typos * Fix telemetry API call returning 415 on Chrome - I can't even?? I swear charset=utf-8 fixed the same error a few weeks ago * Fix failing tests * Update Enterprise Search functional tests (without host) to run on CI - Fix incorrect navigateToApp slug (hadn't realized this was a URL, not an ID) - Update without_host_configured tests to run without API key - Update README * Address PR feedback from Pierre - remove unnecessary authz? - remove unnecessary content-type json headers - add loggingSystemMock.collect(mockLogger).error assertion - reconstrcut new MockRouter on beforeEach for better sandboxing - fix incorrect describe()s -should be it() - pull out reusable mockDependencies helper (renamed/extended from mockConfig) for tests that don't particularly use config/log but still want to pass type definitions - Fix comment copy Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com> Co-authored-by: Chris Cressman <chris@chriscressman.com> Co-authored-by: scottybollinger <scotty.bollinger@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 22:10:31 +02:00
Reorganize codeowners and define Elasticsearch UI ownership. (#28873)
2019-01-17 20:18:28 +01:00
# Elasticsearch UI
Move ownerships of home, dev tools and discover (#62612) * move ownership * fix es-ui ownership
2020-04-06 18:36:22 +02:00
/src/plugins/dev_tools/ @elastic/es-ui
[Console] Move out of legacy + migrate server side to New Platform (#55690) * Initial move of public and setup of server skeleton * Fix public paths and types * Use new usage stats dependency directly in tracker also mark as an optional dependency * WiP on getting server side working * Restore proxy route behaviour for base case, still need to test custom proxy and SSL * Add new type and lib files * Clean up legacy start up code and add comment about issue in kibana.yml config for console * Move console_extensions to new platform and introduce ConsoleSetup API for extending autocomplete Add TODO regarding exposing legacy ES config * Re-introduce injected elasticsearch variable and use it in public * Don't pass stateSetter prop through to checkbox * Refactor of proxy route (split into separate files). Easier testing for now. Refactor file name of request.ts -> proxy_request.ts. This is consistent with the exported function now Started fixing server side tests for the proxy route - Migrated away from sinon - Completed the body.js -> body.test.ts. Still have to do the rest * headers.js test -> headers.test.ts and moved some of the proxy route mocking logic to a common space * Finish migration of rest of proxy route test away from hapi Add test for custom route validation * Bring console application in line with https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications Change log from info level to debug level for console_extensions plugin * Update i18nrc file for console * Add setHeaders when passing back error response Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-30 10:51:02 +01:00
/src/plugins/console/ @elastic/es-ui
I accidentally removed this line in a recent PR (#83201)
2020-11-11 22:36:10 +01:00
/src/plugins/es_ui_shared/ @elastic/es-ui
Remove legacy plugins support (#77599) * remove ALL the things. * adapt some types and tests * restore ensureValidConfiguration * fix legacy service tests * adapt uiRender mixin * remove legacy types * update generated doc * restore legacy plugin schema * update generated doc * remove remaining code of x-pack/legacy * adapt imports due to merge * cleanup CODEOWNERS * cleanup gitignore & i18nrc * cleanup tsconfig.json * remove unused i18n keys * add back `"legacy/plugins/**/*",` to tsconfig until legacy space plugin is deleted * fix create_jest_config * remove references from eslintrc * more eslint cleanup * remove `x-pack/index.js` * fix xpack gulp scripts * fix bug with default + named imports from boom * remove rules from eslintrc * remove LegacyInternals * review comments * update generated doc * cleanup legacy metadatas * revert changes to eslintrc * update generated doc
2020-09-23 09:52:51 +02:00
/x-pack/plugins/cross_cluster_replication/ @elastic/es-ui
Move ILM out of legacy (#61915) * Rename IndexMgmtSetup to IndexManagementPluginSetup. * Remove unused fetch index template route and related tests. * Remove unnecessary custom styles.
2020-04-10 01:51:22 +02:00
/x-pack/plugins/index_lifecycle_management/ @elastic/es-ui
Update CODEOWNERS with ES-UI apps, including grok debugger. (#62045)
2020-04-01 18:36:48 +02:00
/x-pack/plugins/console_extensions/ @elastic/es-ui
/x-pack/plugins/grokdebugger/ @elastic/es-ui
/x-pack/plugins/index_management/ @elastic/es-ui
Extract License service from CCR and Watcher into license_api_guard plugin in x-pack (#95973) * Localize error messages.
2021-04-15 23:54:49 +02:00
/x-pack/plugins/license_api_guard/ @elastic/es-ui
Update CODEOWNERS with ES-UI apps, including grok debugger. (#62045)
2020-04-01 18:36:48 +02:00
/x-pack/plugins/license_management/ @elastic/es-ui
/x-pack/plugins/painless_lab/ @elastic/es-ui
/x-pack/plugins/remote_clusters/ @elastic/es-ui
/x-pack/plugins/rollup/ @elastic/es-ui
/x-pack/plugins/searchprofiler/ @elastic/es-ui
/x-pack/plugins/snapshot_restore/ @elastic/es-ui
[Upgrade Assistant] Move out of legacy folder (#58034) * Create x-pack/plugins skeleton for upgrade assistant * Move public folder contents Move the public folder of Upgrade Assistant and migrate public to use HttpSetup (remove axios) * Include stylesheets in public * Move server side out of legacy Begin migration of Reindex worker to new platform Move imports around so that it satsifies new platform constraints like not importing server side code (even types) in client. * Updated the routes with new dependencies and removed server shim * Fix router unit tests * Fix server lib tests After changing function signatures for the reindex server factory (and others) all of the tests needed to be revisited and brought in line with the new APIs. Also used core/server mocks where appropriate * Clean up types issues * Fix setting credentials on request header * Removed the security plugin from Upgrade Assistant The security plugin is a potential future consumer of the Upgrade Assistant's deprecation feature and we would therefore not want to create a circular depedency here. We pull in the licensing plugin rather (as it is less likely that we will depend on that) and use it to determine whether security is available and enabled. * Migrate to config to new platform config xpack.upgrade_assistant.enabled * Remove unused types * Fix import issue * Move upgrade assistant back to Elasticsearch management section * Update dotfiles Added elasticsearch ui team as upgrade assistant code owner Updated i18nrc.json path * Alphabetical ordering in xpack/i18nrc.json * Implemented PR feedback Renamed callCluster -> callAsUser to be more consistent with platform naming. Added comment about why we are not using security plugin directly inside of Upgrade Assistant. Fixed long path imports and use 'src/core/..' throughout. Fixed import ordering. Renamed variables inside of telemetry lib. * Revert to longer import path In plugin.ts importing from 'kibana/server' or 'src/core/server' results in a module not found error. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-25 15:31:04 +01:00
/x-pack/plugins/upgrade_assistant/ @elastic/es-ui
[Watcher] Move out of legacy (#54752) * Moved out of legacy folder * First iteration of watcher plugin that renders * Move create Timebuckets to plugin root Update route registration and fix license checking for NP * Re-enable Component integration tests * Minor fix for data deserializer in api.ts * Slight logic refactor, more defensive plugin startup * Re-add legacy folder for SCSS pipeline * Remove duplicate style sheet * Fix type issue with TimeBuckets export * Update license management routing logic (issued warning for using basepath on navigating away from license management) Remove commented out code in watcher * More defensive plugin registration * Fix i18n issues and restore registration of feature on home view * Remove watcher license error check copy * Restore license error message in watcher * Fix mock context value Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-01-23 15:35:36 +01:00
/x-pack/plugins/watcher/ @elastic/es-ui
Ingest Node Pipelines UI (#62321)
2020-04-30 21:52:14 +02:00
/x-pack/plugins/ingest_pipelines/ @elastic/es-ui
[ES UI Shared] Remove 'brace' from es_ui_shared public (#78033) * major wip * major wip * fix worker creation leak * just copy the file over for now * Remove xjson from static and from es_ui_shared entirely - moved expand and collapse logic back to es_ui_shared. It has nothing to do with ace - refactor the useXJson hook which bundled XJsonMode with it. This was convenient but ultimately inflates the amount of code Kibana needs to first load up in the client. Users will need to import XJsonMode and instantiate it when they want to use it. Updated existing usage. - Cleaned up Monaco namespace from es_ui_shared because of how useXJsonMode was refactored -- no longer exporting an editor specific instance means this code does not know about anything to do with code editors so it is decoupled from ace and monaco. * fix export of collapse and expand string literals Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-24 16:02:14 +02:00
/packages/kbn-ace/ @elastic/es-ui
/packages/kbn-monaco/ @elastic/es-ui
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
#CC# /x-pack/plugins/console_extensions/ @elastic/es-ui
#CC# /x-pack/plugins/cross_cluster_replication/ @elastic/es-ui
[Endpoint] Adding the endpoint teams for relevant directories (#57920) * Adding the endpoint teams for relevant directories * Using combined team
2020-02-19 00:15:45 +01:00
[SECURITY] Rename siem plugin to security_solution (#67902) * rename siem to security_solution * rename siem to security solution inside of code * rename translation keys * fix snapshot * replace siem for security solution in tutorial * missing translation to be renamed * fix types for api test integration * updates runner file to match the new path * change category for kibana settings * miss renaming in advance settings * fixes cypress tests * fix api integration test * fix new translation * fix unit test * update translation i18n * update translation i18n II Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
2020-06-04 11:35:13 +02:00
# Security Solution
Update security solution codeowners (#89038) * move the code coverage owner line for security solution next to the other lines about security solution * replace @elastic/siem with @elastic/security-solution and remove the duplicate code coverage owner for security_solution * remove elastic/endpoint-app-team and cleanup directories that no longer exist, and reorder lines * added case_api_integration code owners Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-08 22:05:26 +01:00
/x-pack/test/endpoint_api_integration_no_ingest/ @elastic/security-solution
/x-pack/test/security_solution_endpoint/ @elastic/security-solution
/x-pack/test/functional/es_archives/endpoint/ @elastic/security-solution
/x-pack/test/plugin_functional/plugins/resolver_test/ @elastic/security-solution
/x-pack/test/plugin_functional/test_suites/resolver/ @elastic/security-solution
/x-pack/plugins/security_solution/ @elastic/security-solution
/x-pack/test/detection_engine_api_integration @elastic/security-solution
/x-pack/test/lists_api_integration @elastic/security-solution
/x-pack/test/api_integration/apis/security_solution @elastic/security-solution
#CC# /x-pack/plugins/security_solution/ @elastic/security-solution
# Security Solution sub teams
/x-pack/plugins/case @elastic/security-threat-hunting
[Security Solution][RAC][Timeline] Timeline plugin skeleton and test plugin harness (#95683) * [RAC][Security Solution] Initial timeline and test plugin harness * Change plugin name from timeline to timelines
2021-03-31 21:33:19 +02:00
/x-pack/plugins/timelines @elastic/security-threat-hunting
Update security solution codeowners (#89038) * move the code coverage owner line for security solution next to the other lines about security solution * replace @elastic/siem with @elastic/security-solution and remove the duplicate code coverage owner for security_solution * remove elastic/endpoint-app-team and cleanup directories that no longer exist, and reorder lines * added case_api_integration code owners Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-08 22:05:26 +01:00
/x-pack/test/case_api_integration @elastic/security-threat-hunting
/x-pack/plugins/lists @elastic/security-detections-response
Added Security Intelligence And Analytics for prepackaged_rules (#58808)
2020-02-28 16:38:23 +01:00
# Security Intelligence And Analytics
[SECURITY] Rename siem plugin to security_solution (#67902) * rename siem to security_solution * rename siem to security solution inside of code * rename translation keys * fix snapshot * replace siem for security solution in tutorial * missing translation to be renamed * fix types for api test integration * updates runner file to match the new path * change category for kibana settings * miss renaming in advance settings * fixes cypress tests * fix api integration test * fix new translation * fix unit test * update translation i18n * update translation i18n II Co-authored-by: Gloria Hornero <snootchie.boochies@gmail.com>
2020-06-04 11:35:13 +02:00
/x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules @elastic/security-intelligence-analytics
Update CODEOWNERS for design (again) (#75801)
2020-08-24 23:03:25 +02:00
[Security Solution] Init Osquery plugin (#87109)
2021-01-28 08:24:55 +01:00
# Security Asset Management
/x-pack/plugins/osquery @elastic/security-asset-management
Update CODEOWNERS for design (again) (#75801)
2020-08-24 23:03:25 +02:00
# Design (at the bottom for specificity of SASS files)
**/*.scss @elastic/kibana-design
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
#CC# /packages/kbn-ui-framework/ @elastic/kibana-design
Update CODEOWNERS for design (again) (#75801)
2020-08-24 23:03:25 +02:00
# Observability design
/x-pack/plugins/apm/**/*.scss @elastic/observability-design
/x-pack/plugins/infra/**/*.scss @elastic/observability-design
[Fleet] Move ingestManager plugin to fleet (#82886)
2020-11-09 17:07:04 +01:00
/x-pack/plugins/fleet/**/*.scss @elastic/observability-design
Update CODEOWNERS for design (again) (#75801)
2020-08-24 23:03:25 +02:00
/x-pack/plugins/observability/**/*.scss @elastic/observability-design
remove legacy security plugin (#75648) * remove legacy security plugin * remove legacy plugin check * adapt mocha tests * update CODEOWNERS
2020-09-17 18:00:04 +02:00
/x-pack/plugins/monitoring/**/*.scss @elastic/observability-design
Update CODEOWNERS for design (again) (#75801)
2020-08-24 23:03:25 +02:00
# Ent. Search design
/x-pack/plugins/enterprise_search/**/*.scss @elastic/ent-search-design
# Security design
/x-pack/plugins/endpoint/**/*.scss @elastic/security-design
/x-pack/plugins/security_solution/**/*.scss @elastic/security-design
[QA][Code Coverage] Coverage teams lookup w/o Additional Config (#77111) * [QA][Code Coverage] Coverage teams lookup * Fix test per cr. * Drop unused fn's. * Add integration test to prove that the sys does indeed strip the CC prefix and still walks the fs. * Cleanup "todo" list. * Use import, like Dima's previous suggestion. * Add coverage teams only definitions to CODEOWNERS per Lee. * Add coverage teams for logstash, reporting and security. * Update description. * Update names per Lee. * Drop mutation. * Fix dupes. * Add the file check, per Dima * Add more teams * Update regex to only match on "build/" and add test. * More teams * More teams * Add print statement of the canonical timestamp, so we can lookup stuff in gcp during errors. * CR fixups
2020-09-28 23:27:02 +02:00
# Logstash
#CC# /x-pack/plugins/logstash/ @elastic/logstash
# Reporting
#CC# /x-pack/plugins/reporting/ @elastic/kibana-reporting-services
Update security solution codeowners (#89038) * move the code coverage owner line for security solution next to the other lines about security solution * replace @elastic/siem with @elastic/security-solution and remove the duplicate code coverage owner for security_solution * remove elastic/endpoint-app-team and cleanup directories that no longer exist, and reorder lines * added case_api_integration code owners Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-08 22:05:26 +01:00
Reference in a new issue Copy permalink