2018-09-14 20:46:03 +02:00
|
|
|
# GitHub CODEOWNERS definition
|
2019-01-17 20:18:28 +01:00
|
|
|
# Identify which groups will be pinged by changes to different parts of the codebase.
|
|
|
|
# For more info, see https://help.github.com/articles/about-codeowners/
|
2018-09-14 20:46:03 +02:00
|
|
|
|
2019-09-17 20:57:53 +02:00
|
|
|
# App
|
Drilldowns (#61219)
* Add drilldown wizard components
* Dynamic actions (#58216)
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638)
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653)
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823)
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834)
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854)
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876)
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885)
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938)
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977)
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099)
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103)
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104)
* Drilldowns review 1 (#60139)
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264)
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336)
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339)
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357)
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309)
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371)
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510)
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
* fix: 🐛 pass in uiActions to visualize_embeddable
* fix: 🐛 correctly register action
* fix: 🐛 fix type error
* chore: 🤖 remove unused translations
* Dynamic actions to xpack (#62647)
* feat: 🎸 set up sample action factory provider
* feat: 🎸 create dashboard_enhanced plugin
* feat: 🎸 add EnhancedEmbeddable interface
* refactor: 💡 move DynamicActionManager to x-pack
* feat: 🎸 connect dynamic action manager to embeddable life-cycle
* test: 💍 fix Jest tests after refactor
* fix: 🐛 fix type error
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* refactor: 💡 move action factories to x-pack (#63190)
* refactor: 💡 move action factories to x-pack
* fix: 🐛 use correct plugin embeddable deps
* test: 💍 fix Jest test after refactor
* chore: 🤖 remove kibana.yml flag (#62441)
* Panel top right (#63466)
* feat: 🎸 add PANEL_NOTIFICATION_TRIGGER
* feat: 🎸 add PanelNotificationsAction action
* test: 💍 add PanelNotificationsAction unit tests
* refactor: 💡 revert addTriggerAction() change
* style: 💄 remove unused import
* fix: 🐛 fix typecheck errors after merge
* support getHref in drilldowns (#63727)
* chore: 🤖 remove ui_actions storybook config
* update docs
* fix ts
* fix: 🐛 fix broken merge
* [Drilldowns] Dashboard to dashboard drilldown (#63108)
* partial progress on async loading / searching of dashboard titles
* feat: 🎸 make combobox full width
* filtering combobox polish
* storybook fix
* implement navigating to dashboard, seems like a type problem
* try navToApp
* filter out current dashboard
* rough draft linking to a dashboard
* remove note
* typefix
* fix navigation from dashboard to dashboard
except for back button - that would be addressed separatly
* partial progress getting filters from action data
* fix issue with getIndexPatterns undefined
we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull
* fix filter / time passing into url
* typefix
* dashboard to dashboard drilldown functional test and back button fix
* documentation update
* chore clean-ups
fix type
* basic unit test for dashboard drilldown
* remove test todos
decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env
* remove config
* improve back button with filter comparison tweak
* dashboard filters/date option off by default
* revert change to config/kibana.yml
* remove unneeded comments
* use default time range as appropriate
* fix type, add filter icon, add text
* fix test
* change how time range is restored and improve back button for drilldowns
* resolve conflicts
* fix async compile issue
* remove redundant test
* wip
* wip
* fix
* temp skip tests
* fix
* handle missing dashboard edge case
* fix api
* refactor action filter creation utils
* updating
* updating docs
* improve
* fix storybook
* post merge fixes
* fix payload emitted in brush event
* properly export createRange action
* improve tests
* add test
* post merge fixes
* improve
* fix
* improve
* fix build
* wip getHref support
* implement getHref()
* give proper name to a story
* use sync start services
* update text
* fix types
* fix ts
* fix docs
* move clone below drilldowns (near replace)
* remove redundant comments
* refactor action filter creation utils
* updating
* updating docs
* fix payload emitted in brush event
* properly export createRange action
* some more updates
* fixing types
* ...
* inline EventData
* fix typescript in lens and update docs
* improve filters types
* docs
* merge
* @mdefazio review
* adjust actions order
* docs
* @stacey-gammon review
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
* fix docs
* nit fixes
* chore: 🤖 remove uiActions from Embeddable dependencies
* chore: 🤖 don't export ActionInternal from ui_actions
* test: 💍 remove uiActions deps in x-pack test mocks
* chore: 🤖 cleanup ui_actions types
* docs: ✏️ add JSDoc comment to addTriggerAction()
* docs: ✏️ regenerate docs
* Drilldown demo 2 (#64300)
* chore: 🤖 add example of Discover drilldown to sample plugin
* fix: 🐛 show drilldowns with higher "order" first
* feat: 🎸 add createStartServicesGetter() to /public kibana_util
* feat: 🎸 load index patterns in Discover drilldown
* feat: 🎸 add toggle for index pattern selection
* feat: 🎸 add spacer to separate unrelated config fields
* fix: 🐛 correctly configre setup core
* feat: 🎸 navigate to correct index pattern
* chore: 🤖 fix type check errors
* fix: 🐛 make index pattern select full width
* fix: 🐛 add getHref support
* feat: 🎸 add example plugin ability to X-Pack
* refactor: 💡 move Discover drilldown example to X-Pack
* feat: 🎸 add dashboard-to-url drilldown example
* feat: 🎸 add new tab support for URL drilldown
* feat: 🎸 add "hello world" drilldown example
* docs: ✏️ add README
* feat: 🎸 add getHref support
* chore: 🤖 cleanup after moving examples to X-Pack
* docs: ✏️ add to README.md info on how to find drilldowns
* feat: 🎸 store events in .enhancements field
* docs: ✏️ add comment to range trigger title
* refactor: 💡 move Configurable interface into kibana_utils
* chore: 🤖 simplify internal component types
* refactor: 💡 move registerDrilldwon() to advanced_ui_actions
* test: 💍 update functional test data
* merge
* docs: ✏️ make drilldown enhancement comment more general
* fix: 🐛 return public type from registerAction() call
* docs: ✏️ add comment to value click trigger title field
* docs: ✏️ improve comment
* fix: 🐛 use second argument of CollectConfigProps interface
* fix: 🐛 add workaround for Firefox rendering issue
See:
https://github.com/elastic/kibana/pull/61219/#pullrequestreview-402903330
* chore: 🤖 delete unused file
* fix: 🐛 import type from new location
* style: 💄 make generic type variable name sconsistent
* fix: 🐛 show "Create drilldown" only on dashboard
* test: 💍 add extra unit test for root embeddable type
* docs: ✏️ update generated docs
* chore: 🤖 add example warnings to sample drilldowns
* docs: ✏️ add links to example warnings
* feat: 🎸 add URL drilldown validation and https:// prefixing
* fix: 🐛 disable drilldowns for lens
* refactor: 💡 remove PlaceContext from DrilldownDefinition
* fix: 🐛 fix type check error
* feat: 🎸 show warning message if embeddable not provided
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
2020-05-04 16:11:20 +02:00
|
|
|
/x-pack/plugins/dashboard_enhanced/ @elastic/kibana-app
|
2020-06-17 10:31:16 +02:00
|
|
|
/x-pack/plugins/discover_enhanced/ @elastic/kibana-app
|
2020-04-15 12:22:37 +02:00
|
|
|
/x-pack/plugins/lens/ @elastic/kibana-app
|
2020-04-15 17:52:21 +02:00
|
|
|
/x-pack/plugins/graph/ @elastic/kibana-app
|
2020-03-13 17:55:21 +01:00
|
|
|
/src/plugins/dashboard/ @elastic/kibana-app
|
2020-08-13 19:38:57 +02:00
|
|
|
/src/plugins/dashboard/**/*.scss @elastic/kibana-core-ui-designers
|
2020-04-06 18:36:22 +02:00
|
|
|
/src/plugins/discover/ @elastic/kibana-app
|
2020-04-24 10:49:02 +02:00
|
|
|
/src/plugins/input_control_vis/ @elastic/kibana-app
|
2020-05-04 13:45:39 +02:00
|
|
|
/src/plugins/kibana_legacy/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_default_editor/ @elastic/kibana-app
|
2020-04-16 17:32:07 +02:00
|
|
|
/src/plugins/vis_type_markdown/ @elastic/kibana-app
|
2020-05-04 13:45:39 +02:00
|
|
|
/src/plugins/vis_type_metric/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_table/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_tagcloud/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_timelion/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_timeseries/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_vega/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_vislib/ @elastic/kibana-app
|
|
|
|
/src/plugins/vis_type_xy/ @elastic/kibana-app
|
|
|
|
/src/plugins/visualize/ @elastic/kibana-app
|
2020-04-06 18:36:22 +02:00
|
|
|
|
2019-06-14 16:00:32 +02:00
|
|
|
# App Architecture
|
2020-07-15 22:42:38 +02:00
|
|
|
/examples/bfetch_explorer/ @elastic/kibana-app-arch
|
|
|
|
/examples/dashboard_embeddable_examples/ @elastic/kibana-app-arch
|
|
|
|
/examples/demo_search/ @elastic/kibana-app-arch
|
2020-06-08 15:47:51 +02:00
|
|
|
/examples/developer_examples/ @elastic/kibana-app-arch
|
2020-07-15 22:42:38 +02:00
|
|
|
/examples/embeddable_examples/ @elastic/kibana-app-arch
|
|
|
|
/examples/embeddable_explorer/ @elastic/kibana-app-arch
|
|
|
|
/examples/state_container_examples/ @elastic/kibana-app-arch
|
|
|
|
/examples/ui_actions_examples/ @elastic/kibana-app-arch
|
|
|
|
/examples/ui_actions_explorer/ @elastic/kibana-app-arch
|
2020-03-17 20:27:10 +01:00
|
|
|
/examples/url_generators_examples/ @elastic/kibana-app-arch
|
|
|
|
/examples/url_generators_explorer/ @elastic/kibana-app-arch
|
2020-06-08 11:37:44 +02:00
|
|
|
/packages/elastic-datemath/ @elastic/kibana-app-arch
|
2020-07-15 22:42:38 +02:00
|
|
|
/packages/kbn-interpreter/ @elastic/kibana-app-arch
|
2020-03-17 20:27:10 +01:00
|
|
|
/src/plugins/advanced_settings/ @elastic/kibana-app-arch
|
2020-02-03 16:05:39 +01:00
|
|
|
/src/plugins/bfetch/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/data/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/embeddable/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/expressions/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/inspector/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/kibana_react/ @elastic/kibana-app-arch
|
2020-03-17 20:27:10 +01:00
|
|
|
/src/plugins/kibana_react/public/code_editor @elastic/kibana-canvas
|
2020-02-03 16:05:39 +01:00
|
|
|
/src/plugins/kibana_utils/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/management/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/navigation/ @elastic/kibana-app-arch
|
2020-03-17 20:27:10 +01:00
|
|
|
/src/plugins/share/ @elastic/kibana-app-arch
|
2020-02-03 16:05:39 +01:00
|
|
|
/src/plugins/ui_actions/ @elastic/kibana-app-arch
|
|
|
|
/src/plugins/visualizations/ @elastic/kibana-app-arch
|
2020-07-15 22:42:38 +02:00
|
|
|
/x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-arch
|
2020-03-17 20:27:10 +01:00
|
|
|
/x-pack/plugins/data_enhanced/ @elastic/kibana-app-arch
|
2020-07-15 22:42:38 +02:00
|
|
|
/x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-arch
|
|
|
|
/x-pack/plugins/ui_actions_enhanced/ @elastic/kibana-app-arch
|
2019-06-14 16:00:32 +02:00
|
|
|
|
2019-01-17 20:18:28 +01:00
|
|
|
# APM
|
2020-05-05 18:22:47 +02:00
|
|
|
/x-pack/plugins/apm/ @elastic/apm-ui
|
2020-08-13 17:44:22 +02:00
|
|
|
/x-pack/plugins/apm/**/*.scss @elastic/observability-design
|
2019-10-01 15:59:16 +02:00
|
|
|
/x-pack/test/functional/apps/apm/ @elastic/apm-ui
|
|
|
|
/src/legacy/core_plugins/apm_oss/ @elastic/apm-ui
|
2020-01-23 13:44:55 +01:00
|
|
|
/src/plugins/apm_oss/ @elastic/apm-ui
|
2020-06-16 17:24:40 +02:00
|
|
|
/src/apm.js @watson @vigneshshanmugam
|
2019-01-17 20:18:28 +01:00
|
|
|
|
|
|
|
# Beats
|
2019-06-18 20:45:53 +02:00
|
|
|
/x-pack/legacy/plugins/beats_management/ @elastic/beats
|
2019-01-17 20:18:28 +01:00
|
|
|
|
|
|
|
# Canvas
|
2020-05-06 02:52:56 +02:00
|
|
|
/x-pack/plugins/canvas/ @elastic/kibana-canvas
|
2020-08-13 19:38:57 +02:00
|
|
|
/x-pack/plugins/canvas/**/*.scss @elastic/kibana-core-ui-designers
|
2020-05-19 09:00:28 +02:00
|
|
|
/x-pack/test/functional/apps/canvas/ @elastic/kibana-canvas
|
2019-01-17 20:18:28 +01:00
|
|
|
|
2020-07-15 22:42:38 +02:00
|
|
|
# Core UI
|
|
|
|
# Exclude tutorials folder for now because they are not owned by Kibana app and most will move out soon
|
|
|
|
/src/plugins/home/public @elastic/kibana-core-ui
|
|
|
|
/src/plugins/home/server/*.ts @elastic/kibana-core-ui
|
|
|
|
/src/plugins/home/server/services/ @elastic/kibana-core-ui
|
|
|
|
# Exclude tutorial resources folder for now because they are not owned by Kibana app and most will move out soon
|
|
|
|
/src/legacy/core_plugins/kibana/public/home/*.ts @elastic/kibana-core-ui
|
2020-08-13 19:38:57 +02:00
|
|
|
/src/legacy/core_plugins/kibana/public/home/**/*.scss @elastic/kibana-core-ui-designers
|
2020-07-15 22:42:38 +02:00
|
|
|
/src/legacy/core_plugins/kibana/public/home/np_ready/ @elastic/kibana-core-ui
|
|
|
|
|
2020-02-11 16:27:35 +01:00
|
|
|
# Observability UIs
|
2019-10-16 10:10:42 +02:00
|
|
|
/x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui
|
2020-02-11 16:27:35 +01:00
|
|
|
/x-pack/plugins/infra/ @elastic/logs-metrics-ui
|
2020-08-13 17:44:22 +02:00
|
|
|
/x-pack/plugins/infra/**/*.scss @elastic/observability-design
|
2020-03-18 00:15:27 +01:00
|
|
|
/x-pack/plugins/ingest_manager/ @elastic/ingest-management
|
2020-08-13 17:44:22 +02:00
|
|
|
/x-pack/plugins/ingest_manager/**/*.scss @elastic/observability-design
|
2020-03-18 00:15:27 +01:00
|
|
|
/x-pack/legacy/plugins/ingest_manager/ @elastic/ingest-management
|
2020-07-01 16:04:21 +02:00
|
|
|
/x-pack/plugins/observability/ @elastic/observability-ui
|
2020-08-13 17:44:22 +02:00
|
|
|
/x-pack/plugins/observability/**/*.scss @elastic/observability-design
|
2020-02-20 14:05:21 +01:00
|
|
|
/x-pack/legacy/plugins/monitoring/ @elastic/stack-monitoring-ui
|
2020-04-30 21:59:35 +02:00
|
|
|
/x-pack/plugins/monitoring/ @elastic/stack-monitoring-ui
|
2020-04-15 18:48:16 +02:00
|
|
|
/x-pack/plugins/uptime @elastic/uptime
|
2019-05-17 19:18:01 +02:00
|
|
|
|
2019-02-01 12:18:12 +01:00
|
|
|
# Machine Learning
|
2019-06-18 20:45:53 +02:00
|
|
|
/x-pack/legacy/plugins/ml/ @elastic/ml-ui
|
2020-03-04 13:02:43 +01:00
|
|
|
/x-pack/plugins/ml/ @elastic/ml-ui
|
2019-09-18 10:20:47 +02:00
|
|
|
/x-pack/test/functional/apps/machine_learning/ @elastic/ml-ui
|
|
|
|
/x-pack/test/functional/services/machine_learning/ @elastic/ml-ui
|
|
|
|
/x-pack/test/functional/services/ml.ts @elastic/ml-ui
|
2020-04-06 18:49:23 +02:00
|
|
|
# ML team owns and maintains the transform plugin despite it living in the Elasticsearch management section.
|
|
|
|
/x-pack/plugins/transform/ @elastic/ml-ui
|
2019-11-22 14:46:57 +01:00
|
|
|
/x-pack/test/functional/apps/transform/ @elastic/ml-ui
|
|
|
|
/x-pack/test/functional/services/transform_ui/ @elastic/ml-ui
|
|
|
|
/x-pack/test/functional/services/transform.ts @elastic/ml-ui
|
2019-02-01 12:18:12 +01:00
|
|
|
|
2019-12-19 19:23:20 +01:00
|
|
|
# Maps
|
|
|
|
/x-pack/legacy/plugins/maps/ @elastic/kibana-gis
|
2020-04-15 17:52:21 +02:00
|
|
|
/x-pack/plugins/maps/ @elastic/kibana-gis
|
2019-12-19 19:23:20 +01:00
|
|
|
/x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis
|
|
|
|
/x-pack/test/functional/apps/maps/ @elastic/kibana-gis
|
|
|
|
/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
|
|
|
|
/x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis
|
|
|
|
|
2019-05-10 00:43:58 +02:00
|
|
|
# Operations
|
|
|
|
/src/dev/ @elastic/kibana-operations
|
|
|
|
/src/setup_node_env/ @elastic/kibana-operations
|
|
|
|
/src/optimize/ @elastic/kibana-operations
|
2019-10-21 21:58:37 +02:00
|
|
|
/packages/*eslint*/ @elastic/kibana-operations
|
|
|
|
/packages/*babel*/ @elastic/kibana-operations
|
|
|
|
/packages/kbn-dev-utils*/ @elastic/kibana-operations
|
|
|
|
/packages/kbn-es/ @elastic/kibana-operations
|
2020-02-13 03:42:42 +01:00
|
|
|
/packages/kbn-optimizer/ @elastic/kibana-operations
|
2019-10-21 21:58:37 +02:00
|
|
|
/packages/kbn-pm/ @elastic/kibana-operations
|
|
|
|
/packages/kbn-test/ @elastic/kibana-operations
|
2020-01-10 23:22:18 +01:00
|
|
|
/packages/kbn-ui-shared-deps/ @elastic/kibana-operations
|
2020-07-22 17:02:39 +02:00
|
|
|
/packages/kbn-es-archiver/ @elastic/kibana-operations
|
2019-12-06 08:23:48 +01:00
|
|
|
/src/legacy/server/keystore/ @elastic/kibana-operations
|
|
|
|
/src/legacy/server/pid/ @elastic/kibana-operations
|
|
|
|
/src/legacy/server/sass/ @elastic/kibana-operations
|
|
|
|
/src/legacy/server/utils/ @elastic/kibana-operations
|
|
|
|
/src/legacy/server/warnings/ @elastic/kibana-operations
|
2020-05-15 19:09:39 +02:00
|
|
|
/.ci/es-snapshots/ @elastic/kibana-operations
|
|
|
|
/vars/ @elastic/kibana-operations
|
2019-05-10 00:43:58 +02:00
|
|
|
|
2020-05-13 23:09:42 +02:00
|
|
|
# Quality Assurance
|
|
|
|
/src/dev/code_coverage @elastic/kibana-qa
|
2020-07-01 01:00:45 +02:00
|
|
|
/vars/*Coverage.groovy @elastic/kibana-qa
|
2020-05-15 18:28:28 +02:00
|
|
|
/test/functional/services/common @elastic/kibana-qa
|
|
|
|
/test/functional/services/lib @elastic/kibana-qa
|
|
|
|
/test/functional/services/remote @elastic/kibana-qa
|
2020-05-13 23:09:42 +02:00
|
|
|
|
2019-03-11 17:21:36 +01:00
|
|
|
# Platform
|
|
|
|
/src/core/ @elastic/kibana-platform
|
2019-08-01 00:31:39 +02:00
|
|
|
/config/kibana.yml @elastic/kibana-platform
|
2019-09-09 19:15:58 +02:00
|
|
|
/x-pack/plugins/features/ @elastic/kibana-platform
|
2019-10-30 14:45:20 +01:00
|
|
|
/x-pack/plugins/licensing/ @elastic/kibana-platform
|
2020-06-04 16:18:02 +02:00
|
|
|
/x-pack/plugins/global_search/ @elastic/kibana-platform
|
2020-05-26 20:56:51 +02:00
|
|
|
/x-pack/plugins/cloud/ @elastic/kibana-platform
|
2020-07-07 16:53:47 +02:00
|
|
|
/x-pack/test/saved_objects_field_count/ @elastic/kibana-platform
|
2019-11-26 12:56:31 +01:00
|
|
|
/packages/kbn-config-schema/ @elastic/kibana-platform
|
2019-12-06 08:23:48 +01:00
|
|
|
/src/legacy/server/config/ @elastic/kibana-platform
|
|
|
|
/src/legacy/server/http/ @elastic/kibana-platform
|
|
|
|
/src/legacy/server/logging/ @elastic/kibana-platform
|
|
|
|
/src/legacy/server/saved_objects/ @elastic/kibana-platform
|
|
|
|
/src/legacy/server/status/ @elastic/kibana-platform
|
2020-03-05 22:16:37 +01:00
|
|
|
/src/plugins/status_page/ @elastic/kibana-platform
|
2020-03-26 12:43:54 +01:00
|
|
|
/src/plugins/saved_objects_management/ @elastic/kibana-platform
|
2020-03-10 22:24:05 +01:00
|
|
|
/src/dev/run_check_published_api_changes.ts @elastic/kibana-platform
|
2019-03-11 17:21:36 +01:00
|
|
|
|
2019-01-17 20:18:28 +01:00
|
|
|
# Security
|
2019-12-13 22:57:17 +01:00
|
|
|
/src/core/server/csp/ @elastic/kibana-security @elastic/kibana-platform
|
2019-06-18 20:45:53 +02:00
|
|
|
/x-pack/legacy/plugins/security/ @elastic/kibana-security
|
2020-08-13 19:38:57 +02:00
|
|
|
/x-pack/legacy/plugins/security/**/*.scss @elastic/kibana-core-ui-designers
|
2019-06-18 20:45:53 +02:00
|
|
|
/x-pack/legacy/plugins/spaces/ @elastic/kibana-security
|
2020-08-13 19:38:57 +02:00
|
|
|
/x-pack/legacy/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
|
2019-11-01 20:37:38 +01:00
|
|
|
/x-pack/plugins/spaces/ @elastic/kibana-security
|
2020-08-13 19:38:57 +02:00
|
|
|
/x-pack/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
|
2019-11-01 22:32:12 +01:00
|
|
|
/x-pack/plugins/encrypted_saved_objects/ @elastic/kibana-security
|
2019-07-23 13:40:33 +02:00
|
|
|
/x-pack/plugins/security/ @elastic/kibana-security
|
2020-08-13 19:38:57 +02:00
|
|
|
/x-pack/plugins/security/**/*.scss @elastic/kibana-core-ui-designers
|
2019-10-12 00:02:53 +02:00
|
|
|
/x-pack/test/api_integration/apis/security/ @elastic/kibana-security
|
2020-08-18 08:38:23 +02:00
|
|
|
/x-pack/test/encrypted_saved_objects_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/functional/apps/security/ @elastic/kibana-security
|
|
|
|
/x-pack/test/kerberos_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/login_selector_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/oidc_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/pki_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/saml_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/security_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/security_functional/ @elastic/kibana-security
|
|
|
|
/x-pack/test/spaces_api_integration/ @elastic/kibana-security
|
|
|
|
/x-pack/test/token_api_integration/ @elastic/kibana-security
|
2019-01-17 20:18:28 +01:00
|
|
|
|
2019-12-12 19:41:10 +01:00
|
|
|
# Kibana Localization
|
2020-04-16 11:55:22 +02:00
|
|
|
/src/dev/i18n/ @elastic/kibana-localization
|
|
|
|
/src/legacy/server/i18n/ @elastic/kibana-localization
|
|
|
|
/src/core/public/i18n/ @elastic/kibana-localization
|
|
|
|
/packages/kbn-i18n/ @elastic/kibana-localization
|
2019-12-12 19:41:10 +01:00
|
|
|
|
2020-06-15 20:21:08 +02:00
|
|
|
# Kibana Telemetry
|
|
|
|
/packages/kbn-analytics/ @elastic/kibana-telemetry
|
2020-06-27 01:52:26 +02:00
|
|
|
/packages/kbn-telemetry-tools/ @elastic/kibana-telemetry
|
2020-06-15 20:21:08 +02:00
|
|
|
/src/plugins/kibana_usage_collection/ @elastic/kibana-telemetry
|
|
|
|
/src/plugins/newsfeed/ @elastic/kibana-telemetry
|
|
|
|
/src/plugins/telemetry/ @elastic/kibana-telemetry
|
|
|
|
/src/plugins/telemetry_collection_manager/ @elastic/kibana-telemetry
|
|
|
|
/src/plugins/telemetry_management_section/ @elastic/kibana-telemetry
|
|
|
|
/src/plugins/usage_collection/ @elastic/kibana-telemetry
|
|
|
|
/x-pack/plugins/telemetry_collection_xpack/ @elastic/kibana-telemetry
|
2020-06-27 01:52:26 +02:00
|
|
|
/.telemetryrc.json @elastic/kibana-telemetry
|
|
|
|
/x-pack/.telemetryrc.json @elastic/kibana-telemetry
|
|
|
|
src/plugins/telemetry/schema/legacy_oss_plugins.json @elastic/kibana-telemetry
|
|
|
|
src/plugins/telemetry/schema/oss_plugins.json @elastic/kibana-telemetry
|
|
|
|
x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kibana-telemetry
|
2019-12-12 19:41:10 +01:00
|
|
|
|
|
|
|
# Kibana Alerting Services
|
2020-06-02 03:45:36 +02:00
|
|
|
/x-pack/plugins/alerts/ @elastic/kibana-alerting-services
|
2020-02-11 21:41:32 +01:00
|
|
|
/x-pack/plugins/actions/ @elastic/kibana-alerting-services
|
2020-01-22 00:00:08 +01:00
|
|
|
/x-pack/plugins/event_log/ @elastic/kibana-alerting-services
|
2020-01-16 00:06:24 +01:00
|
|
|
/x-pack/plugins/task_manager/ @elastic/kibana-alerting-services
|
|
|
|
/x-pack/test/alerting_api_integration/ @elastic/kibana-alerting-services
|
|
|
|
/x-pack/test/plugin_api_integration/plugins/task_manager/ @elastic/kibana-alerting-services
|
|
|
|
/x-pack/test/plugin_api_integration/test_suites/task_manager/ @elastic/kibana-alerting-services
|
2020-02-18 18:05:56 +01:00
|
|
|
/x-pack/plugins/triggers_actions_ui/ @elastic/kibana-alerting-services
|
2020-01-14 01:16:20 +01:00
|
|
|
/x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/ @elastic/kibana-alerting-services
|
|
|
|
/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/ @elastic/kibana-alerting-services
|
2019-07-17 02:56:14 +02:00
|
|
|
|
2019-01-17 20:18:28 +01:00
|
|
|
# Design
|
2018-11-07 00:24:21 +01:00
|
|
|
**/*.scss @elastic/kibana-design
|
2019-01-17 20:18:28 +01:00
|
|
|
|
New Enterprise Search Kibana plugin (#66922)
* Initial App Search in Kibana plugin work
- Initializes a new platform plugin that ships out of the box w/ x-pack
- Contains a very basic front-end that shows AS engines, error states, or a Setup Guide
- Contains a very basic server that remotely calls the AS internal engines API and returns results
* Update URL casing to match Kibana best practices
- URL casing appears to be snake_casing, but kibana.json casing appears to be camelCase
* Register App Search plugin in Home Feature Catalogue
* Add custom App Search in Kibana logo
- I haven't had much success in surfacing a SVG file via a server-side endpoint/URL, but then I realized EuiIcon supports passing in a ReactElement directly. Woo!
* Fix appSearch.host config setting to be optional
- instead of crashing folks on load
* Rename plugin to Enterprise Search
- per product decision, URL should be enterprise_search/app_search and Workplace Search should also eventually live here
- reorganize folder structure in anticipation for another workplace_search plugin/codebase living alongside app_search
- rename app.tsx/main.tsx to a standard top-level index.tsx (which will contain top-level routes/state)
- rename AS->ES files/vars where applicable
- TODO: React Router
* Set up React Router URL structure
* Convert showSetupGuide action/flag to a React Router link
- remove showSetupGuide flag
- add a new shared helper component for combining EuiButton/EuiLink with React Router behavior (https://github.com/elastic/eui/blob/master/wiki/react-router.md#react-router-51)
* Implement Kibana Chrome breadcrumbs
- create shared helper (WS will presumably also want this) for generating EUI breadcrumb objects with React Router links+click behavior
- create React component that calls chrome.setBreadcrumbs on page mount
- clean up type definitions - move app-wide props to IAppSearchProps and update most pages/views to simply import it instead of calling their own definitions
* Added server unit tests (#2)
* Added unit test for server
* PR Feedback
* Refactor top-level Kibana props to a global context state
- rather them passing them around verbosely as props, the components that need them should be able to call the useContext hook
+ Remove IAppSearchProps in favor of IKibanaContext
+ Also rename `appSearchUrl` to `enterpriseSearchUrl`, since this context will contained shared/Kibana-wide values/actions useful to both AS and WS
* Added unit tests for public (#4)
* application.test.ts
* Added Unit Test for EngineOverviewHeader
* Added Unit Test for generate_breadcrumbs
* Added Unit Test for set_breadcrumb.tsx
* Added a unit test for link_events
- Also changed link_events.tsx to link_events.ts since it's just TS, no
React
- Modified letBrowserHandleEvent so it will still return a false
boolean when target is blank
* Betterize these tests
Co-Authored-By: Constance <constancecchen@users.noreply.github.com>
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Add UI telemetry tracking to AS in Kibana (#5)
* Set up Telemetry usageCollection, savedObjects, route, & shared helper
- The Kibana UsageCollection plugin handles collecting our telemetry UI data (views, clicks, errors, etc.) and pushing it to elastic's telemetry servers
- That data is stored in incremented in Kibana's savedObjects lib/plugin (as well as mapped)
- When an end-user hits a certain view or action, the shared helper will ping the app search telemetry route which increments the savedObject store
* Update client-side views/links to new shared telemetry helper
* Write tests for new telemetry files
* Implement remaining unit tests (#7)
* Write tests for React Router+EUI helper components
* Update generate_breadcrumbs test
- add test suite for generateBreadcrumb() itself (in order to cover a missing branch)
- minor lint fixes
- remove unnecessary import from set_breadcrumbs test
* Write test for get_username util
+ update test to return a more consistent falsey value (null)
* Add test for SetupGuide
* [Refactor] Pull out various Kibana context mocks into separate files
- I'm creating a reusable useContext mock for shallow()ed enzyme components
+ add more documentation comments + examples
* Write tests for empty state components
+ test new usecontext shallow mock
* Empty state components: Add extra getUserName branch test
* Write test for app search index/routes
* Write tests for engine overview table
+ fix bonus bug
* Write Engine Overview tests
+ Update EngineOverview logic to account for issues found during tests :)
- Move http to async/await syntax instead of promise syntax (works better with existing HttpServiceMock jest.fn()s)
- hasValidData wasn't strict enough in type checking/object nest checking and was causing the app itself to crash (no bueno)
* Refactor EngineOverviewHeader test to use shallow + to full coverage
- missed adding this test during telemetry work
- switching to shallow and beforeAll reduces the test time from 5s to 4s!
* [Refactor] Pull out React Router history mocks into a test util helper
+ minor refactors/updates
* Add small tests to increase branch coverage
- mostly testing fallbacks or removing fallbacks in favor of strict type interface
- these are slightly obsessive so I'd also be fine ditching them if they aren't terribly valuable
* Address larger tech debt/TODOs (#8)
* Fix optional chaining TODO
- turns out my local Prettier wasn't up to date, completely my bad
* Fix constants TODO
- adds a common folder/architecture for others to use in the future
* Remove TODO for eslint-disable-line and specify lint rule being skipped
- hopefully that's OK for review, I can't think of any other way to sanely do this without re-architecting the entire file or DDoSing our API
* Add server-side logging to route dependencies
+ add basic example of error catching/logging to Telemetry route
+ [extra] refactor mockResponseFactory name to something slightly easier to read
* Move more Engines Overview API logic/logging to server-side
- handle data validation in the server-side
- wrap server-side API in a try/catch to account for fetch issues
- more correctly return 2xx/4xx statuses and more correctly deal with those responses in the front-end
- Add server info/error/debug logs (addresses TODO)
- Update tests + minor refactors/cleanup
- remove expectResponseToBe200With helper (since we're now returning multiple response types) and instead make mockResponse var name more readable
- one-line header auth
- update tests with example error logs
- update schema validation for `type` to be an enum of `indexed`/`meta` (more accurately reflecting API)
* Per telemetry team feedback, rename usageCollection telemetry mapping name to simpler 'app_search'
- since their mapping already nests under 'kibana.plugins'
- note: I left the savedObjects name with the '_telemetry' suffix, as there very well may be a use case for top-level generic 'app_search' saved objects
* Update Setup Guide installation instructions (#9)
Co-authored-by: Chris Cressman <chris@chriscressman.com>
* [Refactor] DRY out route test helper
* [Refactor] Rename public/test_utils to public/__mocks__
- to better follow/use jest setups and for .mock.ts suffixes
* Add platinum licensing check to Meta Engines table/call (#11)
* Licensing plugin setup
* Add LicensingContext setup
* Update EngineOverview to not hit meta engines API on platinum license
* Add Jest test helpers for future shallow/context use
* Update plugin to use new Kibana nav + URL update (#12)
* Update new nav categories to add Enterprise Search + update plugin to use new category
- per @johnbarrierwilson and Matt Riley, Enterprise Search should be under Kibana and above Observability
- Run `node scripts/check_published_api_changes.js --accept` since this new category affects public API
* [URL UPDATE] Change '/app/enterprise_search/app_search' to '/app/app_search'
- This needs to be done because App Search and Workplace search *have* to be registered as separate plugins to have 2 distinct nav links
- Currently Kibana doesn't support nested app names (see: https://github.com/elastic/kibana/issues/59190) but potentially will in the future
- To support this change, we need to update applications/index.tsx to NOT handle '/app/enterprise_search' level routing, but instead accept an async imported app component (e.g. AppSearch, WorkplaceSearch).
- AppSearch should now treat its router as root '/' instead of '/app_search'
- (Addl) Per Josh Dover's recommendation, switch to `<Router history={params.history}>` from `<BrowserRouter basename={params.appBasePath}>` since they're deprecating appBasePath
* Update breadcrumbs helper to account for new URLs
- Remove path for Enterprise Search breadcrumb, since '/app/enterprise_search' will not link anywhere meaningful for the foreseeable future, so the Enterprise Search root should not go anywhere
- Update App Search helper to go to root path, per new React Router setup
Test changes:
- Mock custom basepath for App Search tests
- Swap enterpriseSearchBreadcrumbs and appSearchBreadcrumbs test order (since the latter overrides the default mock)
* Add create_first_engine_button telemetry tracking to EmptyState
* Switch plugin URLs back to /app/enterprise_search/app_search
Now that https://github.com/elastic/kibana/pull/66455 has been merged in :tada:
* Add i18n formatted messages / translations (#13)
* Add i18n provider and formatted/i18n translated messages
* Update tests to account for new I18nProvider context + FormattedMessage components
- Add new mountWithContext helper that provides all contexts+providers used in top-level app
- Add new shallowWithIntl helper for shallow() components that dive into FormattedMessage
* Format i18n dates and numbers
+ update some mock tests to not throw react-intl invalid date messages
* Update EngineOverviewHeader to disable button on prop
* Address review feedback (#14)
* Fix Prettier linting issues
* Escape App Search API endpoint URLs
- per PR feedback
- querystring should automatically encodeURIComponent / escape query param strings
* Update server plugin.ts to use getStartServices() rather than storing local references from start()
- Per feedback: https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#applications
- Note: savedObjects.registerType needs to be outside of getStartServices, or an error is thrown
- Side update to registerTelemetryUsageCollector to simplify args
- Update/fix tests to account for changes
* E2E testing (#6)
* Wired up basics for E2E testing
* Added version with App Search
* Updated naming
* Switched configuration around
* Added concept of 'fixtures'
* Figured out how to log in as the enterprise_search user
* Refactored to use an App Search service
* Added some real tests
* Added a README
* Cleanup
* More cleanup
* Error handling + README updatre
* Removed unnecessary files
* Apply suggestions from code review
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine_overview/engine_table.tsx
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* PR feedback - updated README
* Additional lint fixes
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
* Add README and CODEOWNERS (#15)
* Add plugin README and CODEOWNERS
* Fix Typescript errors (#16)
* Fix public mocks
* Fix empty states types
* Fix engine table component errors
* Fix engine overview component errors
* Fix setup guide component errors
- SetBreadcrumbs will be fixed in a separate commit
* Fix App Search index errors
* Fix engine overview header component errors
* Fix applications context index errors
* Fix kibana breadcrumb helper errors
* Fix license helper errors
* :exclamation: Refactor React Router EUI link/button helpers
- in order to fix typescript errors
- this changes the component logic significantly to a react render prop, so that the Link and Button components can have different types - however, end behavior should still remain the same
* Fix telemetry helper errors
* Minor unused var cleanup in plugin files
* Fix telemetry collector/savedobjects errors
* Fix MockRouter type errors and add IRouteDependencies export
- routes will use IRouteDependencies in the next few commits
* Fix engines route errors
* Fix telemetry route errors
* Remove any type from source code
- thanks to Scotty for the inspiration
* Add eslint rules for Enterprise Search plugin
- Add checks for type any, but only on non-test files
- Disable react-hooks/exhaustive-deps, since we're already disabling it in a few files and other plugins also have it turned off
* Cover uncovered lines in engines_table and telemetry tests
* Fixed TS warnings in E2E tests (#17)
* Feedback: Convert static CSS values to EUI variables where possible
* Feedback: Flatten nested CSS where possible
- Prefer setting CSS class overrides on individual EUI components, not on a top-level page
+ Change CSS class casing from kebab-case to camelCase to better match EUI/Kibana
+ Remove unnecessary .euiPageContentHeader margin-bottom override by changing the panelPaddingSize of euiPageContent
+ Decrease engine overview table padding on mobile
* Refactor out components shared with Workplace Search (#18)
* Move getUserName helper to shared
- in preparation for Workplace Search plugin also using this helper
* Move Setup Guide layout to a shared component
* Setup Guide: add extra props for standard/native auth links
Note: It's possible this commit may be unnecessary if we can publish shared Enterprise Search security mode docs
* Update copy per feedback from copy team
* Address various telemetry issues
- saved objects: removing indexing per #43673
- add schema and generate json per #64942
- move definitions over to collectors since saved objects is mostly empty at this point, and schema throws an error when it imports an obj instead of being defined inline
- istanbul ignore saved_objects file since it doesn't have anything meaningful to test but was affecting code coverage
* Disable plugin access if a normal user does not have access to App Search (#19)
* Set up new server security dependency and configs
* Set up access capabilities
* Set up checkAccess helper/caller
* Remove NoUserState component from the public UI
- Since this is now being handled by checkAccess / normal users should never see the plugin at all if they don't have an account/access, the component is no longer needed
* Update server routes to account for new changes
- Remove login redirect catch from routes, since the access helper should now handle that for most users by disabling the plugin (superusers will see a generic cannot connect/error screen)
- Refactor out new config values to a shared mock
* Refactor Enterprise Search http call to hit/return new internal API endpoint
+ pull out the http call to a separate library for upcoming public URL work (so that other files can call it directly as well)
* [Discussion] Increase timeout but add another warning timeout for slow servers
- per recommendation/convo with Brandon
* Register feature control
* Remove no_as_account from UI telemetry
- since we're no longer tracking that in the UI
* Address PR feedback - isSuperUser check
* Public URL support for Elastic Cloud (#21)
* Add server-side public URL route
- Per feedback from Kibana platform team, it's not possible to pass info from server/ to public/ without a HTTP call :[
* Update MockRouter for routes without any payload/params
* Add client-side helper for calling the new public URL API
+ API seems to return a URL a trailing slash, which we need to omit
* Update public/plugin.ts to check and set a public URL
- relies on this.hasCheckedPublicUrl to only make the call once per page load instead of on every page nav
* Fix failing feature control tests
- Split up scenario cases as needed
- Add plugin as an exception alongside ML & Monitoring
* Address PR feedback
- version: kibana
- copy edits
- Sass vars
- code cleanup
* Casing feedback: change all plugin registration IDs from snake_case to camelCase
- note: current remainng snake_case exceptions are telemetry keys
- file names and api endpoints are snake_case per conventions
* Misc security feedback
- remove set
- remove unnecessary capabilities registration
- telemetry namespace agnostic
* Security feedback: add warn logging to telemetry collector
see https://github.com/elastic/kibana/pull/66922#discussion_r451215760
- add if statement
- pass log dependency around (this is kinda medium, should maybe refactor)
- update tests
- move test file comment to the right file (was meant for telemetry route file)
* Address feedback from Pierre
- Remove unnecessary ServerConfigType
- Remove unnecessary uiCapabilities
- Move registerTelemetryRoute / SavedObjectsServiceStart workaround
- Remove unnecessary license optional chaining
* PR feedback
Address type/typos
* Fix telemetry API call returning 415 on Chrome
- I can't even?? I swear charset=utf-8 fixed the same error a few weeks ago
* Fix failing tests
* Update Enterprise Search functional tests (without host) to run on CI
- Fix incorrect navigateToApp slug (hadn't realized this was a URL, not an ID)
- Update without_host_configured tests to run without API key
- Update README
* Address PR feedback from Pierre
- remove unnecessary authz?
- remove unnecessary content-type json headers
- add loggingSystemMock.collect(mockLogger).error assertion
- reconstrcut new MockRouter on beforeEach for better sandboxing
- fix incorrect describe()s -should be it()
- pull out reusable mockDependencies helper (renamed/extended from mockConfig) for tests that don't particularly use config/log but still want to pass type definitions
- Fix comment copy
Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Co-authored-by: Chris Cressman <chris@chriscressman.com>
Co-authored-by: scottybollinger <scotty.bollinger@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-07-09 22:10:31 +02:00
|
|
|
# Enterprise Search
|
|
|
|
/x-pack/plugins/enterprise_search/ @elastic/app-search-frontend @elastic/workplace-search-frontend
|
|
|
|
/x-pack/test/functional_enterprise_search/ @elastic/app-search-frontend @elastic/workplace-search-frontend
|
|
|
|
/x-pack/plugins/enterprise_search/**/*.scss @elastic/ent-search-design
|
|
|
|
|
2019-01-17 20:18:28 +01:00
|
|
|
# Elasticsearch UI
|
2020-04-06 18:36:22 +02:00
|
|
|
/src/plugins/dev_tools/ @elastic/es-ui
|
2020-01-30 10:51:02 +01:00
|
|
|
/src/plugins/console/ @elastic/es-ui
|
2019-08-04 21:36:53 +02:00
|
|
|
/src/plugins/es_ui_shared/ @elastic/es-ui
|
2019-06-18 20:45:53 +02:00
|
|
|
/x-pack/legacy/plugins/cross_cluster_replication/ @elastic/es-ui
|
2020-04-10 01:51:22 +02:00
|
|
|
/x-pack/plugins/index_lifecycle_management/ @elastic/es-ui
|
2019-06-18 20:45:53 +02:00
|
|
|
/x-pack/legacy/plugins/index_management/ @elastic/es-ui
|
|
|
|
/x-pack/legacy/plugins/license_management/ @elastic/es-ui
|
|
|
|
/x-pack/legacy/plugins/rollup/ @elastic/es-ui
|
|
|
|
/x-pack/legacy/plugins/snapshot_restore/ @elastic/es-ui
|
2020-02-25 15:31:04 +01:00
|
|
|
/x-pack/legacy/plugins/upgrade_assistant/ @elastic/es-ui
|
2020-04-01 18:36:48 +02:00
|
|
|
/x-pack/plugins/console_extensions/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/es_ui_shared/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/grokdebugger/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/index_management/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/license_management/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/painless_lab/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/remote_clusters/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/rollup/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/searchprofiler/ @elastic/es-ui
|
|
|
|
/x-pack/plugins/snapshot_restore/ @elastic/es-ui
|
2020-02-25 15:31:04 +01:00
|
|
|
/x-pack/plugins/upgrade_assistant/ @elastic/es-ui
|
2020-01-23 15:35:36 +01:00
|
|
|
/x-pack/plugins/watcher/ @elastic/es-ui
|
2020-04-30 21:52:14 +02:00
|
|
|
/x-pack/plugins/ingest_pipelines/ @elastic/es-ui
|
2020-02-19 00:15:45 +01:00
|
|
|
|
|
|
|
# Endpoint
|
2020-04-29 16:25:12 +02:00
|
|
|
/x-pack/plugins/endpoint/ @elastic/endpoint-app-team @elastic/siem
|
2020-08-13 17:44:22 +02:00
|
|
|
/x-pack/plugins/endpoint/**/*.scss @elastic/security-design
|
2020-04-29 16:25:12 +02:00
|
|
|
/x-pack/test/api_integration/apis/endpoint/ @elastic/endpoint-app-team @elastic/siem
|
|
|
|
/x-pack/test/endpoint_api_integration_no_ingest/ @elastic/endpoint-app-team @elastic/siem
|
2020-06-10 23:10:34 +02:00
|
|
|
/x-pack/test/security_solution_endpoint/ @elastic/endpoint-app-team @elastic/siem
|
2020-04-29 16:25:12 +02:00
|
|
|
/x-pack/test/functional/es_archives/endpoint/ @elastic/endpoint-app-team @elastic/siem
|
|
|
|
/x-pack/test/plugin_functional/plugins/resolver_test/ @elastic/endpoint-app-team @elastic/siem
|
|
|
|
/x-pack/test/plugin_functional/test_suites/resolver/ @elastic/endpoint-app-team @elastic/siem
|
2020-02-20 20:56:03 +01:00
|
|
|
|
2020-06-04 11:35:13 +02:00
|
|
|
# Security Solution
|
|
|
|
/x-pack/plugins/security_solution/ @elastic/siem @elastic/endpoint-app-team
|
2020-08-13 17:44:22 +02:00
|
|
|
/x-pack/plugins/security_solution/**/*.scss @elastic/security-design
|
2020-04-29 16:25:12 +02:00
|
|
|
/x-pack/test/detection_engine_api_integration @elastic/siem @elastic/endpoint-app-team
|
2020-08-19 20:30:11 +02:00
|
|
|
/x-pack/test/lists_api_integration @elastic/siem @elastic/endpoint-app-team
|
2020-06-04 11:35:13 +02:00
|
|
|
/x-pack/test/api_integration/apis/security_solution @elastic/siem @elastic/endpoint-app-team
|
2020-04-29 16:25:12 +02:00
|
|
|
/x-pack/plugins/case @elastic/siem @elastic/endpoint-app-team
|
|
|
|
/x-pack/plugins/lists @elastic/siem @elastic/endpoint-app-team
|
2020-02-28 16:38:23 +01:00
|
|
|
|
|
|
|
# Security Intelligence And Analytics
|
2020-06-04 11:35:13 +02:00
|
|
|
/x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules @elastic/security-intelligence-analytics
|