[Visualize] Remove alias icon for Lens and Maps (#76418)

* [Visualize] Remove alias icon for Lens and Maps

* Fix snapshots

* Fix translations
This commit is contained in:
Wylie Conlon 2020-09-02 10:34:37 -04:00 committed by GitHub
parent 3e077973e8
commit 01e442081f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 16 additions and 170 deletions

View file

@ -248,7 +248,7 @@ exports[`NewVisModal filter for visualization types should render as expected 1`
<li>
<button
aria-describedby="visTypeDescription-visWithAliasUrl"
class="euiKeyPadMenuItem euiKeyPadMenuItem--hasBetaBadge visNewVisDialog__type"
class="euiKeyPadMenuItem visNewVisDialog__type"
data-test-subj="visType-visWithAliasUrl"
data-vis-stage="alias"
role="menuitem"
@ -257,24 +257,6 @@ exports[`NewVisModal filter for visualization types should render as expected 1`
<div
class="euiKeyPadMenuItem__inner"
>
<span
class="euiKeyPadMenuItem__betaBadgeWrapper"
>
<span
class="euiToolTipAnchor"
>
<span
class="euiBetaBadge euiBetaBadge--iconOnly euiKeyPadMenuItem__betaBadge"
tabindex="0"
>
<div
aria-hidden="true"
class="euiBetaBadge__icon"
data-euiicon-type="popout"
/>
</span>
</span>
</span>
<div
class="euiKeyPadMenuItem__icon"
>
@ -650,9 +632,6 @@ exports[`NewVisModal filter for visualization types should render as expected 1`
>
<EuiKeyPadMenuItem
aria-describedby="visTypeDescription-visWithAliasUrl"
betaBadgeIconType="popout"
betaBadgeLabel="Kibana application"
betaBadgeTooltipContent="Opens a Kibana application that is outside of Visualize."
className="visNewVisDialog__type"
data-test-subj="visType-visWithAliasUrl"
data-vis-stage="alias"
@ -674,7 +653,7 @@ exports[`NewVisModal filter for visualization types should render as expected 1`
>
<button
aria-describedby="visTypeDescription-visWithAliasUrl"
className="euiKeyPadMenuItem euiKeyPadMenuItem--hasBetaBadge visNewVisDialog__type"
className="euiKeyPadMenuItem visNewVisDialog__type"
data-test-subj="visType-visWithAliasUrl"
data-vis-stage="alias"
disabled={false}
@ -689,51 +668,6 @@ exports[`NewVisModal filter for visualization types should render as expected 1`
<div
className="euiKeyPadMenuItem__inner"
>
<span
className="euiKeyPadMenuItem__betaBadgeWrapper"
>
<EuiBetaBadge
className="euiKeyPadMenuItem__betaBadge"
iconType="popout"
label="Kibana application"
tooltipContent="Opens a Kibana application that is outside of Visualize."
>
<EuiToolTip
content="Opens a Kibana application that is outside of Visualize."
delay="regular"
position="top"
title="Kibana application"
>
<span
className="euiToolTipAnchor"
onKeyUp={[Function]}
onMouseOut={[Function]}
onMouseOver={[Function]}
>
<span
className="euiBetaBadge euiBetaBadge--iconOnly euiKeyPadMenuItem__betaBadge"
onBlur={[Function]}
onFocus={[Function]}
tabIndex={0}
>
<EuiIcon
aria-hidden="true"
className="euiBetaBadge__icon"
size="m"
type="popout"
>
<div
aria-hidden="true"
className="euiBetaBadge__icon"
data-euiicon-type="popout"
size="m"
/>
</EuiIcon>
</span>
</span>
</EuiToolTip>
</EuiBetaBadge>
</span>
<div
className="euiKeyPadMenuItem__icon"
>
@ -1243,7 +1177,7 @@ exports[`NewVisModal should render as expected 1`] = `
<li>
<button
aria-describedby="visTypeDescription-visWithAliasUrl"
class="euiKeyPadMenuItem euiKeyPadMenuItem--hasBetaBadge visNewVisDialog__type"
class="euiKeyPadMenuItem visNewVisDialog__type"
data-test-subj="visType-visWithAliasUrl"
data-vis-stage="alias"
role="menuitem"
@ -1252,24 +1186,6 @@ exports[`NewVisModal should render as expected 1`] = `
<div
class="euiKeyPadMenuItem__inner"
>
<span
class="euiKeyPadMenuItem__betaBadgeWrapper"
>
<span
class="euiToolTipAnchor"
>
<span
class="euiBetaBadge euiBetaBadge--iconOnly euiKeyPadMenuItem__betaBadge"
tabindex="0"
>
<div
aria-hidden="true"
class="euiBetaBadge__icon"
data-euiicon-type="popout"
/>
</span>
</span>
</span>
<div
class="euiKeyPadMenuItem__icon"
>
@ -1632,9 +1548,6 @@ exports[`NewVisModal should render as expected 1`] = `
>
<EuiKeyPadMenuItem
aria-describedby="visTypeDescription-visWithAliasUrl"
betaBadgeIconType="popout"
betaBadgeLabel="Kibana application"
betaBadgeTooltipContent="Opens a Kibana application that is outside of Visualize."
className="visNewVisDialog__type"
data-test-subj="visType-visWithAliasUrl"
data-vis-stage="alias"
@ -1656,7 +1569,7 @@ exports[`NewVisModal should render as expected 1`] = `
>
<button
aria-describedby="visTypeDescription-visWithAliasUrl"
className="euiKeyPadMenuItem euiKeyPadMenuItem--hasBetaBadge visNewVisDialog__type"
className="euiKeyPadMenuItem visNewVisDialog__type"
data-test-subj="visType-visWithAliasUrl"
data-vis-stage="alias"
disabled={false}
@ -1671,51 +1584,6 @@ exports[`NewVisModal should render as expected 1`] = `
<div
className="euiKeyPadMenuItem__inner"
>
<span
className="euiKeyPadMenuItem__betaBadgeWrapper"
>
<EuiBetaBadge
className="euiKeyPadMenuItem__betaBadge"
iconType="popout"
label="Kibana application"
tooltipContent="Opens a Kibana application that is outside of Visualize."
>
<EuiToolTip
content="Opens a Kibana application that is outside of Visualize."
delay="regular"
position="top"
title="Kibana application"
>
<span
className="euiToolTipAnchor"
onKeyUp={[Function]}
onMouseOut={[Function]}
onMouseOver={[Function]}
>
<span
className="euiBetaBadge euiBetaBadge--iconOnly euiKeyPadMenuItem__betaBadge"
onBlur={[Function]}
onFocus={[Function]}
tabIndex={0}
>
<EuiIcon
aria-hidden="true"
className="euiBetaBadge__icon"
size="m"
type="popout"
>
<div
aria-hidden="true"
className="euiBetaBadge__icon"
data-euiicon-type="popout"
size="m"
/>
</EuiIcon>
</span>
</span>
</EuiToolTip>
</EuiBetaBadge>
</span>
<div
className="euiKeyPadMenuItem__icon"
>

View file

@ -221,36 +221,18 @@ class TypeSelection extends React.Component<TypeSelectionProps, TypeSelectionSta
defaultMessage:
'This visualization is experimental. The design and implementation are less mature than stable visualizations and might be subject to change.',
});
} else if ('aliasPath' in visType) {
if (visType.stage === 'beta') {
const aliasDescription = i18n.translate('visualizations.newVisWizard.betaDescription', {
defaultMessage:
'This visualization is in beta and is subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features',
});
stage = {
betaBadgeLabel: i18n.translate('visualizations.newVisWizard.betaTitle', {
defaultMessage: 'Beta',
}),
betaBadgeTooltipContent: aliasDescription,
// betaBadgeIconType: 'popout',
};
highlightMsg = aliasDescription;
} else {
const aliasDescription = i18n.translate(
'visualizations.newVisWizard.visTypeAliasDescription',
{
defaultMessage: 'Opens a Kibana application that is outside of Visualize.',
}
);
stage = {
betaBadgeLabel: i18n.translate('visualizations.newVisWizard.visTypeAliasTitle', {
defaultMessage: 'Kibana application',
}),
betaBadgeTooltipContent: aliasDescription,
betaBadgeIconType: 'popout',
};
highlightMsg = aliasDescription;
}
} else if ('aliasPath' in visType && visType.stage === 'beta') {
const aliasDescription = i18n.translate('visualizations.newVisWizard.betaDescription', {
defaultMessage:
'This visualization is in beta and is subject to change. The design and code is less mature than official GA features and is being provided as-is with no warranties. Beta features are not subject to the support SLA of official GA features',
});
stage = {
betaBadgeLabel: i18n.translate('visualizations.newVisWizard.betaTitle', {
defaultMessage: 'Beta',
}),
betaBadgeTooltipContent: aliasDescription,
};
highlightMsg = aliasDescription;
}
const isDisabled = this.state.query !== '' && !visType.highlighted;

View file

@ -4433,8 +4433,6 @@
"visualizations.newVisWizard.searchSelection.savedObjectType.search": "保存検索",
"visualizations.newVisWizard.selectVisType": "ビジュアライゼーションのタイプを選択してください",
"visualizations.newVisWizard.title": "新規ビジュアライゼーション",
"visualizations.newVisWizard.visTypeAliasDescription": "Visualize 外で Kibana アプリケーションを開きます。",
"visualizations.newVisWizard.visTypeAliasTitle": "Kibana アプリケーション",
"visualizations.savedObjectName": "ビジュアライゼーション",
"visualizations.visualizationTypeInvalidMessage": "無効なビジュアライゼーションタイプ \"{visType}\"",
"visualize.badge.readOnly.text": "読み取り専用",

View file

@ -4434,8 +4434,6 @@
"visualizations.newVisWizard.searchSelection.savedObjectType.search": "已保存搜索",
"visualizations.newVisWizard.selectVisType": "选择可视化类型",
"visualizations.newVisWizard.title": "新建可视化",
"visualizations.newVisWizard.visTypeAliasDescription": "打开 Visualize 外部的 Kibana 应用程序。",
"visualizations.newVisWizard.visTypeAliasTitle": "Kibana 应用程序",
"visualizations.savedObjectName": "可视化",
"visualizations.visualizationTypeInvalidMessage": "无效的可视化类型“{visType}”",
"visualize.badge.readOnly.text": "只读",