maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[ML] Renaming ML setup and start contracts (#60980)

Browse source
This commit is contained in:
James Gowdy 2020-03-24 14:25:59 +00:00 committed by GitHub
parent babefb5737
commit 04360ef6f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
x-pack/plugins/ml/public/index.ts
View file

@ -6,8 +6,8 @@
import { PluginInitializer } from 'kibana/public';
import './index.scss';
import { MlPlugin, Setup, Start } from './plugin';
import { MlPlugin, MlPluginSetup, MlPluginStart } from './plugin';
export const plugin: PluginInitializer<Setup, Start> = () => new MlPlugin();
export const plugin: PluginInitializer<MlPluginSetup, MlPluginStart> = () => new MlPlugin();
export { Setup, Start };
export { MlPluginSetup, MlPluginStart };

6
x-pack/plugins/ml/public/plugin.ts
View file

@ -28,7 +28,7 @@ export interface MlSetupDependencies {
usageCollection: UsageCollectionSetup;
}
export class MlPlugin implements Plugin<Setup, Start> {
export class MlPlugin implements Plugin<MlPluginSetup, MlPluginStart> {
setup(core: CoreSetup<MlStartDependencies>, pluginsSetup: MlSetupDependencies) {
core.application.register({
id: PLUGIN_ID,
@ -77,5 +77,5 @@ export class MlPlugin implements Plugin<Setup, Start> {
public stop() {}
}
export type Setup = ReturnType<MlPlugin['setup']>;
export type Start = ReturnType<MlPlugin['start']>;
export type MlPluginSetup = ReturnType<MlPlugin['setup']>;
export type MlPluginStart = ReturnType<MlPlugin['start']>;

2
x-pack/plugins/ml/server/index.ts
View file

@ -6,6 +6,6 @@
import { PluginInitializerContext } from 'kibana/server';
import { MlServerPlugin } from './plugin';
export { MlStartContract, MlSetupContract } from './plugin';
export { MlPluginSetup, MlPluginStart } from './plugin';
export const plugin = (ctx: PluginInitializerContext) => new MlServerPlugin(ctx);

10
x-pack/plugins/ml/server/plugin.ts
View file

@ -49,10 +49,10 @@ declare module 'kibana/server' {
}
}
export type MlSetupContract = SharedServices;
export type MlStartContract = void;
export type MlPluginSetup = SharedServices;
export type MlPluginStart = void;
export class MlServerPlugin implements Plugin<MlSetupContract, MlStartContract, PluginsSetup> {
export class MlServerPlugin implements Plugin<MlPluginSetup, MlPluginStart, PluginsSetup> {
private log: Logger;
private version: string;
private mlLicense: MlServerLicense;
@ -63,7 +63,7 @@ export class MlServerPlugin implements Plugin<MlSetupContract, MlStartContract,
this.mlLicense = new MlServerLicense();
}
public setup(coreSetup: CoreSetup, plugins: PluginsSetup): MlSetupContract {
public setup(coreSetup: CoreSetup, plugins: PluginsSetup): MlPluginSetup {
plugins.features.registerFeature({
id: PLUGIN_ID,
name: i18n.translate('xpack.ml.featureRegistry.mlFeatureName', {
@ -135,7 +135,7 @@ export class MlServerPlugin implements Plugin<MlSetupContract, MlStartContract,
return createSharedServices(this.mlLicense, plugins.spaces, plugins.cloud);
}
public start(): MlStartContract {}
public start(): MlPluginStart {}
public stop() {
this.mlLicense.unsubscribe();