maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

When on an embedded page, bypass Getting Started gate check (#12040)

Browse source 
* When on an embedded page, bypass Getting Started gate check

* Add unit test for embedded page scenario
This commit is contained in:
Shaunak Kashyap 2017-05-26 13:01:38 -07:00
parent b994f600e5
commit 05293f1c8d
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/core_plugins/getting_started/public/lib/__tests__/add_setup_work.js
View file

@ -31,6 +31,16 @@ describe('Getting Started page', () => {
set($route, 'current.$$route', {});
});
describe('if the user is on an embedded page', () => {
beforeEach(() => {
set($route, 'current.params.embed', true);
});
it('should not show the UI chrome', () => {
expect(uiChrome.getVisible()).to.be(false);
});
});
describe('if index patterns exist', () => {
beforeEach(() => {
config = {

5
src/core_plugins/getting_started/public/lib/add_setup_work.js
View file

@ -75,6 +75,11 @@ function showGettingStartedPage(kbnUrl, isOnGettingStartedPage) {
export function gettingStartedGateCheck(getIds, kbnUrl, config, $route) {
const currentRoute = get($route, 'current.$$route');
const isOnGettingStartedPage = get(currentRoute, 'originalPath') === GETTING_STARTED_ROUTE;
const isOnEmbeddedPage = Boolean(get($route, 'current.params.embed', false));
if (isOnEmbeddedPage) {
return Promise.resolve();
}
return getIds()
.then(indexPatterns => {