maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

[discover] fix shared links tests for cloud testing (#47572)

Browse source 
* Add method to open permalinks menu entry if available

* Migrate to TypeScript
This commit is contained in:
Matthias Wilhelm 2019-10-09 07:34:51 +02:00 committed by GitHub
parent 46fbbd6a2f
commit 08de89b588
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
test/functional/page_objects/share_page.js → test/functional/page_objects/share_page.ts
View file

@ -17,7 +17,9 @@
* under the License.
*/
export function SharePageProvider({ getService, getPageObjects }) {
import { FtrProviderContext } from '../ftr_provider_context';
export function SharePageProvider({ getService, getPageObjects }: FtrProviderContext) {
const testSubjects = getService('testSubjects');
const find = getService('find');
const PageObjects = getPageObjects(['visualize', 'common']);
@ -32,7 +34,7 @@ export function SharePageProvider({ getService, getPageObjects }) {
return testSubjects.click('shareTopNavButton');
}
async openShareMenuItem(itemTitle) {
async openShareMenuItem(itemTitle: string) {
log.debug(`openShareMenuItem title:${itemTitle}`);
const isShareMenuOpen = await this.isShareMenuOpen();
if (!isShareMenuOpen) {
@ -45,11 +47,24 @@ export function SharePageProvider({ getService, getPageObjects }) {
await this.clickShareTopNavButton();
}
const menuPanel = await find.byCssSelector('div.euiContextMenuPanel');
testSubjects.click(`sharePanel-${itemTitle.replace(' ', '')}`);
await testSubjects.click(`sharePanel-${itemTitle.replace(' ', '')}`);
await testSubjects.waitForDeleted(menuPanel);
}
/**
* if there are more entries in the share menu, the permalinks entry has to be clicked first
* else the selection isn't displayed. this happens if you're testing against an instance
* with xpack features enabled, where there's also a csv sharing option
* in a pure OSS environment, the permalinks sharing panel is displayed initially
*/
async openPermaLinks() {
if (await testSubjects.exists('sharePanel-Permalinks')) {
await testSubjects.click(`sharePanel-Permalinks`);
}
}
async getSharedUrl() {
await this.openPermaLinks();
return await testSubjects.getAttribute('copyShareUrlButton', 'data-share-url');
}
@ -68,9 +83,9 @@ export function SharePageProvider({ getService, getPageObjects }) {
}
async exportAsSavedObject() {
await this.openPermaLinks();
return await testSubjects.click('exportAsSavedObject');
}
}
return new SharePage();