[SECURITY] Redirect app/security to app/security/overview (#70005)

* redirect app/security to app/security/overview

* missing re-naming initialization

* add unit test for intialization value of indicesExists

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This commit is contained in:
Xavier Mouligneau 2020-06-26 08:56:09 -04:00 committed by GitHub
parent 684aa68f17
commit 09e3f75bc3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 35 additions and 15 deletions

View file

@ -17,6 +17,24 @@ jest.mock('../../utils/apollo_context', () => ({
}));
describe('Index Fields & Browser Fields', () => {
test('At initialization the value of indicesExists should be true', async () => {
const { result, waitForNextUpdate } = renderHook(() => useWithSource());
const initialResult = result.current;
await waitForNextUpdate();
return expect(initialResult).toEqual({
browserFields: {},
errorMessage: null,
indexPattern: {
fields: [],
title: 'apm-*-transaction*,auditbeat-*,endgame-*,filebeat-*,packetbeat-*,winlogbeat-*',
},
indicesExist: true,
loading: true,
});
});
test('returns memoized value', async () => {
const { result, waitForNextUpdate, rerender } = renderHook(() => useWithSource());
await waitForNextUpdate();

View file

@ -102,7 +102,7 @@ export const useWithSource = (sourceId = 'default', indexToAdd?: string[] | null
browserFields: EMPTY_BROWSER_FIELDS,
errorMessage: null,
indexPattern: getIndexFields(defaultIndex.join(), []),
indicesExist: undefined,
indicesExist: indicesExistOrDataTemporarilyUnavailable(undefined),
loading: false,
});

View file

@ -7,12 +7,12 @@
import { i18n } from '@kbn/i18n';
export const EMPTY_TITLE = i18n.translate('xpack.securitySolution.pages.common.emptyTitle', {
defaultMessage: 'Welcome to SIEM. Lets get you started.',
defaultMessage: 'Welcome to Security Solution. Lets get you started.',
});
export const EMPTY_MESSAGE = i18n.translate('xpack.securitySolution.pages.common.emptyMessage', {
defaultMessage:
'To begin using security information and event management (SIEM), youll need to add SIEM-related data, in Elastic Common Schema (ECS) format, to the Elastic Stack. An easy way to get started is by installing and configuring our data shippers, called Beats. Lets do that now!',
'To begin using security information and event management (Security Solution), youll need to add security solution related data, in Elastic Common Schema (ECS) format, to the Elastic Stack. An easy way to get started is by installing and configuring our data shippers, called Beats. Lets do that now!',
});
export const EMPTY_ACTION_PRIMARY = i18n.translate(

View file

@ -16,6 +16,7 @@ import {
PluginInitializerContext,
Plugin as IPlugin,
DEFAULT_APP_CATEGORIES,
AppNavLinkStatus,
} from '../../../../src/core/public';
import { Storage } from '../../../../src/plugins/kibana_utils/public';
import { FeatureCatalogueCategory } from '../../../../src/plugins/home/public';
@ -35,6 +36,7 @@ import {
APP_CASES_PATH,
SHOW_ENDPOINT_ALERTS_NAV,
APP_ENDPOINT_ALERTS_PATH,
APP_PATH,
} from '../common/constants';
import { ConfigureEndpointDatasource } from './management/pages/policy/view/ingest_manager_integration/configure_datasource';
@ -86,18 +88,18 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S
return { coreStart, startPlugins, services, store: this.store, storage };
};
// Waiting for https://github.com/elastic/kibana/issues/69110
// core.application.register({
// id: APP_ID,
// title: 'Security',
// appRoute: APP_PATH,
// navLinkStatus: AppNavLinkStatus.hidden,
// mount: async (params: AppMountParameters) => {
// const [{ application }] = await core.getStartServices();
// application.navigateToApp(`${APP_ID}:${SecurityPageName.overview}`, { replace: true });
// return () => true;
// },
// });
core.application.register({
exactRoute: true,
id: APP_ID,
title: 'Security',
appRoute: APP_PATH,
navLinkStatus: AppNavLinkStatus.hidden,
mount: async (params: AppMountParameters) => {
const [{ application }] = await core.getStartServices();
application.navigateToApp(`${APP_ID}:${SecurityPageName.overview}`, { replace: true });
return () => true;
},
});
core.application.register({
id: `${APP_ID}:${SecurityPageName.overview}`,