diff --git a/scripts/functional_tests.js b/scripts/functional_tests.js index b25cd2323418..6f353ad4fd7b 100644 --- a/scripts/functional_tests.js +++ b/scripts/functional_tests.js @@ -25,6 +25,6 @@ require('@kbn/test').runTestsCli([ require.resolve('../test/interpreter_functional/config.ts'), require.resolve('../test/ui_capabilities/newsfeed_err/config.ts'), require.resolve('../test/examples/config.js'), - require.resolve('../test/new_visualize_flow/config.js'), + require.resolve('../test/new_visualize_flow/config.ts'), require.resolve('../test/security_functional/config.ts'), ]); diff --git a/tasks/function_test_groups.js b/tasks/function_test_groups.js index 4b7a7fc03fd0..19e6f1bfa8c2 100644 --- a/tasks/function_test_groups.js +++ b/tasks/function_test_groups.js @@ -46,7 +46,7 @@ export function getFunctionalTestGroupRunConfigs({ kibanaInstallDir } = {}) { '--config', 'test/ui_capabilities/newsfeed_err/config.ts', '--config', - 'test/new_visualize_flow/config.js', + 'test/new_visualize_flow/config.ts', '--config', 'test/security_functional/config.ts', // '--config', 'test/functional/config.firefox.js', diff --git a/test/new_visualize_flow/config.js b/test/new_visualize_flow/config.ts similarity index 90% rename from test/new_visualize_flow/config.js rename to test/new_visualize_flow/config.ts index c4790a35404c..2b5816922282 100644 --- a/test/new_visualize_flow/config.js +++ b/test/new_visualize_flow/config.ts @@ -17,18 +17,16 @@ * under the License. */ -import { pageObjects } from '../functional/page_objects'; -import { services } from '../functional/services'; +import { FtrConfigProviderContext } from '@kbn/test/types/ftr'; -export default async function ({ readConfigFile }) { +export default async function ({ readConfigFile }: FtrConfigProviderContext) { const commonConfig = await readConfigFile(require.resolve('../functional/config.js')); return { - testFiles: [require.resolve('./dashboard_embedding')], - pageObjects, - services, + testFiles: [require.resolve('./index.ts')], + pageObjects: commonConfig.get('pageObjects'), + services: commonConfig.get('services'), servers: commonConfig.get('servers'), - esTestCluster: commonConfig.get('esTestCluster'), kbnTestServer: { @@ -37,6 +35,7 @@ export default async function ({ readConfigFile }) { ...commonConfig.get('kbnTestServer.serverArgs'), '--oss', '--telemetry.optIn=false', + '--dashboard.allowByValueEmbeddables=true', ], }, @@ -105,7 +104,7 @@ export default async function ({ readConfigFile }) { }, kibana: [], }, - //for sample data - can remove but not add sample data + // for sample data - can remove but not add sample data kibana_sample_admin: { elasticsearch: { cluster: [], diff --git a/test/new_visualize_flow/dashboard_embedding.js b/test/new_visualize_flow/dashboard_embedding.ts similarity index 94% rename from test/new_visualize_flow/dashboard_embedding.js rename to test/new_visualize_flow/dashboard_embedding.ts index b1a6bd14547f..e947f2087269 100644 --- a/test/new_visualize_flow/dashboard_embedding.js +++ b/test/new_visualize_flow/dashboard_embedding.ts @@ -17,6 +17,7 @@ * under the License. */ +import { FtrProviderContext } from 'test/functional/ftr_provider_context'; import expect from '@kbn/expect'; /** @@ -27,7 +28,8 @@ import expect from '@kbn/expect'; * broke?). The upside is that this offers very good coverage with a minimal time investment. */ -export default function ({ getService, getPageObjects }) { +// eslint-disable-next-line import/no-default-export +export default function ({ getService, getPageObjects }: FtrProviderContext) { const esArchiver = getService('esArchiver'); const kibanaServer = getService('kibanaServer'); const dashboardExpect = getService('dashboardExpect');